Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wMSCS-0006SC-0c for pgsql-hackers@arkaria.postgresql.org; Mon, 11 May 2026 15:05:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wMSBQ-001LXW-2J for pgsql-hackers@arkaria.postgresql.org; Mon, 11 May 2026 15:04:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wMSBQ-001LXL-1F for pgsql-hackers@lists.postgresql.org; Mon, 11 May 2026 15:04:36 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wMSBN-000000003dt-0xx1 for pgsql-hackers@lists.postgresql.org; Mon, 11 May 2026 15:04:35 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-4303eb92930so3116402fac.3 for ; Mon, 11 May 2026 08:04:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778511873; cv=none; d=google.com; s=arc-20240605; b=AAv49WgeXZndEEQWUhFjXxED3r1+f3TTK0hJ2P2mXk4ShhdD952rVktVIbLcdexj8R 69BdmvsPASXABvz+RRa3K36xB83GrjeEiRHGC8McmwvxYXUdd9mFF9XnSXizv5dPcrdJ GUB3H3Nt8ECAsZqSwAn7X4hDkr8qYc3EkgoWdsuELDKv8NXyrz0YesGzYCmuWBzPFK5d d42zZ82CwDXN93vs9svz14oumpYsgCi1FSjNPBbMe6Y5Zo/UGNlvRj0ssbZJzQ+/o/Q3 UiXzXC5b3Q22g5hea/H/7TJMUhPZACFOtzAoggr4e/eMPWTNgUmov4tKVdwDkGOE1Lmg MYIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=k75QhujsbPlEIYeyKH75eo4nvURRoEFlpwVOwk/Q4tk=; fh=aTBWPYEAxtF232iLZZReX3y93+xNwtfs4w/qOS6IAR4=; b=J/Jv9QQ6yBZzCenGVegHPy0WnzgzN+iC4X2cdq02pzcrzb2yhJ05KdWCd4WH5TD/dr Nl8K73IzgI5sKLH9QE+rUy6dWrTzSxjNp5hQyA8F9eWK6srr3A90j1MzIslLeKT8ZhfD sYUkKDUP8ErvEfq8wvyOsbuPcK8WpnAG4FD2oj3PpAGLNQDGEnm59HL4LaU0TC1HFfq7 WLN1pm9JDlLepISc9o4jcTVItuaJjF987o73ZkaUKGOSXqUW/mGD0GdGqJrDi2HLrYyT lVJwya9Knj/XIblkkJzSgqvRVNhJMBNiRtkqkKrRzp9Y53pPVt9Z5LfIdyar2f7od5RB QTLw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tigerdata.com; s=google; t=1778511873; x=1779116673; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k75QhujsbPlEIYeyKH75eo4nvURRoEFlpwVOwk/Q4tk=; b=I0sWm6n83gKjaaWX5D757Yjj+SEU8aQcYj98ysD3pYGMfnNTIP578f3Gl/uffcI430 CKrgOeuvuazGdkUqa93jfNYk0b50HpAH981vVs0dnl96/ljzX2JIHE6RTzP3keir2xsm Pr99GDOruWHwz9rBrgT//3rOtjCbu6MVIDk+P/No0noNBM0GoKlJltTnhvGAUnew/e2P Nf9cWKOnXCtS+UXJto/IABzEi0HOWh2wPurVfxNjgfRwtXofbosZ4MGS8CIq7TI7Vf8V abofkcU9gdFMdeo+GtxWl8o/HeQp6mRRS9g3TnoCNvMQK6FKA+qEa1yNfR11AT2v3ni6 ljWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778511873; x=1779116673; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k75QhujsbPlEIYeyKH75eo4nvURRoEFlpwVOwk/Q4tk=; b=koCUgv1HjJ65c7zjEh55wr5H4u+vLE/vUSA0ZdBKlBiUr3a6SmKuAgSdWwqAJiy6h7 Cn0z3Qd4JqBulL87WuJXlWUj8fuVuCz6GzF+GLdh1xAvtr78Z3+ahGyEH7ReeZnhLM/t 43SxesZbkjlPAYwizcoPG8Fj7zY/tIqsPYELgs5sRNSC1Il/Vn1BRsllSBmo2twn9zfJ QZETPKCnWCheVw8Mv/aYlp9kBR/j69fpGBYL104YKKVJlV7Ky8E15MUiDHme6wIbFtIZ m1FZjo0+N5KOjsEysBI0hU13kk8LVXhho3IJM166nHsSeGFNBG8FRnjp87Uib6ysO4bZ w/mw== X-Gm-Message-State: AOJu0YwYxwBhshGxMjfXF8YOTFy1oQ4o4lMjqArZAZLE2sN0KyyhqKYd eMy02d4x4fbahbNRfvmwTx3nuuZ/m4my7IdT7JR/DLbd2Wh4bprPmHFgSIKUg4h/YVoAHW1IPtu /vma0FYm+VcjktMTdoE8Y8kYPe7VUMYl165DT5VusXw== X-Gm-Gg: Acq92OGDliO4puh0sB8QIZHrejN6uu1W+wg1XDMLEBxoDXN5PrERO0cM+1QoMa3HuLJ L4DBMELZdnyrUrG5rgPcfpt3Enmuw35D/B9Igtah/tEw9s68m8z+HZoebqOWyJyUvQGW2IpAGIR cs9HD8ppmmAaJrN/l2MWVPtWUIoUyDEVvPBvg+OayP7A7g1uEjLnvNQR6+wdDvhpBt8O6KWQOWl yulJ6o17aCKO8JdHZ1qNbiO6hFOw7BWqrlP4TD67oo7tWqKwxgG825nlZRmPE01IrX03fNFI2Mt GtQR392npGCLwn9YW77OLxIdxo+ZgjP3BxyRsPZ4170zaxxSpVl/cwjJwwtGMbnjWAw= X-Received: by 2002:a05:6871:a983:b0:417:2b13:f2cd with SMTP id 586e51a60fabf-43556b9a17amr8406996fac.10.1778511872514; Mon, 11 May 2026 08:04:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aleksander Alekseev Date: Mon, 11 May 2026 18:04:21 +0300 X-Gm-Features: AVHnY4JW_D2il9k1V7fMGJTheFczTlPaoAtkh23qGSDYDc4WyuZgCrQA03_RhVI Message-ID: Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments To: Payal Singh Cc: pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, > This is a review of the pgindent multiline comments patch: > > https://www.postgresql.org/message-id/attachment/189778/v6-0001-pgindent-improve-formatting-of-multiline-comments.patch Thanks for the feedback. In the future please submit your code reviews to the corresponding thread. You created a new one so anyone following the original thread [1][2] has a good chance to miss this discussion. I suggest continuing the discussion in [1]. [1]: https://www.postgresql.org/message-id/flat/CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw@mail.gmail.com [2]: https://commitfest.postgresql.org/patch/5831/ -- Best regards, Aleksander Alekseev