MIME-Version: 1.0
References: 
 <CAJ7c6TME+ix6VRf-2TPnVTsj8qn_hy6sYAOmMhZEivwsu2wS6g@mail.gmail.com>
 <626986.1776785090@sss.pgh.pa.us>
 <CACJufxFgKVL=NnPocAwhRFqpLHckN3N1Ndf7FjGNTdtsAA26mg@mail.gmail.com>
 <CA+renyW52FJ=+pnh+N_xqjUev_MNUCk_mgD2UC7UT0jyAHCE8Q@mail.gmail.com>
 <84f20d0d-3bc8-4843-bd7e-21bce20f8582@eisentraut.org>
In-Reply-To: <84f20d0d-3bc8-4843-bd7e-21bce20f8582@eisentraut.org>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Wed, 24 Jun 2026 14:12:59 +0300
Message-ID: 
 <CAJ7c6TO+kTwk5MBayLARxsPk-YCsDt2QH9P_PeTYoc3zPYCS3Q@mail.gmail.com>
Subject: Re: [PATCH] Fix null pointer dereference in PG19
To: PostgreSQL Development <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>,
	Paul A Jungwirth <pj@illuminatedcomputing.com>,
 jian he <jian.universality@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000fddb780654fdf5b5"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TO%2BkTwk5MBayLARxsPk-YCsDt2QH9P_PeTYoc3zPYCS3Q%40mail.gmail.com>
Precedence: bulk

--000000000000fddb780654fdf5b5
Content-Type: text/plain; charset="UTF-8"

Hi Peter,

Thanks for your attention to this.

> I don't understand the status of this discussion.  The original bug
> report is related to views and INSTEAD OF triggers.  But the last few
> patches that have been posted here appear to be unrelated to that
> specific issue.

That makes two of us. My humble understanding is that there are
several related discussions but they are happening elsewhere now. Feel
free correcting me if this is not the case.

Here I propose to focus on a particular crash and the particular
proposed bugfix, v1-0001. Perhaps it should be rewritten or maybe we
should reject it in favor of another patch. Both are possible
outcomes. Right now I'm only interested in fixing a particular crash.

> I definitely don't like checking volatility at parse time, though.

So.... the last comment from Tom was that he is not happy :) but I'm
not sure about the actionable items. Tom, could you please elaborate a
bit?

-- 
Best regards,
Aleksander Alekseev

--000000000000fddb780654fdf5b5
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Forbid-FOR-PORTION-OF-on-views-with-INSTEAD-OF-tr.patch"
Content-Disposition: attachment;
	filename="v1-0001-Forbid-FOR-PORTION-OF-on-views-with-INSTEAD-OF-tr.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mqrz3btf0>
X-Attachment-Id: f_mqrz3btf0

RnJvbSA2M2I2Njk5ZDVjMDM0MDVmMzYzOTZkZDk4YzU0ZjUzYTRiY2Y0MGQzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2Vy
ZGF0YS5jb20+CkRhdGU6IFR1ZSwgMjEgQXByIDIwMjYgMTU6NDY6MDQgKzAzMDAKU3ViamVjdDog
W1BBVENIIHYxXSBGb3JiaWQgRk9SIFBPUlRJT04gT0Ygb24gdmlld3Mgd2l0aCBJTlNURUFEIE9G
IHRyaWdnZXJzCgpQcml2aW91c2x5IGFuIGF0dGVtcHQgdG8gdXNlIHRoZXNlIGZlYXR1cmVzIHRv
Z2V0aGVyIGNhdXNlZCBhIGNyYXNoLgpPdmVyc2lnaHQgb2YgY29tbWl0IDhlNzJkOTE0YzUyOC4K
CkF1dGhvcjogQWxla3NhbmRlciBBbGVrc2VldiA8YWxla3NhbmRlckB0aWdlcmRhdGEuY29tPgpS
ZXZpZXdlZC1ieTogVE9ETyBGSVhNRQpEaXNjdXNzaW9uOiBUT0RPIEZJWE1FCi0tLQogc3JjL2Jh
Y2tlbmQvcGFyc2VyL2FuYWx5emUuYyAgICAgICAgICAgICAgICAgIHwgMTEgKysrKysrKysrCiBz
cmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3VwZGF0YWJsZV92aWV3cy5vdXQgfCAyNCArKysrKysr
KysrKysrKysrKysrCiBzcmMvdGVzdC9yZWdyZXNzL3NxbC91cGRhdGFibGVfdmlld3Muc3FsICAg
ICAgfCAyNCArKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlv
bnMoKykKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wYXJzZXIvYW5hbHl6ZS5jIGIvc3JjL2Jh
Y2tlbmQvcGFyc2VyL2FuYWx5emUuYwppbmRleCBjYjRlNTAxOWMyZi4uNGZjMGFlNzE5OWUgMTAw
NjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9hbmFseXplLmMKKysrIGIvc3JjL2JhY2tlbmQv
cGFyc2VyL2FuYWx5emUuYwpAQCAtMTMzMyw2ICsxMzMzLDE3IEBAIHRyYW5zZm9ybUZvclBvcnRp
b25PZkNsYXVzZShQYXJzZVN0YXRlICpwc3RhdGUsCiAJCQkJKGVycmNvZGUoRVJSQ09ERV9GRUFU
VVJFX05PVF9TVVBQT1JURUQpLAogCQkJCSBlcnJtc2coImZvcmVpZ24gdGFibGVzIGRvbid0IHN1
cHBvcnQgRk9SIFBPUlRJT04gT0YiKSkpOwogCisJLyogV2UgZG9uJ3Qgc3VwcG9ydCBGT1IgUE9S
VElPTiBPRiBvbiB2aWV3cyB3aXRoIElOU1RFQUQgT0YgdHJpZ2dlcnMuICovCisJaWYgKHRhcmdl
dHJlbC0+cmRfcmVsLT5yZWxraW5kID09IFJFTEtJTkRfVklFVyAmJgorCQl0YXJnZXRyZWwtPnJk
X3JlbC0+cmVsaGFzdHJpZ2dlcnMgJiYKKwkJdGFyZ2V0cmVsLT50cmlnZGVzYyAhPSBOVUxMICYm
CisJCShpc1VwZGF0ZSA/IHRhcmdldHJlbC0+dHJpZ2Rlc2MtPnRyaWdfdXBkYXRlX2luc3RlYWRf
cm93CisJCQkJICA6IHRhcmdldHJlbC0+dHJpZ2Rlc2MtPnRyaWdfZGVsZXRlX2luc3RlYWRfcm93
KSkKKwkJZXJlcG9ydChFUlJPUiwKKwkJCQkoZXJyY29kZShFUlJDT0RFX0ZFQVRVUkVfTk9UX1NV
UFBPUlRFRCksCisJCQkJIGVycm1zZygidmlld3Mgd2l0aCBJTlNURUFEIE9GIHRyaWdnZXJzIGRv
IG5vdCBzdXBwb3J0IEZPUiBQT1JUSU9OIE9GIiksCisJCQkJIHBhcnNlcl9lcnJwb3NpdGlvbihw
c3RhdGUsIGZvclBvcnRpb25PZi0+bG9jYXRpb24pKSk7CisKIAlyZXN1bHQgPSBtYWtlTm9kZShG
b3JQb3J0aW9uT2ZFeHByKTsKIAogCS8qIExvb2sgdXAgdGhlIEZPUiBQT1JUSU9OIE9GIG5hbWUg
cmVxdWVzdGVkLiAqLwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC91cGRh
dGFibGVfdmlld3Mub3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC91cGRhdGFibGVfdmll
d3Mub3V0CmluZGV4IDg4NTIxNjA3MThmLi40NzAxOTM4YmZlMiAxMDA2NDQKLS0tIGEvc3JjL3Rl
c3QvcmVncmVzcy9leHBlY3RlZC91cGRhdGFibGVfdmlld3Mub3V0CisrKyBiL3NyYy90ZXN0L3Jl
Z3Jlc3MvZXhwZWN0ZWQvdXBkYXRhYmxlX3ZpZXdzLm91dApAQCAtNDE1MSwzICs0MTUxLDI3IEBA
IHNlbGVjdCAqIGZyb20gYmFzZV90YWIgb3JkZXIgYnkgYTsKIAogZHJvcCB2aWV3IGJhc2VfdGFi
X3ZpZXc7CiBkcm9wIHRhYmxlIGJhc2VfdGFiOworLS0gRk9SIFBPUlRJT04gT0YgaXMgbm90IHN1
cHBvcnRlZCBvbiB2aWV3cyB3aXRoIElOU1RFQUQgT0YgdHJpZ2dlcnMKK2NyZWF0ZSB2aWV3IHV2
X2Zwb19pbnN0ZWFkX3ZpZXcgYXMgc2VsZWN0IGlkLCB2YWxpZF9hdCwgYiBmcm9tIHV2X2Zwb190
YWI7CitjcmVhdGUgZnVuY3Rpb24gdXZfZnBvX2luc3RlYWRfdHJpZygpIHJldHVybnMgdHJpZ2dl
ciBsYW5ndWFnZSBwbHBnc3FsIGFzCiskJCBiZWdpbiByZXR1cm4gbnVsbDsgZW5kICQkOworY3Jl
YXRlIHRyaWdnZXIgdXZfZnBvX2luc3RlYWRfdXBkX3RyaWcKKyAgaW5zdGVhZCBvZiB1cGRhdGUg
b24gdXZfZnBvX2luc3RlYWRfdmlldworICBmb3IgZWFjaCByb3cgZXhlY3V0ZSBmdW5jdGlvbiB1
dl9mcG9faW5zdGVhZF90cmlnKCk7CitjcmVhdGUgdHJpZ2dlciB1dl9mcG9faW5zdGVhZF9kZWxf
dHJpZworICBpbnN0ZWFkIG9mIGRlbGV0ZSBvbiB1dl9mcG9faW5zdGVhZF92aWV3CisgIGZvciBl
YWNoIHJvdyBleGVjdXRlIGZ1bmN0aW9uIHV2X2Zwb19pbnN0ZWFkX3RyaWcoKTsKK3VwZGF0ZSB1
dl9mcG9faW5zdGVhZF92aWV3CisgIGZvciBwb3J0aW9uIG9mIHZhbGlkX2F0IGZyb20gJzIwMTUt
MDEtMDEnIHRvICcyMDIwLTAxLTAxJworICBzZXQgYiA9IDk5IHdoZXJlIGlkID0gJ1sxLDFdJzsg
LS0gZXJyb3IKK0VSUk9SOiAgdmlld3Mgd2l0aCBJTlNURUFEIE9GIHRyaWdnZXJzIGRvIG5vdCBz
dXBwb3J0IEZPUiBQT1JUSU9OIE9GCitMSU5FIDI6ICAgZm9yIHBvcnRpb24gb2YgdmFsaWRfYXQg
ZnJvbSAnMjAxNS0wMS0wMScgdG8gJzIwMjAtMDEtMDEnCisgICAgICAgICAgICAgICAgICAgICAg
ICAgXgorZGVsZXRlIGZyb20gdXZfZnBvX2luc3RlYWRfdmlldworICBmb3IgcG9ydGlvbiBvZiB2
YWxpZF9hdCBmcm9tICcyMDE3LTAxLTAxJyB0byAnMjAyMi0wMS0wMScKKyAgd2hlcmUgaWQgPSAn
WzEsMV0nOyAtLSBlcnJvcgorRVJST1I6ICB2aWV3cyB3aXRoIElOU1RFQUQgT0YgdHJpZ2dlcnMg
ZG8gbm90IHN1cHBvcnQgRk9SIFBPUlRJT04gT0YKK0xJTkUgMjogICBmb3IgcG9ydGlvbiBvZiB2
YWxpZF9hdCBmcm9tICcyMDE3LTAxLTAxJyB0byAnMjAyMi0wMS0wMScKKyAgICAgICAgICAgICAg
ICAgICAgICAgICBeCitkcm9wIHZpZXcgdXZfZnBvX2luc3RlYWRfdmlldzsKK2Ryb3AgZnVuY3Rp
b24gdXZfZnBvX2luc3RlYWRfdHJpZygpOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9z
cWwvdXBkYXRhYmxlX3ZpZXdzLnNxbCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3VwZGF0YWJsZV92
aWV3cy5zcWwKaW5kZXggZjc2NDY5OTliZDQuLjMwYzJkYjdhZDdkIDEwMDY0NAotLS0gYS9zcmMv
dGVzdC9yZWdyZXNzL3NxbC91cGRhdGFibGVfdmlld3Muc3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jl
c3Mvc3FsL3VwZGF0YWJsZV92aWV3cy5zcWwKQEAgLTIxMzcsMyArMjEzNywyNyBAQCB2YWx1ZXMg
KDEsIDIsIGRlZmF1bHQsIDUsIDQsIGRlZmF1bHQsIDMpLCAoMTAsIDExLCAnQyB2YWx1ZScsIDE0
LCAxMywgMTAwLCAxMik7CiBzZWxlY3QgKiBmcm9tIGJhc2VfdGFiIG9yZGVyIGJ5IGE7CiBkcm9w
IHZpZXcgYmFzZV90YWJfdmlldzsKIGRyb3AgdGFibGUgYmFzZV90YWI7CisKKy0tIEZPUiBQT1JU
SU9OIE9GIGlzIG5vdCBzdXBwb3J0ZWQgb24gdmlld3Mgd2l0aCBJTlNURUFEIE9GIHRyaWdnZXJz
CitjcmVhdGUgdmlldyB1dl9mcG9faW5zdGVhZF92aWV3IGFzIHNlbGVjdCBpZCwgdmFsaWRfYXQs
IGIgZnJvbSB1dl9mcG9fdGFiOworCitjcmVhdGUgZnVuY3Rpb24gdXZfZnBvX2luc3RlYWRfdHJp
ZygpIHJldHVybnMgdHJpZ2dlciBsYW5ndWFnZSBwbHBnc3FsIGFzCiskJCBiZWdpbiByZXR1cm4g
bnVsbDsgZW5kICQkOworCitjcmVhdGUgdHJpZ2dlciB1dl9mcG9faW5zdGVhZF91cGRfdHJpZwor
ICBpbnN0ZWFkIG9mIHVwZGF0ZSBvbiB1dl9mcG9faW5zdGVhZF92aWV3CisgIGZvciBlYWNoIHJv
dyBleGVjdXRlIGZ1bmN0aW9uIHV2X2Zwb19pbnN0ZWFkX3RyaWcoKTsKK2NyZWF0ZSB0cmlnZ2Vy
IHV2X2Zwb19pbnN0ZWFkX2RlbF90cmlnCisgIGluc3RlYWQgb2YgZGVsZXRlIG9uIHV2X2Zwb19p
bnN0ZWFkX3ZpZXcKKyAgZm9yIGVhY2ggcm93IGV4ZWN1dGUgZnVuY3Rpb24gdXZfZnBvX2luc3Rl
YWRfdHJpZygpOworCit1cGRhdGUgdXZfZnBvX2luc3RlYWRfdmlldworICBmb3IgcG9ydGlvbiBv
ZiB2YWxpZF9hdCBmcm9tICcyMDE1LTAxLTAxJyB0byAnMjAyMC0wMS0wMScKKyAgc2V0IGIgPSA5
OSB3aGVyZSBpZCA9ICdbMSwxXSc7IC0tIGVycm9yCisKK2RlbGV0ZSBmcm9tIHV2X2Zwb19pbnN0
ZWFkX3ZpZXcKKyAgZm9yIHBvcnRpb24gb2YgdmFsaWRfYXQgZnJvbSAnMjAxNy0wMS0wMScgdG8g
JzIwMjItMDEtMDEnCisgIHdoZXJlIGlkID0gJ1sxLDFdJzsgLS0gZXJyb3IKKworZHJvcCB2aWV3
IHV2X2Zwb19pbnN0ZWFkX3ZpZXc7Citkcm9wIGZ1bmN0aW9uIHV2X2Zwb19pbnN0ZWFkX3RyaWco
KTsKLS0gCjIuNDMuMAoK
--000000000000fddb780654fdf5b5--