MIME-Version: 1.0
References: <agH4sA9EUqkT4TaJ@alvherre.pgsql>
 <2152953.1778517760@sss.pgh.pa.us>
In-Reply-To: <2152953.1778517760@sss.pgh.pa.us>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Tue, 12 May 2026 15:15:31 +0300
Message-ID: 
 <CAJ7c6TO0xvunpeOv89i1eKQBhKF9=GEETkTz+yAGs1xGYH25MQ@mail.gmail.com>
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline
 comments
To: pgsql-hackers@lists.postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Content-Type: multipart/mixed; boundary="0000000000007496a506519dd21a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TO0xvunpeOv89i1eKQBhKF9%3DGEETkTz%2ByAGs1xGYH25MQ%40mail.gmail.com>
Precedence: bulk

--0000000000007496a506519dd21a
Content-Type: text/plain; charset="UTF-8"

Hi,

>             /*-----
>              * limit (sum(1/i^2),i=1,inf) = pi^2/6
>              * resj = sum(wi/i^2),i=1,noccurrence,
>              * wi - should be sorted desc,
>              * don't sort for now, just choose maximum weight.
>              * This should be corrected
>              * Oleg Bartunov
>              */
>             res = res + (wjm + resj - wjm / ((jm + 1) * (jm + 1))) / 1.64493406685;
>
> > (Not that I understand what this is trying to tell me, mind)
>
> Me either :-(

I *think* maybe I was able to decipher it. PFA the patch.

-- 
Best regards,
Aleksander Alekseev

--0000000000007496a506519dd21a
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Decipher-the-comment-in-tsrank.c.patch"
Content-Disposition: attachment;
	filename="v1-0001-Decipher-the-comment-in-tsrank.c.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mp2lg6z40>
X-Attachment-Id: f_mp2lg6z40

RnJvbSAwZTgzNDU4NjNlYWJiOWFkYTYxZmJlM2M5YzAzZjM5MzY4MmEyNjE1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2Vy
ZGF0YS5jb20+CkRhdGU6IFR1ZSwgMTIgTWF5IDIwMjYgMTU6MDk6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHYxXSBEZWNpcGhlciB0aGUgY29tbWVudCBpbiB0c3JhbmsuYwoKLS0tCiBzcmMvYmFj
a2VuZC91dGlscy9hZHQvdHNyYW5rLmMgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKyst
LS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvdHNyYW5rLmMgYi9zcmMvYmFja2Vu
ZC91dGlscy9hZHQvdHNyYW5rLmMKaW5kZXggZDM1ZTU1MjhkMGEuLjM4M2FkMzkzOTcxIDEwMDY0
NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9hZHQvdHNyYW5rLmMKKysrIGIvc3JjL2JhY2tlbmQv
dXRpbHMvYWR0L3RzcmFuay5jCkBAIC0zMzYsMTMgKzMzNiwzMyBAQCBjYWxjX3Jhbmtfb3IoY29u
c3QgZmxvYXQgKncsIFRTVmVjdG9yIHQsIFRTUXVlcnkgcSkKIAkJCQkJam0gPSBqOwogCQkJCX0K
IAkJCX0KLS8qCi0JCQlsaW1pdCAoc3VtKDEvaV4yKSxpPTEsaW5mKSA9IHBpXjIvNgotCQkJcmVz
aiA9IHN1bSh3aS9pXjIpLGk9MSxub2NjdXJyZW5jZSwKLQkJCXdpIC0gc2hvdWxkIGJlIHNvcnRl
ZCBkZXNjLAotCQkJZG9uJ3Qgc29ydCBmb3Igbm93LCBqdXN0IGNob29zZSBtYXhpbXVtIHdlaWdo
dC4gVGhpcyBzaG91bGQgYmUgY29ycmVjdGVkCi0JCQlPbGVnIEJhcnR1bm92Ci0qLworCisJCQkv
KgorCQkJICogVGhlIGlkZWFsIHNjb3JlIGZvciBhIHRlcm0gaXMgdGhlIHdlaWdodGVkIGhhcm1v
bmljIHN1bToKKwkJCSAqCisJCQkgKiByZXNqID0gc3VtKHdpIC8gaV4yLCBpID0gMS4ubm9jY3Vy
cmVuY2VzKQorCQkJICoKKwkJCSAqIHdoZXJlIHdpIGlzIHRoZSB3ZWlnaHQgb2YgdGhlIGktdGgg
b2NjdXJyZW5jZSBhbmQgd2VpZ2h0cyBhcmUKKwkJCSAqIHNvcnRlZCBpbiBkZXNjZW5kaW5nIG9y
ZGVyIHNvIHRoYXQgdGhlIGhpZ2hlc3Qtd2VpZ2h0CisJCQkgKiBvY2N1cnJlbmNlIGdldHMgdGhl
IHNtYWxsZXN0IGRpdmlzb3IgKGk9MSkgYW5kIHRodXMgY29udHJpYnV0ZXMKKwkJCSAqIHRoZSBt
b3N0LgorCQkJICoKKwkJCSAqIFRoZSByZXN1bHQgaXMgZGl2aWRlZCBieSBwaV4yLzYgfj0gMS42
NDQ5MzQwNjY4NSwgd2hpY2ggaXMgdGhlCisJCQkgKiBsaW1pdCBvZiBzdW0oMS9pXjIsIGk9MS4u
aW5mKS4gVGhpcyBub3JtYWxpemVzIHRoZSBzY29yZSB0byB0aGUKKwkJCSAqIFswLCAxXSByYW5n
ZS4KKwkJCSAqCisJCQkgKiBBcyBhbiBhcHByb3hpbWF0aW9uIGZvciBlZmZpY2llbmN5LCB3ZSBz
a2lwIHRoZSBzb3J0IGFuZAorCQkJICogaW5zdGVhZCBvbmx5IHByb21vdGUgdGhlIHNpbmdsZSBo
aWdoZXN0LXdlaWdodCBvY2N1cnJlbmNlIHRvCisJCQkgKiBwb3NpdGlvbiBpPTEuIFRoaXMgaXMg
ZG9uZSBieSB0YWtpbmcgdGhlIHJhdyAodW5zb3J0ZWQpIHN1bQorCQkJICogcmVzaiwgc3VidHJh
Y3RpbmcgdGhlIG1heGltdW0gd2VpZ2h0J3MgYWN0dWFsIGNvbnRyaWJ1dGlvbgorCQkJICogd2pt
LyhqbSsxKV4yLCBhbmQgYWRkaW5nIGJhY2sgaXRzIGNvcnJlY3RlZCBjb250cmlidXRpb24KKwkJ
CSAqIHdqbS8xXjIgPSB3am06CisJCQkgKgorCQkJICogYWRqdXN0ZWQgPSByZXNqIC0gd2ptLyhq
bSsxKV4yICsgd2ptID0gd2ptICsgcmVzaiAtCisJCQkgKiB3am0vKGptKzEpXjIKKwkJCSAqCisJ
CQkgKiBUaGUgcmVtYWluaW5nIG9jY3VycmVuY2VzIGFyZSBsZWZ0IGluIHRoZWlyIG9yaWdpbmFs
IG9yZGVyLgorCQkJICovCiAJCQlyZXMgPSByZXMgKyAod2ptICsgcmVzaiAtIHdqbSAvICgoam0g
KyAxKSAqIChqbSArIDEpKSkgLyAxLjY0NDkzNDA2Njg1OwogCiAJCQllbnRyeSsrOwotLSAKMi40
My4wCgo=
--0000000000007496a506519dd21a--