MIME-Version: 1.0
References: 
 <CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw@mail.gmail.com>
 <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
 <CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
 <aFVomQjfkDvtQRwo@momjian.us>
In-Reply-To: <aFVomQjfkDvtQRwo@momjian.us>
From: Aleksander Alekseev <aleksander@timescale.com>
Date: Fri, 20 Jun 2025 17:01:41 +0300
Message-ID: 
 <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>,
 Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
	Michael Paquier <michael@paquier.xyz>
Content-Type: multipart/mixed; boundary="000000000000eedfc50638014daa"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4%3DPZr%3DyEQ%40mail.gmail.com>
Precedence: bulk

--000000000000eedfc50638014daa
Content-Type: text/plain; charset="UTF-8"

Hi,

> Given the quality of BSD indent code, I have _always_ found it easier to
> modify pgindent.  ;-

:D Initially I thought that the problem was simple enough to solve it
in C, but this turned out not to be true.

> It's going to be simpler to modify pgindent then. PFA the updated patch.

I noticed a mistake in v2. Here is the corrected patch. Changes
comparing to the previous version:

```
-    $lines[-1] =~ s!/(.+)\*/!/$1\n \*/!;
+    $lines[-1] =~ s!(.+) \*/!$1\n \*/!;
```

-- 
Best regards,
Aleksander Alekseev

--000000000000eedfc50638014daa
Content-Type: application/octet-stream;
	name="v3-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Disposition: attachment;
	filename="v3-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mc4vnuo40>
X-Attachment-Id: f_mc4vnuo40

RnJvbSA5N2JmZDY0NWE5MzEzYjg4OTJkNjRmYzlhY2MwNjNkOWU5ODJlOWQ3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpbWVz
Y2FsZS5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTY6MzE6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHYzXSBwZ2luZGVudDogaW1wcm92ZSBmb3JtYXR0aW5nIG9mIG11bHRpbGluZSBjb21t
ZW50cwoKRm9ybWF0IG11bHRpbGluZSBjb21tZW50cyBsaWtlIHRoaXM6CgovKiBsaW5lIDEKICog
bGluZSAyCiAqLwoKLi4uIGludG86CgovKgogKiBsaW5lIDEKICogbGluZSAyCiAqLwoKVGhpcyBp
cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGluIHRoZSB0cmVl
LgoKQXV0aG9yOiBBbGVrc2FuZGVyIEFsZWtzZWV2ClJlcG9ydGVkLWJ5OiBNaWNoYWVsIFBhcXVp
ZXIKUmV2aWV3ZWQtYnk6IEFyc2VuaXkgTXVraGluCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdy
LmVzL20vQ0FKN2M2VFBRMGtrSFFHLUFxZUFKM1BWX1l0bUR6Y2M3cyUyQl9WNCUzRHQlMkJ4Z1Nu
Wm0xY0Z3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQg
fCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg
MzQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVu
dCBiL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAppbmRleCBiN2Q3MTgwODkyNC4uMTM5NDQ3
MzBhMzkgMTAwNzU1Ci0tLSBhL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAorKysgYi9zcmMv
dG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQKQEAgLTI4MSw2ICsyODEsOSBAQCBzdWIgcG9zdF9pbmRl
bnQKIAkjIEZpeCBydW4tdG9nZXRoZXIgY29tbWVudHMgdG8gaGF2ZSBhIHRhYiBiZXR3ZWVuIHRo
ZW0KIAkkc291cmNlID1+IHMhXCovKC9cKi4qXCovKSQhKi9cdCQxIWdtOwogCisJIyBQb3N0cHJv
Y2VzcyBtdWx0aWxpbmUgY29tbWVudHMKKwkkc291cmNlID1+IHMhXigvXCouKj9cKi8pIXBvc3Rw
cm9jZXNzX211bHRpbGluZV9jb21tZW50KCQxKSFtZ3NlOworCiAJIyMgRnVuY3Rpb25zCiAKIAkj
IFVzZSBhIHNpbmdsZSBzcGFjZSBiZWZvcmUgJyonIGluIGZ1bmN0aW9uIHJldHVybiB0eXBlcwpA
QCAtMjg5LDYgKzI5MiwzNyBAQCBzdWIgcG9zdF9pbmRlbnQKIAlyZXR1cm4gJHNvdXJjZTsKIH0K
IAorc3ViIHBvc3Rwcm9jZXNzX211bHRpbGluZV9jb21tZW50Cit7CisgICAgbXkgJHNvdXJjZSA9
IHNoaWZ0OworICAgIG15IEBsaW5lcyA9IHNwbGl0ICJcbiIsICRzb3VyY2U7CisKKyAgICBpZigk
bGluZXNbMF0gbmUgIi8qIiAmJiAkbGluZXNbLTFdIG5lICIgKi8iKQorICAgIHsKKyAgICAgICAg
IyBEb24ndCBjaGFuZ2UgY29tbWVudHMgbGlrZToKKyAgICAgICAgIyAvKiBsaW5lIDEKKyAgICAg
ICAgIyAgICBsaW5lIDIgKi8KKyAgICAgICAgIyBhbmQgc2ltaWxhci4KKyAgICAgICAgcmV0dXJu
ICRzb3VyY2U7CisgICAgfQorCisgICAgaWYoJGxpbmVzWzBdID1+IG0hL1wqKFwtfFwqKSEpCisg
ICAgeworICAgICAgICAjIERvbid0IGNoYW5nZSBjb21tZW50cyB0aGF0IHN0YXJ0IHdpdGg6Cisg
ICAgICAgICMgLyoqKioKKyAgICAgICAgIyBvcjoKKyAgICAgICAgIyAvKi0tLQorICAgICAgICBy
ZXR1cm4gJHNvdXJjZTsKKyAgICB9CisKKyAgICAkbGluZXNbMF0gPX4gcyEvXCooLispIS9cKlxu
ICokMSE7CisgICAgJGxpbmVzWy0xXSA9fiBzISguKykgXCovISQxXG4gXCovITsKKworICAgICRz
b3VyY2UgPSBqb2luICJcbiIsIEBsaW5lczsKKworICAgIHJldHVybiAkc291cmNlOworfQorCiBz
dWIgcnVuX2luZGVudAogewogCW15ICRzb3VyY2UgPSBzaGlmdDsKLS0gCjIuNDkuMAoK
--000000000000eedfc50638014daa--