MIME-Version: 1.0
References: 
 <CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw@mail.gmail.com>
 <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
 <CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
 <aFVomQjfkDvtQRwo@momjian.us>
 <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
In-Reply-To: 
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
From: Aleksander Alekseev <aleksander@timescale.com>
Date: Mon, 23 Jun 2025 13:42:32 +0300
Message-ID: 
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
 Bruce Momjian <bruce@momjian.us>,
	Michael Paquier <michael@paquier.xyz>
Content-Type: multipart/mixed; boundary="0000000000002ead4b06383adf39"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TOGdVBK5P-s59c77qxaw%3DydPjpzp_s3VbpHeHn3Gc1iyA%40mail.gmail.com>
Precedence: bulk

--0000000000002ead4b06383adf39
Content-Type: text/plain; charset="UTF-8"

Hi Arseniy,

Thanks for the feedback!

> Now it affects 4 times more files (380). What I noticed:
> 1) Most of the comments are bordered comments like this:
> -/* --------------------------------------------------------------------------------
> +/*
> + * --------------------------------------------------------------------------------
>   * Public IO related functions operating on IO Handles
>   * --------------------------------------------------------------------------------
>   */
>
> Do we want to skip such comments?
> I have also seen comments with '====' border.

Personally I don't have a strong opinion on this. We can easily add an
exception for "/* ---" and "/* ===" comments if somebody believes this
is a problem. I choose not to add such an exception just yet only
because I don't like unnecessary exceptions :)

> 2) Some comments like this:
>
> before:
> /* Author: Linus Tolke
>    (actually most if the code is "borrowed" from the distribution and just
>    slightly modified)
>  */
>
> after:
> /*
>  * Author: Linus Tolke
>    (actually most if the code is "borrowed" from the distribution and just
>    slightly modified)
>  */
>
> I guess closing */ on the separate line is the trigger?
> If I'm not wrong there are only 3 such comments, maybe it is easier to
> fix them by hand?)
>
> 3) It seems all geqo related file contains such comment:
> -/* contributed by:
> +/*
> + * contributed by:
>     =*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=*=
>     *  Martin Utesch                             * Institute of
> Automatic Control          *

You are right, these comments shouldn't have been changed. Apparently
the script is going to need slightly more complicated checks that I
initially thought.

Here is the corrected patch v4.

-- 
Best regards,
Aleksander Alekseev

--0000000000002ead4b06383adf39
Content-Type: application/octet-stream;
	name="v4-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Disposition: attachment;
	filename="v4-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mc8yuqc40>
X-Attachment-Id: f_mc8yuqc40

RnJvbSAxMjVjMjM5ZDcwNGZkNzU1MDM5YjJkZTI3ZTg0N2ZjZDRkZWUyNDA2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpbWVz
Y2FsZS5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTY6MzE6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHY0XSBwZ2luZGVudDogaW1wcm92ZSBmb3JtYXR0aW5nIG9mIG11bHRpbGluZSBjb21t
ZW50cwoKRm9ybWF0IG11bHRpbGluZSBjb21tZW50cyBsaWtlIHRoaXM6CgovKiBsaW5lIDEKICog
bGluZSAyCiAqLwoKLi4uIGludG86CgovKgogKiBsaW5lIDEKICogbGluZSAyCiAqLwoKVGhpcyBp
cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGluIHRoZSB0cmVl
LgoKQXV0aG9yOiBBbGVrc2FuZGVyIEFsZWtzZWV2ClJlcG9ydGVkLWJ5OiBNaWNoYWVsIFBhcXVp
ZXIKUmV2aWV3ZWQtYnk6IEFyc2VuaXkgTXVraGluCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdy
LmVzL20vQ0FKN2M2VFBRMGtrSFFHLUFxZUFKM1BWX1l0bUR6Y2M3cyUyQl9WNCUzRHQlMkJ4Z1Nu
Wm0xY0Z3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQg
fCAyOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI5IGlu
c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQgYi9z
cmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQKaW5kZXggYjdkNzE4MDg5MjQuLmYwMDlkNGJhOTg0
IDEwMDc1NQotLS0gYS9zcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQKKysrIGIvc3JjL3Rvb2xz
L3BnaW5kZW50L3BnaW5kZW50CkBAIC0yODEsNiArMjgxLDkgQEAgc3ViIHBvc3RfaW5kZW50CiAJ
IyBGaXggcnVuLXRvZ2V0aGVyIGNvbW1lbnRzIHRvIGhhdmUgYSB0YWIgYmV0d2VlbiB0aGVtCiAJ
JHNvdXJjZSA9fiBzIVwqLygvXCouKlwqLykkISovXHQkMSFnbTsKIAorCSMgUG9zdHByb2Nlc3Mg
bXVsdGlsaW5lIGNvbW1lbnRzIGV4Y2VwdCBmb3IgLyoqLi4uIGFuZCAvKi0uLi4gb25lcworCSRz
b3VyY2UgPX4gcyFeKC9cKlteXCpcLV0uKj9cKi8pIXBvc3Rwcm9jZXNzX211bHRpbGluZV9jb21t
ZW50KCQxKSFtZ3NlOworCiAJIyMgRnVuY3Rpb25zCiAKIAkjIFVzZSBhIHNpbmdsZSBzcGFjZSBi
ZWZvcmUgJyonIGluIGZ1bmN0aW9uIHJldHVybiB0eXBlcwpAQCAtMjg5LDYgKzI5MiwzMiBAQCBz
dWIgcG9zdF9pbmRlbnQKIAlyZXR1cm4gJHNvdXJjZTsKIH0KIAorc3ViIHBvc3Rwcm9jZXNzX211
bHRpbGluZV9jb21tZW50Cit7CisgICAgbXkgJHNvdXJjZSA9IHNoaWZ0OworICAgIG15IEBsaW5l
cyA9IHNwbGl0ICJcbiIsICRzb3VyY2U7CisKKyAgICAjIE9ubHkgZm9ybWF0IGNvbW1lbnRzIHRo
YXQgbWF0Y2ggdGhlIGV4cGVjdGVkIGZvcm1hdCwKKyAgICAjIG9yIGF0IGxlYXN0IHRoYXQgY291
bGQgaGF2ZSBiZWVuIHRoZSBhdXRob3IncyBpbnRlbnQuCisgICAgaWYgKCgkbGluZXNbMF0gbmUg
Ii8qIiAmJiAkbGluZXNbLTFdIG5lICIgKi8iKSBvciAoJGxpbmVzWzFdICF+IG0hXiBcKiEpKQor
ICAgIHsKKyAgICAgICAgcmV0dXJuICRzb3VyY2U7CisgICAgfQorCisgICAgIyBDaGVjayBlYWNo
IGxpbmUgZXhjZXB0IGZvciB0aGUgZmlzdCBhbmQgdGhlIGxhc3Qgb25lCisgICAgZm9yIG15ICRp
ICggMSAuLiBzY2FsYXIgQGxpbmVzIC0gMiApCisgICAgeworICAgICAgICAkbGluZXNbJGldID0g
IiAqIi4kbGluZXNbJGldIGlmICRsaW5lc1skaV0gIX4gL14gXCovOworICAgIH0KKworICAgICRs
aW5lc1swXSA9fiBzIS9cKiguKykhL1wqXG4gKiQxITsKKyAgICAkbGluZXNbLTFdID1+IHMhKC4r
KSBcKi8hJDFcbiBcKi8hOworCisgICAgJHNvdXJjZSA9IGpvaW4gIlxuIiwgQGxpbmVzOworCisg
ICAgcmV0dXJuICRzb3VyY2U7Cit9CisKIHN1YiBydW5faW5kZW50CiB7CiAJbXkgJHNvdXJjZSA9
IHNoaWZ0OwotLSAKMi40OS4wCgo=
--0000000000002ead4b06383adf39--