Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6UkG-005Tqx-AH for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Oct 2025 14:02:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v6UkE-00AdY7-3r for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Oct 2025 14:02:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6UkD-00AdXx-Pi for pgsql-hackers@lists.postgresql.org; Wed, 08 Oct 2025 14:02:18 +0000 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1v6UkC-0012xO-2K for pgsql-hackers@lists.postgresql.org; Wed, 08 Oct 2025 14:02:18 +0000 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-64b8278babfso2037578eaf.1 for ; Wed, 08 Oct 2025 07:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tigerdata.com; s=google; t=1759932134; x=1760536934; darn=lists.postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=K2Zf1PfQC2Gf710Gq0VH9qFH2cxb72ogek0WA8ALqpo=; b=IkGCRf/FuDb8NL2o3VHspuaP29v59E2zm+S6TD9lcV/LAibBRofanAK9yPppa13poV m/uSYJRWsPcgS8cfEFm6JWi8R+eV3HDsb1ldjcOhhcdONXD5FLkHTVZTaWjTysoL5566 nLZCovYgXQ7W+KXfMPy7BaNVm9wMOtKbJiCpTYxLuk80JEkCH84m6FwEl4LFdA6E+R6a Ni7fkCy5iXnk0Zw6ccbfIsipmRDw79sqskVbKgVQJ63zqrgc+LMGEgaUs6i+ydSmGAa/ Oo6f/tDuE4HcHkNy0rU+rK2038G+0PVtgWZlcOwDgIsQR2lPdZb9GB4w0dD7O+hMTQBl Y0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759932134; x=1760536934; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K2Zf1PfQC2Gf710Gq0VH9qFH2cxb72ogek0WA8ALqpo=; b=K+Z8pwC69dDkE2zf1QUc+CNvRsyinWDAu9aoexoYehVdEkNBJG/Eyd11vCN5PsyOVi qa3BtmGP+xAGYF4cPFYxASmwBZW2/f4Vsx0Pk/Pq/eIjIgefniUxhcjJUOun8a5cjZ0C WlEeZSzStwiUcQzf3Mwur74qNoUZNu3bLADUAzrH8LxynAI2r2LPw6Mns2ONb4pvS56f CSBZnvAZ03Mhqqdy61gqIs8/MWM6SnNJYSEoMPt2jyS+iSPsYsqKb+praIl/9YhR3N1z RJmR1Y/T6CrmGhveO1xyXoUQRHP72keuY/woyUr+9LzRSEdo1eh1i24QChEBMhlY36qb YNxA== X-Gm-Message-State: AOJu0YyMGCq61c3qfTP9sdJh1VSu7axk/3KOj4l++1zPrGsgi6eXobEQ xK+mWnF2Cxr/s004dZ8WainRZg92+QDGTm+DSikHdXtH6k+Bdt1yWPGrduPnc/3VEX0BkC3Db7Y rjCb1gzkX8SiJKxSCcSip3enlv4dFuuPdNxu4l3eUpKl6jmin7pCYOht4Lg9/ X-Gm-Gg: ASbGncs02h/ra8cRygVkpCSX2RXtv+dLjWtPOavHCpyEbruytT8ilUk674xYRTspkv4 P9mjS8H6zdSEHzgyBFsUdZcco+e4TwGe27XDJ8NaxMg6hywhk/5r9pDbOTVFiez0KmStRtgu9iG 5w0CPbqdj0mVqtRMJsXoR0OZboTy2kz1jn4qjM0MQtMILiWffv5BvSU5V4ecM6lbckdiM2i+0Vw I344EyHTwiIDqHZBKyAWBtI8Cqb2yW/9s4lDpTh+Oo= X-Google-Smtp-Source: AGHT+IHFpJZvprkr8dwCOCm0DEEiGskbRXwmpQdB0ehmGT7FCsv70FSH+7D3Le84rFyAycbMe/lZQSbLrryiOigp4Tc= X-Received: by 2002:a05:6820:2d09:b0:632:341e:e5f1 with SMTP id 006d021491bc7-64fffdaf88bmr1905198eaf.3.1759932132688; Wed, 08 Oct 2025 07:02:12 -0700 (PDT) MIME-Version: 1.0 From: Aleksander Alekseev Date: Wed, 8 Oct 2025 17:02:00 +0300 X-Gm-Features: AS18NWD6u_YkgC1HB23qBGkBD8_Ke91QsWUaAWMx3UZj__rVhsMPyb_ER8Ov_cI Message-ID: Subject: [PATCH] Little refactoring of portalcmds.c To: PostgreSQL Hackers Content-Type: multipart/mixed; boundary="0000000000009932870640a6213e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009932870640a6213e Content-Type: text/plain; charset="UTF-8" Hi, The proposed patch places some repetitive code in a helper function. The value of this change is arguably not that high but it makes the code a bit neater IMO. -- Best regards, Aleksander Alekseev --0000000000009932870640a6213e Content-Type: text/x-patch; charset="US-ASCII"; name="v1-0001-Refactor-portalcmds.c.patch" Content-Disposition: attachment; filename="v1-0001-Refactor-portalcmds.c.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mgi251cv0 RnJvbSBhZjA1MTQwNmQwOWRlZGY4N2JkZTg4MDJkN2Y3ZGVhMGFiNDQ1OGVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2Vy ZGF0YS5jb20+CkRhdGU6IFdlZCwgOCBPY3QgMjAyNSAxNjo1NDoxNyArMDMwMApTdWJqZWN0OiBb UEFUQ0ggdjFdIFJlZmFjdG9yIHBvcnRhbGNtZHMuYwoKUGxhY2Ugc29tZSByZXBldGl0aXZlIGNv ZGUgaW4gYSBoZWxwZXIgZnVuY3Rpb24uCgpBdXRob3I6IEFsZWtzYW5kZXIgQWxla3NlZXYgPGFs ZWtzYW5kZXJAdGlnZXJkYXRhLmNvbT4KUmV2aWV3ZWQtYnk6IFRPRE8gRklYTUUKRGlzY3Vzc2lv bjogVE9ETyBGSVhNRQotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL3BvcnRhbGNtZHMuYyB8IDQw ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNl cnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21t YW5kcy9wb3J0YWxjbWRzLmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9wb3J0YWxjbWRzLmMKaW5k ZXggZWM5NmMyZWZjZDMuLmQ3NGEwMWMwMWEzIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21t YW5kcy9wb3J0YWxjbWRzLmMKKysrIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvcG9ydGFsY21kcy5j CkBAIC0zNiw2ICszNiwxOSBAQAogI2luY2x1ZGUgInV0aWxzL21lbXV0aWxzLmgiCiAjaW5jbHVk ZSAidXRpbHMvc25hcG1nci5oIgogCisvKgorICogQ2hlY2sgdGhhdCBjdXJzb3IgbmFtZSBpcyBu b3QgZW1wdHksIHdoaWNoIHdvdWxkIGNvbmZsaWN0IHdpdGggcHJvdG9jb2wtbGV2ZWwKKyAqIHVu bmFtZWQgcG9ydGFsLgorICovCitzdGF0aWMgdm9pZAorY2hlY2tfY3Vyc29yX25hbWUoY29uc3Qg Y2hhciAqbmFtZSkKK3sKKwlpZiAoIW5hbWUgfHwgbmFtZVswXSA9PSAnXDAnKQorCQllcmVwb3J0 KEVSUk9SLAorCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9DVVJTT1JfTkFNRSksCisJCQkJ IGVycm1zZygiaW52YWxpZCBjdXJzb3IgbmFtZTogbXVzdCBub3QgYmUgZW1wdHkiKSkpOworfQor CiAKIC8qCiAgKiBQZXJmb3JtQ3Vyc29yT3BlbgpAQCAtNTMsMTQgKzY2LDcgQEAgUGVyZm9ybUN1 cnNvck9wZW4oUGFyc2VTdGF0ZSAqcHN0YXRlLCBEZWNsYXJlQ3Vyc29yU3RtdCAqY3N0bXQsIFBh cmFtTGlzdEluZm8gcGEKIAlNZW1vcnlDb250ZXh0IG9sZENvbnRleHQ7CiAJY2hhcgkgICAqcXVl cnlTdHJpbmc7CiAKLQkvKgotCSAqIERpc2FsbG93IGVtcHR5LXN0cmluZyBjdXJzb3IgbmFtZSAo Y29uZmxpY3RzIHdpdGggcHJvdG9jb2wtbGV2ZWwKLQkgKiB1bm5hbWVkIHBvcnRhbCkuCi0JICov Ci0JaWYgKCFjc3RtdC0+cG9ydGFsbmFtZSB8fCBjc3RtdC0+cG9ydGFsbmFtZVswXSA9PSAnXDAn KQotCQllcmVwb3J0KEVSUk9SLAotCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9DVVJTT1Jf TkFNRSksCi0JCQkJIGVycm1zZygiaW52YWxpZCBjdXJzb3IgbmFtZTogbXVzdCBub3QgYmUgZW1w dHkiKSkpOworCWNoZWNrX2N1cnNvcl9uYW1lKGNzdG10LT5wb3J0YWxuYW1lKTsKIAogCS8qCiAJ ICogSWYgdGhpcyBpcyBhIG5vbi1ob2xkYWJsZSBjdXJzb3IsIHdlIHJlcXVpcmUgdGhhdCB0aGlz IHN0YXRlbWVudCBoYXMKQEAgLTE4MiwxNCArMTg4LDcgQEAgUGVyZm9ybVBvcnRhbEZldGNoKEZl dGNoU3RtdCAqc3RtdCwKIAlQb3J0YWwJCXBvcnRhbDsKIAl1aW50NjQJCW5wcm9jZXNzZWQ7CiAK LQkvKgotCSAqIERpc2FsbG93IGVtcHR5LXN0cmluZyBjdXJzb3IgbmFtZSAoY29uZmxpY3RzIHdp dGggcHJvdG9jb2wtbGV2ZWwKLQkgKiB1bm5hbWVkIHBvcnRhbCkuCi0JICovCi0JaWYgKCFzdG10 LT5wb3J0YWxuYW1lIHx8IHN0bXQtPnBvcnRhbG5hbWVbMF0gPT0gJ1wwJykKLQkJZXJlcG9ydChF UlJPUiwKLQkJCQkoZXJyY29kZShFUlJDT0RFX0lOVkFMSURfQ1VSU09SX05BTUUpLAotCQkJCSBl cnJtc2coImludmFsaWQgY3Vyc29yIG5hbWU6IG11c3Qgbm90IGJlIGVtcHR5IikpKTsKKwljaGVj a19jdXJzb3JfbmFtZShzdG10LT5wb3J0YWxuYW1lKTsKIAogCS8qIGdldCB0aGUgcG9ydGFsIGZy b20gdGhlIHBvcnRhbCBuYW1lICovCiAJcG9ydGFsID0gR2V0UG9ydGFsQnlOYW1lKHN0bXQtPnBv cnRhbG5hbWUpOwpAQCAtMjMzLDE0ICsyMzIsNyBAQCBQZXJmb3JtUG9ydGFsQ2xvc2UoY29uc3Qg Y2hhciAqbmFtZSkKIAkJcmV0dXJuOwogCX0KIAotCS8qCi0JICogRGlzYWxsb3cgZW1wdHktc3Ry aW5nIGN1cnNvciBuYW1lIChjb25mbGljdHMgd2l0aCBwcm90b2NvbC1sZXZlbAotCSAqIHVubmFt ZWQgcG9ydGFsKS4KLQkgKi8KLQlpZiAobmFtZVswXSA9PSAnXDAnKQotCQllcmVwb3J0KEVSUk9S LAotCQkJCShlcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9DVVJTT1JfTkFNRSksCi0JCQkJIGVycm1z ZygiaW52YWxpZCBjdXJzb3IgbmFtZTogbXVzdCBub3QgYmUgZW1wdHkiKSkpOworCWNoZWNrX2N1 cnNvcl9uYW1lKG5hbWUpOwogCiAJLyoKIAkgKiBnZXQgdGhlIHBvcnRhbCBmcm9tIHRoZSBwb3J0 YWwgbmFtZQotLSAKMi40My4wCgo= --0000000000009932870640a6213e--