MIME-Version: 1.0
References: 
 <CAJ7c6TPQ0kkHQG-AqeAJ3PV_YtmDzcc7s+_V4=t+xgSnZm1cFw@mail.gmail.com>
 <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
In-Reply-To: 
 <CAE7r3MJ=CcWw65=C=tET32z5joixFqMDY_XhCxvjpLcOL3nVAQ@mail.gmail.com>
From: Aleksander Alekseev <aleksander@timescale.com>
Date: Fri, 20 Jun 2025 16:44:08 +0300
Message-ID: 
 <CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D+zFWBwae-80do6o-rA@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
 Michael Paquier <michael@paquier.xyz>
Content-Type: multipart/mixed; boundary="000000000000224b8e0638010f20"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TOp_h5Ueu8tPTnmponG84oFrm3D%2BzFWBwae-80do6o-rA%40mail.gmail.com>
Precedence: bulk

--000000000000224b8e0638010f20
Content-Type: text/plain; charset="UTF-8"

Hi Arseniy,

> I tried it with the whole project and almost always it works great.
> But I noticed two cases where it works probably not as expected:
>
> 1) comments which don't have a star on each line. For example:
> file 'cube.c'
>
> before:
> /* make up a metric in which one box will be 'lower' than the other
>    -- this can be useful for sorting and to determine uniqueness */
>
> after:
> /*
>  * make up a metric in which one box will be 'lower' than the other
>    -- this can be useful for sorting and to determine uniqueness */
>
> 2) comments where closing */ is on the last comment line. For example:
> file 'crypt-blowfish.c'
>
> before:
> /* This has to be bug-compatible with the original implementation, so
>  * only encode 23 of the 24 bytes. :-) */
>
> after:
> /*
>  * This has to be bug-compatible with the original implementation, so
>  * only encode 23 of the 24 bytes. :-) */

Thanks for the review. You are right, these comments shouldn't be affected.

It's going to be simpler to modify pgindent then. PFA the updated patch.

-- 
Best regards,
Aleksander Alekseev

--000000000000224b8e0638010f20
Content-Type: application/octet-stream;
	name="v2-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Disposition: attachment;
	filename="v2-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mc4uzl8l0>
X-Attachment-Id: f_mc4uzl8l0

RnJvbSA2NmQ1ODU0MDlhOTNjYTVmYmE5MDM1Y2M5ZTkzOTQyNGQ5MjA2YWQ5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpbWVz
Y2FsZS5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTY6MzE6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHYyXSBwZ2luZGVudDogaW1wcm92ZSBmb3JtYXR0aW5nIG9mIG11bHRpbGluZSBjb21t
ZW50cwoKRm9ybWF0IG11bHRpbGluZSBjb21tZW50cyBsaWtlIHRoaXM6CgovKiBsaW5lIDEKICog
bGluZSAyCiAqLwoKLi4uIGludG86CgovKgogKiBsaW5lIDEKICogbGluZSAyCiAqLwoKVGhpcyBp
cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGluIHRoZSB0cmVl
LgoKQXV0aG9yOiBBbGVrc2FuZGVyIEFsZWtzZWV2ClJlcG9ydGVkLWJ5OiBNaWNoYWVsIFBhcXVp
ZXIKUmV2aWV3ZWQtYnk6IEFyc2VuaXkgTXVraGluCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdy
LmVzL20vQ0FKN2M2VFBRMGtrSFFHLUFxZUFKM1BWX1l0bUR6Y2M3cyUyQl9WNCUzRHQlMkJ4Z1Nu
Wm0xY0Z3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQg
fCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg
MzQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVu
dCBiL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAppbmRleCBiN2Q3MTgwODkyNC4uNDljYjkx
N2NjNWQgMTAwNzU1Ci0tLSBhL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudAorKysgYi9zcmMv
dG9vbHMvcGdpbmRlbnQvcGdpbmRlbnQKQEAgLTI4MSw2ICsyODEsOSBAQCBzdWIgcG9zdF9pbmRl
bnQKIAkjIEZpeCBydW4tdG9nZXRoZXIgY29tbWVudHMgdG8gaGF2ZSBhIHRhYiBiZXR3ZWVuIHRo
ZW0KIAkkc291cmNlID1+IHMhXCovKC9cKi4qXCovKSQhKi9cdCQxIWdtOwogCisJIyBQb3N0cHJv
Y2VzcyBtdWx0aWxpbmUgY29tbWVudHMKKwkkc291cmNlID1+IHMhXigvXCouKj9cKi8pIXBvc3Rw
cm9jZXNzX211bHRpbGluZV9jb21tZW50KCQxKSFtZ3NlOworCiAJIyMgRnVuY3Rpb25zCiAKIAkj
IFVzZSBhIHNpbmdsZSBzcGFjZSBiZWZvcmUgJyonIGluIGZ1bmN0aW9uIHJldHVybiB0eXBlcwpA
QCAtMjg5LDYgKzI5MiwzNyBAQCBzdWIgcG9zdF9pbmRlbnQKIAlyZXR1cm4gJHNvdXJjZTsKIH0K
IAorc3ViIHBvc3Rwcm9jZXNzX211bHRpbGluZV9jb21tZW50Cit7CisgICAgbXkgJHNvdXJjZSA9
IHNoaWZ0OworICAgIG15IEBsaW5lcyA9IHNwbGl0ICJcbiIsICRzb3VyY2U7CisKKyAgICBpZigk
bGluZXNbMF0gbmUgIi8qIiAmJiAkbGluZXNbLTFdIG5lICIgKi8iKQorICAgIHsKKyAgICAgICAg
IyBEb24ndCBjaGFuZ2UgY29tbWVudHMgbGlrZToKKyAgICAgICAgIyAvKiBsaW5lIDEKKyAgICAg
ICAgIyAgICBsaW5lIDIgKi8KKyAgICAgICAgIyBhbmQgc2ltaWxhci4KKyAgICAgICAgcmV0dXJu
ICRzb3VyY2U7CisgICAgfQorCisgICAgaWYoJGxpbmVzWzBdID1+IG0hL1wqKFwtfFwqKSEpCisg
ICAgeworICAgICAgICAjIERvbid0IGNoYW5nZSBjb21tZW50cyB0aGF0IHN0YXJ0IHdpdGg6Cisg
ICAgICAgICMgLyoqKioKKyAgICAgICAgIyBvcjoKKyAgICAgICAgIyAvKi0tLQorICAgICAgICBy
ZXR1cm4gJHNvdXJjZTsKKyAgICB9CisKKyAgICAkbGluZXNbMF0gPX4gcyEvXCooLispIS9cKlxu
ICokMSE7CisgICAgJGxpbmVzWy0xXSA9fiBzIS8oLispXCovIS8kMVxuIFwqLyE7CisKKyAgICAk
c291cmNlID0gam9pbiAiXG4iLCBAbGluZXM7CisKKyAgICByZXR1cm4gJHNvdXJjZTsKK30KKwog
c3ViIHJ1bl9pbmRlbnQKIHsKIAlteSAkc291cmNlID0gc2hpZnQ7Ci0tIAoyLjQ5LjAKCg==
--000000000000224b8e0638010f20--