Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rh7Wg-009hvz-Gt for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Mar 2024 12:34:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rh7Wf-007VFB-3f for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Mar 2024 12:34:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rh7We-007VF3-Pd for pgsql-hackers@lists.postgresql.org; Mon, 04 Mar 2024 12:34:37 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rh7Wc-002iYK-O2 for pgsql-hackers@postgresql.org; Mon, 04 Mar 2024 12:34:36 +0000 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so3904342a12.1 for ; Mon, 04 Mar 2024 04:34:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timescale.com; s=google; t=1709555672; x=1710160472; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5GQYF/Q1XBJf+LycdWCf/Rdxj3Y/N9rY47aI3t5BHF8=; b=VI2oEA86KgJ+Ztg9nJ+ioENEHXPJXJWPUyTMhUYNiQnCD8ufnTxIHbR45qU6zIkGAD U+DJVMRsHQ6fXLgfWvgQHCq6yn1Zc6gIVFexNdk+gVyvCIlslajpl5wU+Qils+Fpm8zY Ei/c2VAPGSlm0WeJPf8pgDJKOq0UQ47Z+M87zyMfBo097dMDGnniSyIwUxhKKOQt2iG8 Gng+gVHX8l2Ktt+w2JN3USiKuRgYs/C2iqPFcnH9m2eNO7yaLo0UoHudaJMFLh6aM7iC T5euvBITvvWj+HyrVZmPOH+4xuyS0tncDXNcrGGDX8LwSnmTgsHAm3icRzXbk016mvHV duxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709555672; x=1710160472; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5GQYF/Q1XBJf+LycdWCf/Rdxj3Y/N9rY47aI3t5BHF8=; b=O7wJwXb2eNugHQVOUOnAPcE5qECNADnaAWlipmBQfw9OQ2KMto5cO284w75YiYnJDa 7LOBUGmuYTBqKYwL05h521jehYQ4kr5KEK6HU2e6YcZqminVPAIhj1f79HOROXTYRdLR pDdxySm5TqF0Vcnjed4veqUTsWHuH33edOeDt/qz9qcPc+gCLZHOnFkJ9PAdt2hWmOLk iopfUVRaMuDD+/Vb9xGQ7SLlbCF1Pfz0iiiUGhjZatp5nyNdHH/oSk5GbnVhFp84uhc8 j5rWBUmFm+YOAFo5Z7lRydQhm6C01EuDee8+rs0Dnx1P9YSGQEZnRJNCgEQb5uFQ7U3G ZZ5Q== X-Gm-Message-State: AOJu0YwLPngsn1MQ5wqwMjVddAaXH5v/YUsbliCmmJSQE++t76izCEZp /P9ChCMkib7XVXkTCMi362ddzG0rvW6X0+MH+XDL4qQMJW0Sg/PKAVzNEep/uULjFJCiETai1NV edIHldb5hqm32oSKKrehO6jlkGgLnfcpJERXmK8Q/gcu+l3lCAMQ= X-Google-Smtp-Source: AGHT+IF5GaP8HzTvLZLi2KpaFp52MNk0Esta8wasUm70lXLCQjZMycxUtaLKhHB0tmgOssTtVv1k6PdJ7Zlh1AHGWRQ= X-Received: by 2002:a17:90a:948a:b0:29a:d01a:a32 with SMTP id s10-20020a17090a948a00b0029ad01a0a32mr7507792pjo.26.1709555672286; Mon, 04 Mar 2024 04:34:32 -0800 (PST) MIME-Version: 1.0 References: <202309201459.jhuhi2pns3re@alvherre.pgsql> In-Reply-To: From: Aleksander Alekseev Date: Mon, 4 Mar 2024 15:34:20 +0300 Message-ID: Subject: Re: Dump-restore loosing 'attnotnull' bit for DEFERRABLE PRIMARY KEY column(s). To: PostgreSQL-development Cc: Amul Sul , vignesh C , Alvaro Herrera Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi hackers, >> I did not see any test addition for this, can we add it? > > > Ok, added it in the attached version. > > This was an experimental patch, I was looking for the comment on the proposed > approach -- whether we could simply skip the throwaway NOT NULL constraint for > deferred PK constraint. Moreover, skip that for any PK constraint. I confirm that the patch fixes the bug. All the tests pass. Looks like RfC to me. -- Best regards, Aleksander Alekseev