MIME-Version: 1.0
References: <aFVomQjfkDvtQRwo@momjian.us> <CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com>
 <CAE7r3M+phC+kyJsUrJ6z97-UA0LXRrUBJ61hBk7WhRqdXF_itQ@mail.gmail.com>
 <CAJ7c6TOGdVBK5P-s59c77qxaw=ydPjpzp_s3VbpHeHn3Gc1iyA@mail.gmail.com>
 <aPqPK4ERy5-jj185@nathan> <CAJ7c6TMTzQsnKfM+_4i-4WO7=YnV4nO8ABWA6enSpdtg6DKhqQ@mail.gmail.com>
 <aP-H6kSsGOxaB21k@nathan> <aQABs_2dbXmGXDvv@paquier.xyz> <7415F7DF-FA45-49E1-AC70-04868714DC8A@gmail.com>
 <aTs7A4lbcm0ThXaO@nathan> <aYZqyoNlah_E-Zua@nathan>
In-Reply-To: <aYZqyoNlah_E-Zua@nathan>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Mon, 9 Feb 2026 14:19:16 +0300
Message-ID: <CAJ7c6TPJVau3Ppih7+KubRwvG9CRpXq16L3X9bE02KuGgL95Nw@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000f2d376064a624f67"
Archived-At: <https://www.postgresql.org/message-id/CAJ7c6TPJVau3Ppih7%2BKubRwvG9CRpXq16L3X9bE02KuGgL95Nw%40mail.gmail.com>
Precedence: bulk

--000000000000f2d376064a624f67
Content-Type: text/plain; charset="UTF-8"

Hi,

> > Here's a patch for this.  I also changed the #undefs to #defines.
>
> I went ahead and committed this.

Thanks, Nathan. Re-submitting v6 to make it visible by cfbot again and
in order to simplify the work of reviewers a bit.

-- 
Best regards,
Aleksander Alekseev

--000000000000f2d376064a624f67
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="v6-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Disposition: attachment; 
	filename="v6-0001-pgindent-improve-formatting-of-multiline-comments.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mlf2xhrv0>
X-Attachment-Id: f_mlf2xhrv0

RnJvbSBhZDkxZmRhOGE3NDA2ZjlmZDVkYmJmZTVhODk1YTgxMTIzMGUyZWVjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpbWVz
Y2FsZS5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTY6MzE6MzYgKzAzMDAKU3ViamVjdDog
W1BBVENIIHY2XSBwZ2luZGVudDogaW1wcm92ZSBmb3JtYXR0aW5nIG9mIG11bHRpbGluZSBjb21t
ZW50cwoKRm9ybWF0IG11bHRpbGluZSBjb21tZW50cyBsaWtlIHRoaXM6CgovKiBsaW5lIDEKICog
bGluZSAyCiAqLwoKLi4uIGludG86CgovKgogKiBsaW5lIDEKICogbGluZSAyCiAqLwoKVGhpcyBp
cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCB3aGF0IHdlIGN1cnJlbnRseSBoYXZlIGluIHRoZSB0cmVl
LgoKQXV0aG9yOiBBbGVrc2FuZGVyIEFsZWtzZWV2IDxhbGVrc2FuZGVyQHRpZ2VyZGF0YS5jb20+
ClJlcG9ydGVkLWJ5OiBNaWNoYWVsIFBhcXVpZXIgPG1pY2hhZWxAcGFxdWllci54eXo+ClJldmll
d2VkLWJ5OiBBcnNlbml5IE11a2hpbiA8YXJzZW5peS5tdWtoaW4uZGV2QGdtYWlsLmNvbT4KUmV2
aWV3ZWQtYnk6IE5hdGhhbiBCb3NzYXJ0IDxuYXRoYW5kYm9zc2FydEBnbWFpbC5jb20+CkRpc2N1
c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vQ0FKN2M2VFBRMGtrSFFHLUFxZUFKM1BWX1l0bUR6
Y2M3cyUyQl9WNCUzRHQlMkJ4Z1NuWm0xY0Z3JTQwbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvdG9v
bHMvcGdpbmRlbnQvcGdpbmRlbnQgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3Jj
L3Rvb2xzL3BnaW5kZW50L3BnaW5kZW50IGIvc3JjL3Rvb2xzL3BnaW5kZW50L3BnaW5kZW50Cmlu
ZGV4IGI3ZDcxODA4OTI0Li40ZGIxMmNiMWQ5MiAxMDA3NTUKLS0tIGEvc3JjL3Rvb2xzL3BnaW5k
ZW50L3BnaW5kZW50CisrKyBiL3NyYy90b29scy9wZ2luZGVudC9wZ2luZGVudApAQCAtMjgxLDYg
KzI4MSw5IEBAIHN1YiBwb3N0X2luZGVudAogCSMgRml4IHJ1bi10b2dldGhlciBjb21tZW50cyB0
byBoYXZlIGEgdGFiIGJldHdlZW4gdGhlbQogCSRzb3VyY2UgPX4gcyFcKi8oL1wqLipcKi8pJCEq
L1x0JDEhZ207CiAKKwkjIFBvc3Rwcm9jZXNzIG11bHRpbGluZSBjb21tZW50cyBleGNlcHQgZm9y
IC8qKi4uLiBhbmQgLyotLi4uIG9uZXMKKwkkc291cmNlID1+IHMhXigvXCpbXlwqXC1dLio/XCov
KSFwb3N0cHJvY2Vzc19tdWx0aWxpbmVfY29tbWVudCgkMSkhbWdzZTsKKwogCSMjIEZ1bmN0aW9u
cwogCiAJIyBVc2UgYSBzaW5nbGUgc3BhY2UgYmVmb3JlICcqJyBpbiBmdW5jdGlvbiByZXR1cm4g
dHlwZXMKQEAgLTI4OSw2ICsyOTIsMzkgQEAgc3ViIHBvc3RfaW5kZW50CiAJcmV0dXJuICRzb3Vy
Y2U7CiB9CiAKK3N1YiBwb3N0cHJvY2Vzc19tdWx0aWxpbmVfY29tbWVudAoreworICAgIG15ICRz
b3VyY2UgPSBzaGlmdDsKKyAgICBteSBAbGluZXMgPSBzcGxpdCAiXG4iLCAkc291cmNlOworCisg
ICAgIyBPbmx5IGZvcm1hdCBjb21tZW50cyB0aGF0IG1hdGNoIHRoZSBleHBlY3RlZCBmb3JtYXQs
CisgICAgIyBvciBhdCBsZWFzdCB0aGF0IGNvdWxkIGhhdmUgYmVlbiB0aGUgYXV0aG9yJ3MgaW50
ZW50LgorICAgIGlmICgoJGxpbmVzWzBdIG5lICIvKiIgJiYgJGxpbmVzWy0xXSBuZSAiICovIikg
b3IgKCRsaW5lc1sxXSAhfiBtIV4gXCohKSkKKyAgICB7CisgICAgICAgIHJldHVybiAkc291cmNl
OworICAgIH0KKworICAgICMgQ2hlY2sgZWFjaCBsaW5lIGV4Y2VwdCBmb3IgdGhlIGZpcnN0IGFu
ZCB0aGUgbGFzdCBvbmUKKyAgICBmb3IgbXkgJGkgKCAxIC4uIHNjYWxhciBAbGluZXMgLSAyICkK
KyAgICB7CisgICAgICAgICRsaW5lc1skaV0gPSAiICoiLiRsaW5lc1skaV0gaWYgJGxpbmVzWyRp
XSAhfiAvXiBcKi87CisgICAgfQorCisgICAgIyBLZWVwIC8qID09PSBhbmQgLyogLS0tIGxpbmVz
IGFzIGlzCisgICAgaWYgKCRsaW5lc1swXSAhfiBtIV4vXCogWz0tXSshKSB7CisgICAgICAgICRs
aW5lc1swXSA9fiBzIS9cKiguKykhL1wqXG4gKiQxITsKKyAgICB9CisKKyAgICAjIEtlZXAgPT09
ICovIGFuZCAtLS0gKi8gbGluZXMgYXMgaXMKKyAgICBpZiAoJGxpbmVzWy0xXSAhfiBtIVs9LV0r
IFwqLyQhKSB7CisgICAgICAgICRsaW5lc1stMV0gPX4gcyEoLispIFwqLyEkMVxuIFwqLyE7Cisg
ICAgfQorCisgICAgJHNvdXJjZSA9IGpvaW4gIlxuIiwgQGxpbmVzOworCisgICAgcmV0dXJuICRz
b3VyY2U7Cit9CisKIHN1YiBydW5faW5kZW50CiB7CiAJbXkgJHNvdXJjZSA9IHNoaWZ0OwotLSAK
Mi40My4wCgo=
--000000000000f2d376064a624f67--