MIME-Version: 1.0
References: <CAJ7c6TOy7fUW9MuNeOWor3cSFnQg9tgz=mjXHDb94GORtM_Eyg@mail.gmail.com>
 <ZuIt9-loAPa8tvcY@paquier.xyz> <CAJ7c6TNs8RY4Yvng4m375mAvsS4wHeUcqR8t4b2_i2j=PE6iNQ@mail.gmail.com>
 <Zy2RtPwzjdtgjLnE@paquier.xyz> <CAJ7c6TMq46VGLtMVCev2z0QUfUYO1Fnfug0ouLuEZby2sa0+FQ@mail.gmail.com>
In-Reply-To: <CAJ7c6TMq46VGLtMVCev2z0QUfUYO1Fnfug0ouLuEZby2sa0+FQ@mail.gmail.com>
From: Aleksander Alekseev <aleksander@timescale.com>
Date: Tue, 12 Nov 2024 17:37:02 +0300
Message-ID: <CAJ7c6TPrdgo8YD0-YPbdiRXQDHUCJ66OdhKgn+SJeQcmrB3s_g@mail.gmail.com>
Subject: Re: [PATCH] Refactor SLRU to always use long file names
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAJ7c6TPrdgo8YD0-YPbdiRXQDHUCJ66OdhKgn%2BSJeQcmrB3s_g%40mail.gmail.com>
Precedence: bulk

Hi again,

Just a quick follow-up.

> (*) BTW I noticed a mistake in the commented code. The condition
> should be `>=`, not `<`, i.e:
>
> ```
>     if(new_cluster.controldata.cat_ver >= SLRU_SEG_FILENAMES_CHANGE_CAT_VER)
>         return;
> ```

The concentration of caffeine in my blood is a bit low right now. I
suspect I may need to re-check this statement with a fresh head.

Also it occured to me that as a 4th option we could just get rid of
this check. Users however will pay the price every time they execute
pg_upgrade so I doubt we are going to do this.

-- 
Best regards,
Aleksander Alekseev