MIME-Version: 1.0
References: <CALdSSPhFyb9qLSHee73XtZm1CBWJNo9+JzFNf-zUEWCRW5yEiQ@mail.gmail.com>
 <2869012.1767023578@sss.pgh.pa.us> <CALdSSPg6UgK+6LJmFQ6G3av4J6dbngN7=QwQEuFZApnpmXgVWQ@mail.gmail.com>
 <CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe=gTpM0+GfOFh2iDmmw@mail.gmail.com> <CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ@mail.gmail.com>
In-Reply-To: <CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ@mail.gmail.com>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Tue, 6 Jan 2026 17:21:55 +0300
Message-ID: <CAJ7c6TPsaLW7O67vqv8YyV_qUUjF0pncDB7dCQJFDw0so7wrdw@mail.gmail.com>
Subject: Re: Define DatumGetInt8 function.
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Kirill Reshke <reshkekirill@gmail.com>, David Rowley <dgrowleyml@gmail.com>, 
	Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAJ7c6TPsaLW7O67vqv8YyV_qUUjF0pncDB7dCQJFDw0so7wrdw%40mail.gmail.com>
Precedence: bulk

Hi,

> > Kirill, are you working on this patch?
>
> Yes, PFA.
>
>  > I've not studied in detail,
> > but looks like it would require making
> > char_decrement()/char_increment() and btcharskipsupport() all use
> > CharGetDatum()/DatumGetChar() and switch to using SCHAR_MIN/SCHAR_MAX
> > rather than 0/UCHAR_MAX.
>
> This is also a possible change, and can be a separate patch. I will
> try to also work on this this week.

v1 looks incomplete to me. As I understand, Tom proposed to get rid of
UInt8 conversions as well. Are you going to implement this idea as
well?

-- 
Best regards,
Aleksander Alekseev