MIME-Version: 1.0
References: <202512121547.dwkzxcs56227@alvherre.pgsql>
 <1000974.1765556221@sss.pgh.pa.us>
 <aTxBcklpZcHAUAi1@nathan> <1029569.1765564643@sss.pgh.pa.us>
In-Reply-To: <1029569.1765564643@sss.pgh.pa.us>
From: Aleksander Alekseev <aleksander@tigerdata.com>
Date: Sat, 13 Dec 2025 00:47:30 +0300
Message-ID: 
 <CAJ7c6TPztZV=07UwQ+GAgj4i+aUfpu0W8CF0K28VKZM+G4nfjA@mail.gmail.com>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Chao Li <li.evan.chao@gmail.com>,
 Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
	Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael@paquier.xyz>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ7c6TPztZV%3D07UwQ%2BGAgj4i%2BaUfpu0W8CF0K28VKZM%2BG4nfjA%40mail.gmail.com>
Precedence: bulk

Hi,

> It's strange to see this thread go on about messing with the Perl script
> because we're too afraid of pg_bsd_indent.  Maybe we should take
> ownership of that code -- improve its own indentation to our
> conventions, add comments, rename unclear variables, and so on until we
> have something we can work with, and fix these weird bugs and
> idiosincratic behaviors we don't like.  I just found out this code dates
> back from 1976.

> With or without that nice-to-have, it'd be a lot of work with
> not all that much payoff, so I'm finding it hard to recommend
> that somebody go after this.  But maybe someone will find it
> irresistible to scratch that itch.

I was thinking just recently that rewriting pgindent in Python might
be a good idea for future refactoring, but probably only if and after
we merge PyTest patchset [1]. (Which strangely enough is missing on
the nearest open commitfest.)

[1]: https://www.postgresql.org/message-id/flat/CAOYmi%2BkThkM9Z87u%3DR_Wi7fCor2i%2BUZKAyq0UCyprzCwTQvqgA%40mail.gmail.com
--
Best regards,
Aleksander Alekseev