public inbox for [email protected]  

help / color / mirror / Atom feed
From: Daniil Davydov <[email protected]>
To: Alexander Lakhin <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: David Rowley <[email protected]>
Cc: PostgreSQL Developers <[email protected]>
Subject: Re: Typos in the code and README
Date: Mon, 20 Apr 2026 13:11:48 +0700
Message-ID: <CAJDiXggv2M724eyHkUQqPiC3jjNmB0uOTh0utSbzFqAdiA_U0g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAN55FZ1YsO7e7Wr_49gi=2ne+Ov_YPY6q0EE-OxCJ1kWSJfEwg@mail.gmail.com>
	<[email protected]>
	<CAApHDvq-2Zdqytm_Hf3RmVf0qg5PS9jTFAJ5QTc9xH9pwvwDTA@mail.gmail.com>
	<CAApHDvr3zgeb+2cQTsbyRcV2ZkjeMiHyDXYSWB5z71WwSyxwDA@mail.gmail.com>
	<[email protected]>
	<CAApHDvq7chgw8=7TU4-hLpQNw8e7qN9_oA4ew2UH05RCcihEDQ@mail.gmail.com>
	<[email protected]>
	<CAApHDvoYsiFkZpjWeLGejibAXi=T3B70MzFr7z-1EiJ4pVX2hA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi,

On Mon, Apr 20, 2026 at 2:00 AM Alexander Lakhin <[email protected]> wrote:
>
> Please look at another set of typos and inconsistencies introduced since
> 2026-01-01

I've found a few other typos. Although they are quite old, I think they should
be mentioned here :

1) Typo in tidstore.c
"Find the shared the shared radix tree" --> "Find the shared radix tree".

2) A bit inconsistent comment in twophase.c
```
/*
 * Recreates a state file. This is used in WAL replay and during
 * checkpoint creation.
 *
 * Note: content and len don't include CRC.
 */
static void
RecreateTwoPhaseFile(FullTransactionId fxid, void *content, int len)
```

This comment was introduced in the implementation of the two-phase commit [1].
At that time, this function was actually used during replaying the
XLOG_XACT_PREPARE record. Commit [2] changed that code, so now this function is
used only during checkpoint and restartpoint creation.

If restartpoint creation can be considered as part of the WAL replay, we can
leave this comment as is. Otherwise, I suggest changing it to something like
this :
/*
 * Recreates a state file. This is used during checkpoint/restartpoint creation.
 *
 * Note: content and len don't include CRC.
 */

Another idea - we can stop listing the places of function's usage so that we
don't need to touch this comment later.

[1] d0a89683a3a4dd8e76ef0a99101355999e519df5
[2] 728bd991c3c4389fb39c45dcb0fe57e4a1dccd71

--
Best regards,
Daniil Davydov





view thread (17+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Typos in the code and README
  In-Reply-To: <CAJDiXggv2M724eyHkUQqPiC3jjNmB0uOTh0utSbzFqAdiA_U0g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox