MIME-Version: 1.0
From: Daniil Davydov <3danissimo@gmail.com>
Date: Sun, 29 Mar 2026 19:26:11 +0700
Message-ID: 
 <CAJDiXgi=Vcp1nh2UoZ5=7BCoR+uXoYzqMsfOfga-XxSUHjFj5Q@mail.gmail.com>
Subject: Get rid of redundant StringInfo accumulation
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000093a023064e28d799"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJDiXgi%3DVcp1nh2UoZ5%3D7BCoR%2BuXoYzqMsfOfga-XxSUHjFj5Q%40mail.gmail.com>
Precedence: bulk

--00000000000093a023064e28d799
Content-Type: text/plain; charset="UTF-8"

Hi,

I have noticed that there are several places in the code where we are
creating StringInfo in order to log its content. But this work may be wasted
if the specified log level is not interesting both for client and server.
I.e. now we can allocate memory for StringInfo which will never be displayed.

I think that at first we should check whether log level is interesting and
only then start creating the StringInfo.

Please, see the attached patch that fixes it. I hope I have found all the
places where it would be appropriate.

--
Best regards,
Daniil Davydov

--00000000000093a023064e28d799
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Get-rid-of-redundant-calculations.patch"
Content-Disposition: attachment;
	filename="v1-0001-Get-rid-of-redundant-calculations.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnbqevyj0>
X-Attachment-Id: f_mnbqevyj0

RnJvbSBjZDFhODViZmQ3MWRjODc1YTlmN2ExNjZjMGZiMmYwNjA0YTVhMWNlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5paWwgRGF2aWRvdiA8ZC5kYXZ5ZG92QHBvc3RncmVzcHJv
LnJ1PgpEYXRlOiBTdW4sIDI5IE1hciAyMDI2IDE5OjE3OjExICswNzAwClN1YmplY3Q6IFtQQVRD
SCB2MV0gR2V0IHJpZCBvZiByZWR1bmRhbnQgY2FsY3VsYXRpb25zCgotLS0KIHNyYy9iYWNrZW5k
L3JlcGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxpY3QuYyB8IDMgKysrCiBzcmMvYmFja2VuZC9zdG9y
YWdlL2lwYy9wcm9jYXJyYXkuYyAgICAgICAgfCAzICsrKwogc3JjL2JhY2tlbmQvc3RvcmFnZS9p
cGMvc3RhbmRieS5jICAgICAgICAgIHwgMyArKysKIHNyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9s
b2NrLmMgICAgICAgICAgICB8IDIgKy0KIHNyYy9iYWNrZW5kL3V0aWxzL2luaXQvcG9zdGluaXQu
YyAgICAgICAgICB8IDMgKystCiA1IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIg
ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNh
bC9jb25mbGljdC5jIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9jb25mbGljdC5j
CmluZGV4IGNhNzFhODFjN2JmLi4yMDI5ODllYWRhMyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQv
cmVwbGljYXRpb24vbG9naWNhbC9jb25mbGljdC5jCisrKyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0
aW9uL2xvZ2ljYWwvY29uZmxpY3QuYwpAQCAtMTA4LDYgKzEwOCw5IEBAIFJlcG9ydEFwcGx5Q29u
ZmxpY3QoRVN0YXRlICplc3RhdGUsIFJlc3VsdFJlbEluZm8gKnJlbGluZm8sIGludCBlbGV2ZWws
CiAJUmVsYXRpb24JbG9jYWxyZWwgPSByZWxpbmZvLT5yaV9SZWxhdGlvbkRlc2M7CiAJU3RyaW5n
SW5mb0RhdGEgZXJyX2RldGFpbDsKIAorCWlmICghbWVzc2FnZV9sZXZlbF9pc19pbnRlcmVzdGlu
ZyhlbGV2ZWwpKQorCQlyZXR1cm47CisKIAlpbml0U3RyaW5nSW5mbygmZXJyX2RldGFpbCk7CiAK
IAkvKiBGb3JtIGVycmRldGFpbCBtZXNzYWdlIGJ5IGNvbWJpbmluZyBjb25mbGljdGluZyB0dXBs
ZXMgaW5mb3JtYXRpb24uICovCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9w
cm9jYXJyYXkuYyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3Byb2NhcnJheS5jCmluZGV4IGNj
MjA3Y2I1NmUzLi43ZTliZmFjNjM0ZiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9p
cGMvcHJvY2FycmF5LmMKKysrIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvcHJvY2FycmF5LmMK
QEAgLTUyNjcsNiArNTI2Nyw5IEBAIEtub3duQXNzaWduZWRYaWRzRGlzcGxheShpbnQgdHJhY2Vf
bGV2ZWwpCiAJdGFpbCA9IHBBcnJheS0+dGFpbEtub3duQXNzaWduZWRYaWRzOwogCWhlYWQgPSBw
QXJyYXktPmhlYWRLbm93bkFzc2lnbmVkWGlkczsKIAorCWlmICghbWVzc2FnZV9sZXZlbF9pc19p
bnRlcmVzdGluZyh0cmFjZV9sZXZlbCkpCisJCXJldHVybjsKKwogCWluaXRTdHJpbmdJbmZvKCZi
dWYpOwogCiAJZm9yIChpID0gdGFpbDsgaSA8IGhlYWQ7IGkrKykKZGlmZiAtLWdpdCBhL3NyYy9i
YWNrZW5kL3N0b3JhZ2UvaXBjL3N0YW5kYnkuYyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3N0
YW5kYnkuYwppbmRleCBkZTkwOTJmZGY1Yi4uMmYyYzBkZjdiNzQgMTAwNjQ0Ci0tLSBhL3NyYy9i
YWNrZW5kL3N0b3JhZ2UvaXBjL3N0YW5kYnkuYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2lw
Yy9zdGFuZGJ5LmMKQEAgLTI4Miw2ICsyODIsOSBAQCBMb2dSZWNvdmVyeUNvbmZsaWN0KFJlY292
ZXJ5Q29uZmxpY3RSZWFzb24gcmVhc29uLCBUaW1lc3RhbXBUeiB3YWl0X3N0YXJ0LAogCVN0cmlu
Z0luZm9EYXRhIGJ1ZjsKIAlpbnQJCQlucHJvY3MgPSAwOwogCisJaWYgKCFtZXNzYWdlX2xldmVs
X2lzX2ludGVyZXN0aW5nKExPRykpCisJCXJldHVybjsKKwogCS8qCiAJICogVGhlcmUgbXVzdCBi
ZSBubyBjb25mbGljdGluZyBwcm9jZXNzZXMgd2hlbiB0aGUgcmVjb3ZlcnkgY29uZmxpY3QgaGFz
CiAJICogYWxyZWFkeSBiZWVuIHJlc29sdmVkLgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3Rv
cmFnZS9sbWdyL2xvY2suYyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9sb2NrLmMKaW5kZXgg
MjM0NjQzZTRkZDcuLjY5ZGQyMWYxNzhiIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9zdG9yYWdl
L2xtZ3IvbG9jay5jCisrKyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9sb2NrLmMKQEAgLTEx
NzIsNyArMTE3Miw3IEBAIExvY2tBY3F1aXJlRXh0ZW5kZWQoY29uc3QgTE9DS1RBRyAqbG9ja3Rh
ZywKIAkJCSAqIGxvZ0xvY2tGYWlsdXJlID0gdHJ1ZSBhbmQgbG9jayBhY3F1aXNpdGlvbiBmYWls
cyB3aXRoIGRvbnRXYWl0CiAJCQkgKiA9IHRydWUKIAkJCSAqLwotCQkJaWYgKGxvZ0xvY2tGYWls
dXJlKQorCQkJaWYgKGxvZ0xvY2tGYWlsdXJlICYmIG1lc3NhZ2VfbGV2ZWxfaXNfaW50ZXJlc3Rp
bmcoTE9HKSkKIAkJCXsKIAkJCQlTdHJpbmdJbmZvRGF0YSBidWYsCiAJCQkJCQkJbG9ja193YWl0
ZXJzX3NidWYsCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMg
Yi9zcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMKaW5kZXggMjYxMTg2NjFmMDcuLjdk
MzI1YjIxMzI0IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMK
KysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvaW5pdC9wb3N0aW5pdC5jCkBAIC0yNjksNyArMjY5LDgg
QEAgUGVyZm9ybUF1dGhlbnRpY2F0aW9uKFBvcnQgKnBvcnQpCiAJLyogQ2FwdHVyZSBhdXRoZW50
aWNhdGlvbiBlbmQgdGltZSBmb3IgbG9nZ2luZyAqLwogCWNvbm5fdGltaW5nLmF1dGhfZW5kID0g
R2V0Q3VycmVudFRpbWVzdGFtcCgpOwogCi0JaWYgKGxvZ19jb25uZWN0aW9ucyAmIExPR19DT05O
RUNUSU9OX0FVVEhPUklaQVRJT04pCisJaWYgKGxvZ19jb25uZWN0aW9ucyAmIExPR19DT05ORUNU
SU9OX0FVVEhPUklaQVRJT04gJiYKKwkJbWVzc2FnZV9sZXZlbF9pc19pbnRlcmVzdGluZyhMT0cp
KQogCXsKIAkJU3RyaW5nSW5mb0RhdGEgbG9nbXNnOwogCi0tIAoyLjQzLjAKCg==
--00000000000093a023064e28d799--