MIME-Version: 1.0
References: 
 <CAJDiXgi=Vcp1nh2UoZ5=7BCoR+uXoYzqMsfOfga-XxSUHjFj5Q@mail.gmail.com>
 <eok6kgntbec2vo35xp4eky5ef52ttb7trislyev63ty3ltu533@je4bpifl6spb>
In-Reply-To: <eok6kgntbec2vo35xp4eky5ef52ttb7trislyev63ty3ltu533@je4bpifl6spb>
From: Daniil Davydov <3danissimo@gmail.com>
Date: Mon, 30 Mar 2026 21:24:01 +0700
Message-ID: 
 <CAJDiXgjPGu_cW9nsvciqdgAkqY5o5ugaxDvo3S-rOcqBPcHCPw@mail.gmail.com>
Subject: Re: Get rid of redundant StringInfo accumulation
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000ce96af064e3e9a80"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJDiXgjPGu_cW9nsvciqdgAkqY5o5ugaxDvo3S-rOcqBPcHCPw%40mail.gmail.com>
Precedence: bulk

--000000000000ce96af064e3e9a80
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Mar 30, 2026 at 7:52=E2=80=AFPM Andres Freund <andres@anarazel.de> =
wrote:
>
> I don't see when the overhead of creating an populating the string info e=
ver
> matters in these cases. This is optimizing something that never can matte=
r for
> real world performance.  Even if it were worth optimizing them, I doubt t=
hat
> the log level check is useful here, because most if not all of these are
> logged with a level that's logged in nearly all installations.
>

Thank you for the review!

I have a few arguments to defend this patch :
1)
It is normal practice in the code base to check log level before allocating
memory for StringInfo or some other structure. For example, I found the log
level check even before a very lightweight piece of code (see xlogutils.c)
and even if we are going to emit log with DEBUG3 level (see postmaster.c).
2)
Originally, I created this patch in order to avoid spending time during
acquiring LWLock before entering the GetLockHoldersAndWaiters function. The
log_lock_waits parameter is "true" by default, so even if log level is high=
,
we will *waste* time on the lock acquiring. I.e. this patch is not only abo=
ut
getting rid of redundant memory allocation - it is also about reducing wait=
ing
time on the locks. I think that it may be noticeable in conditions of a hug=
e
number of parallel processes.
3)
I don't think that all other places (except lock.c and proc.c) where I have
added log level check are really matter for real world performance. This is
more about consistent approach : if we check log level in lock.c, then we
should check it everywhere (if it makes sense). Again, it is normal practic=
e
for the postgres' code.

Am I missing something?

BTW, during writing it I noticed that I forgot to add log level check for
pretty important code path (proc.c). Please, see it in the v3 patch.

--
Best regards,
Daniil Davydov

--000000000000ce96af064e3e9a80
Content-Type: text/x-patch; charset="US-ASCII";
	name="v3-0001-Get-rid-of-redundant-calculations.patch"
Content-Disposition: attachment;
	filename="v3-0001-Get-rid-of-redundant-calculations.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnda3b7k0>
X-Attachment-Id: f_mnda3b7k0

RnJvbSA1ZGNmZDViMDk2MGZjZTFmMDQyMmE0ZjczZjhiNjcyYjY5NTk2NDEzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5paWwgRGF2aWRvdiA8ZC5kYXZ5ZG92QHBvc3RncmVzcHJv
LnJ1PgpEYXRlOiBNb24sIDMwIE1hciAyMDI2IDEzOjI0OjAzICswNzAwClN1YmplY3Q6IFtQQVRD
SCB2M10gR2V0IHJpZCBvZiByZWR1bmRhbnQgY2FsY3VsYXRpb25zCgotLS0KIHNyYy9iYWNrZW5k
L3JlcGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxpY3QuYyB8IDcgKysrKystLQogc3JjL2JhY2tlbmQv
c3RvcmFnZS9pcGMvcHJvY2FycmF5LmMgICAgICAgIHwgMyArKysKIHNyYy9iYWNrZW5kL3N0b3Jh
Z2UvaXBjL3N0YW5kYnkuYyAgICAgICAgICB8IDMgKysrCiBzcmMvYmFja2VuZC9zdG9yYWdlL2xt
Z3IvbG9jay5jICAgICAgICAgICAgfCAyICstCiBzcmMvYmFja2VuZC9zdG9yYWdlL2xtZ3IvcHJv
Yy5jICAgICAgICAgICAgfCAyICstCiBzcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMg
ICAgICAgICAgfCAzICsrLQogNiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA1IGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwv
Y29uZmxpY3QuYyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxpY3QuYwpp
bmRleCBjYTcxYTgxYzdiZi4uN2I2NzZjZTFjNjkgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3Jl
cGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxpY3QuYworKysgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlv
bi9sb2dpY2FsL2NvbmZsaWN0LmMKQEAgLTEwOCw2ICsxMDgsMTEgQEAgUmVwb3J0QXBwbHlDb25m
bGljdChFU3RhdGUgKmVzdGF0ZSwgUmVzdWx0UmVsSW5mbyAqcmVsaW5mbywgaW50IGVsZXZlbCwK
IAlSZWxhdGlvbglsb2NhbHJlbCA9IHJlbGluZm8tPnJpX1JlbGF0aW9uRGVzYzsKIAlTdHJpbmdJ
bmZvRGF0YSBlcnJfZGV0YWlsOwogCisJcGdzdGF0X3JlcG9ydF9zdWJzY3JpcHRpb25fY29uZmxp
Y3QoTXlTdWJzY3JpcHRpb24tPm9pZCwgdHlwZSk7CisKKwlpZiAoIW1lc3NhZ2VfbGV2ZWxfaXNf
aW50ZXJlc3RpbmcoZWxldmVsKSkKKwkJcmV0dXJuOworCiAJaW5pdFN0cmluZ0luZm8oJmVycl9k
ZXRhaWwpOwogCiAJLyogRm9ybSBlcnJkZXRhaWwgbWVzc2FnZSBieSBjb21iaW5pbmcgY29uZmxp
Y3RpbmcgdHVwbGVzIGluZm9ybWF0aW9uLiAqLwpAQCAtMTIwLDggKzEyNSw2IEBAIFJlcG9ydEFw
cGx5Q29uZmxpY3QoRVN0YXRlICplc3RhdGUsIFJlc3VsdFJlbEluZm8gKnJlbGluZm8sIGludCBl
bGV2ZWwsCiAJCQkJCQkJCSBjb25mbGljdHR1cGxlLT50cywKIAkJCQkJCQkJICZlcnJfZGV0YWls
KTsKIAotCXBnc3RhdF9yZXBvcnRfc3Vic2NyaXB0aW9uX2NvbmZsaWN0KE15U3Vic2NyaXB0aW9u
LT5vaWQsIHR5cGUpOwotCiAJZXJlcG9ydChlbGV2ZWwsCiAJCQllcnJjb2RlX2FwcGx5X2NvbmZs
aWN0KHR5cGUpLAogCQkJZXJybXNnKCJjb25mbGljdCBkZXRlY3RlZCBvbiByZWxhdGlvbiBcIiVz
LiVzXCI6IGNvbmZsaWN0PSVzIiwKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBj
L3Byb2NhcnJheS5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvcHJvY2FycmF5LmMKaW5kZXgg
Y2MyMDdjYjU2ZTMuLjdlOWJmYWM2MzRmIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9zdG9yYWdl
L2lwYy9wcm9jYXJyYXkuYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9wcm9jYXJyYXku
YwpAQCAtNTI2Nyw2ICs1MjY3LDkgQEAgS25vd25Bc3NpZ25lZFhpZHNEaXNwbGF5KGludCB0cmFj
ZV9sZXZlbCkKIAl0YWlsID0gcEFycmF5LT50YWlsS25vd25Bc3NpZ25lZFhpZHM7CiAJaGVhZCA9
IHBBcnJheS0+aGVhZEtub3duQXNzaWduZWRYaWRzOwogCisJaWYgKCFtZXNzYWdlX2xldmVsX2lz
X2ludGVyZXN0aW5nKHRyYWNlX2xldmVsKSkKKwkJcmV0dXJuOworCiAJaW5pdFN0cmluZ0luZm8o
JmJ1Zik7CiAKIAlmb3IgKGkgPSB0YWlsOyBpIDwgaGVhZDsgaSsrKQpkaWZmIC0tZ2l0IGEvc3Jj
L2JhY2tlbmQvc3RvcmFnZS9pcGMvc3RhbmRieS5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMv
c3RhbmRieS5jCmluZGV4IGRlOTA5MmZkZjViLi4yZjJjMGRmN2I3NCAxMDA2NDQKLS0tIGEvc3Jj
L2JhY2tlbmQvc3RvcmFnZS9pcGMvc3RhbmRieS5jCisrKyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2Uv
aXBjL3N0YW5kYnkuYwpAQCAtMjgyLDYgKzI4Miw5IEBAIExvZ1JlY292ZXJ5Q29uZmxpY3QoUmVj
b3ZlcnlDb25mbGljdFJlYXNvbiByZWFzb24sIFRpbWVzdGFtcFR6IHdhaXRfc3RhcnQsCiAJU3Ry
aW5nSW5mb0RhdGEgYnVmOwogCWludAkJCW5wcm9jcyA9IDA7CiAKKwlpZiAoIW1lc3NhZ2VfbGV2
ZWxfaXNfaW50ZXJlc3RpbmcoTE9HKSkKKwkJcmV0dXJuOworCiAJLyoKIAkgKiBUaGVyZSBtdXN0
IGJlIG5vIGNvbmZsaWN0aW5nIHByb2Nlc3NlcyB3aGVuIHRoZSByZWNvdmVyeSBjb25mbGljdCBo
YXMKIAkgKiBhbHJlYWR5IGJlZW4gcmVzb2x2ZWQuCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9z
dG9yYWdlL2xtZ3IvbG9jay5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2xvY2suYwppbmRl
eCAyMzQ2NDNlNGRkNy4uNjlkZDIxZjE3OGIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0b3Jh
Z2UvbG1nci9sb2NrLmMKKysrIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2xvY2suYwpAQCAt
MTE3Miw3ICsxMTcyLDcgQEAgTG9ja0FjcXVpcmVFeHRlbmRlZChjb25zdCBMT0NLVEFHICpsb2Nr
dGFnLAogCQkJICogbG9nTG9ja0ZhaWx1cmUgPSB0cnVlIGFuZCBsb2NrIGFjcXVpc2l0aW9uIGZh
aWxzIHdpdGggZG9udFdhaXQKIAkJCSAqID0gdHJ1ZQogCQkJICovCi0JCQlpZiAobG9nTG9ja0Zh
aWx1cmUpCisJCQlpZiAobG9nTG9ja0ZhaWx1cmUgJiYgbWVzc2FnZV9sZXZlbF9pc19pbnRlcmVz
dGluZyhMT0cpKQogCQkJewogCQkJCVN0cmluZ0luZm9EYXRhIGJ1ZiwKIAkJCQkJCQlsb2NrX3dh
aXRlcnNfc2J1ZiwKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9wcm9jLmMg
Yi9zcmMvYmFja2VuZC9zdG9yYWdlL2xtZ3IvcHJvYy5jCmluZGV4IDVjNDdjZjEzNDczLi42NzUx
MWU4YTZmYiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL3Byb2MuYworKysg
Yi9zcmMvYmFja2VuZC9zdG9yYWdlL2xtZ3IvcHJvYy5jCkBAIC0xNTcwLDcgKzE1NzAsNyBAQCBQ
cm9jU2xlZXAoTE9DQUxMT0NLICpsb2NhbGxvY2spCiAJCQlpZiAobXlXYWl0U3RhdHVzID09IFBS
T0NfV0FJVF9TVEFUVVNfT0spCiAJCQkJcGdzdGF0X2NvdW50X2xvY2tfd2FpdHMobG9jYWxsb2Nr
LT50YWcubG9jay5sb2NrdGFnX3R5cGUsIG1zZWNzKTsKIAotCQkJaWYgKGxvZ19sb2NrX3dhaXRz
KQorCQkJaWYgKGxvZ19sb2NrX3dhaXRzICYmIG1lc3NhZ2VfbGV2ZWxfaXNfaW50ZXJlc3Rpbmco
TE9HKSkKIAkJCXsKIAkJCQlTdHJpbmdJbmZvRGF0YSBidWYsCiAJCQkJCQkJbG9ja193YWl0ZXJz
X3NidWYsCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMgYi9z
cmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMKaW5kZXggMjYxMTg2NjFmMDcuLjFmYjAw
ZmFhOTc4IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMKKysr
IGIvc3JjL2JhY2tlbmQvdXRpbHMvaW5pdC9wb3N0aW5pdC5jCkBAIC0yNjksNyArMjY5LDggQEAg
UGVyZm9ybUF1dGhlbnRpY2F0aW9uKFBvcnQgKnBvcnQpCiAJLyogQ2FwdHVyZSBhdXRoZW50aWNh
dGlvbiBlbmQgdGltZSBmb3IgbG9nZ2luZyAqLwogCWNvbm5fdGltaW5nLmF1dGhfZW5kID0gR2V0
Q3VycmVudFRpbWVzdGFtcCgpOwogCi0JaWYgKGxvZ19jb25uZWN0aW9ucyAmIExPR19DT05ORUNU
SU9OX0FVVEhPUklaQVRJT04pCisJaWYgKChsb2dfY29ubmVjdGlvbnMgJiBMT0dfQ09OTkVDVElP
Tl9BVVRIT1JJWkFUSU9OKSAmJgorCQltZXNzYWdlX2xldmVsX2lzX2ludGVyZXN0aW5nKExPRykp
CiAJewogCQlTdHJpbmdJbmZvRGF0YSBsb2dtc2c7CiAKLS0gCjIuNDMuMAoK
--000000000000ce96af064e3e9a80--