MIME-Version: 1.0
References: 
 <CAJDiXgi=Vcp1nh2UoZ5=7BCoR+uXoYzqMsfOfga-XxSUHjFj5Q@mail.gmail.com>
 <CAHut+PvX8s0KBFeKOq+O1T+R0pdBGOp445QK1p6nVScnxSLFaA@mail.gmail.com>
In-Reply-To: 
 <CAHut+PvX8s0KBFeKOq+O1T+R0pdBGOp445QK1p6nVScnxSLFaA@mail.gmail.com>
From: Daniil Davydov <3danissimo@gmail.com>
Date: Mon, 30 Mar 2026 13:36:35 +0700
Message-ID: 
 <CAJDiXgjXmU9jKKsyRCMuQu25NiRDLJch6-r7LzK1=3FFZA=sMQ@mail.gmail.com>
Subject: Re: Get rid of redundant StringInfo accumulation
To: Peter Smith <smithpb2250@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000002445e7064e381331"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJDiXgjXmU9jKKsyRCMuQu25NiRDLJch6-r7LzK1%3D3FFZA%3DsMQ%40mail.gmail.com>
Precedence: bulk

--0000000000002445e7064e381331
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Mar 30, 2026 at 4:52=E2=80=AFAM Peter Smith <smithpb2250@gmail.com>=
 wrote:
>
> 1.
> @@ -108,6 +108,9 @@ ReportApplyConflict(EState *estate, ResultRelInfo
> *relinfo, int elevel,
>   Relation localrel =3D relinfo->ri_RelationDesc;
>   StringInfoData err_detail;
>
> + if (!message_level_is_interesting(elevel))
> + return;
> +
>
> AFAICT, this change will also cause the
> pgstat_report_subscription_conflict() to be skipped. But that call was
> not associated with the log level.
>

Thank you for looking into it!

Yeah, now the report_subscription_conflict call may be mistakenly skipped.
Since it just adds pgstat pending entry and does not depend on the log leve=
l,
I'll move this call above the log level check. I think this is OK, because
pgstat accumulation has nothing common with logging that we are trying to s=
kip.

Please, see the updated patch.

--
Best regards,
Daniil Davydov

--0000000000002445e7064e381331
Content-Type: text/x-patch; charset="US-ASCII";
	name="v2-0001-Get-rid-of-redundant-calculations.patch"
Content-Disposition: attachment;
	filename="v2-0001-Get-rid-of-redundant-calculations.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnct7psi0>
X-Attachment-Id: f_mnct7psi0

RnJvbSAxNmNlMGE1M2U1MGMxMTVjMTNmNTRjY2I3NTM5YWJhZDE2NjA0OGIzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5paWwgRGF2aWRvdiA8ZC5kYXZ5ZG92QHBvc3RncmVzcHJv
LnJ1PgpEYXRlOiBNb24sIDMwIE1hciAyMDI2IDEzOjI0OjAzICswNzAwClN1YmplY3Q6IFtQQVRD
SCB2Ml0gR2V0IHJpZCBvZiByZWR1bmRhbnQgY2FsY3VsYXRpb25zCgotLS0KIHNyYy9iYWNrZW5k
L3JlcGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxpY3QuYyB8IDcgKysrKystLQogc3JjL2JhY2tlbmQv
c3RvcmFnZS9pcGMvcHJvY2FycmF5LmMgICAgICAgIHwgMyArKysKIHNyYy9iYWNrZW5kL3N0b3Jh
Z2UvaXBjL3N0YW5kYnkuYyAgICAgICAgICB8IDMgKysrCiBzcmMvYmFja2VuZC9zdG9yYWdlL2xt
Z3IvbG9jay5jICAgICAgICAgICAgfCAyICstCiBzcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rp
bml0LmMgICAgICAgICAgfCAzICsrLQogNSBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp
LCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xv
Z2ljYWwvY29uZmxpY3QuYyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxp
Y3QuYwppbmRleCBjYTcxYTgxYzdiZi4uN2I2NzZjZTFjNjkgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNr
ZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvY29uZmxpY3QuYworKysgYi9zcmMvYmFja2VuZC9yZXBs
aWNhdGlvbi9sb2dpY2FsL2NvbmZsaWN0LmMKQEAgLTEwOCw2ICsxMDgsMTEgQEAgUmVwb3J0QXBw
bHlDb25mbGljdChFU3RhdGUgKmVzdGF0ZSwgUmVzdWx0UmVsSW5mbyAqcmVsaW5mbywgaW50IGVs
ZXZlbCwKIAlSZWxhdGlvbglsb2NhbHJlbCA9IHJlbGluZm8tPnJpX1JlbGF0aW9uRGVzYzsKIAlT
dHJpbmdJbmZvRGF0YSBlcnJfZGV0YWlsOwogCisJcGdzdGF0X3JlcG9ydF9zdWJzY3JpcHRpb25f
Y29uZmxpY3QoTXlTdWJzY3JpcHRpb24tPm9pZCwgdHlwZSk7CisKKwlpZiAoIW1lc3NhZ2VfbGV2
ZWxfaXNfaW50ZXJlc3RpbmcoZWxldmVsKSkKKwkJcmV0dXJuOworCiAJaW5pdFN0cmluZ0luZm8o
JmVycl9kZXRhaWwpOwogCiAJLyogRm9ybSBlcnJkZXRhaWwgbWVzc2FnZSBieSBjb21iaW5pbmcg
Y29uZmxpY3RpbmcgdHVwbGVzIGluZm9ybWF0aW9uLiAqLwpAQCAtMTIwLDggKzEyNSw2IEBAIFJl
cG9ydEFwcGx5Q29uZmxpY3QoRVN0YXRlICplc3RhdGUsIFJlc3VsdFJlbEluZm8gKnJlbGluZm8s
IGludCBlbGV2ZWwsCiAJCQkJCQkJCSBjb25mbGljdHR1cGxlLT50cywKIAkJCQkJCQkJICZlcnJf
ZGV0YWlsKTsKIAotCXBnc3RhdF9yZXBvcnRfc3Vic2NyaXB0aW9uX2NvbmZsaWN0KE15U3Vic2Ny
aXB0aW9uLT5vaWQsIHR5cGUpOwotCiAJZXJlcG9ydChlbGV2ZWwsCiAJCQllcnJjb2RlX2FwcGx5
X2NvbmZsaWN0KHR5cGUpLAogCQkJZXJybXNnKCJjb25mbGljdCBkZXRlY3RlZCBvbiByZWxhdGlv
biBcIiVzLiVzXCI6IGNvbmZsaWN0PSVzIiwKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3Jh
Z2UvaXBjL3Byb2NhcnJheS5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvcHJvY2FycmF5LmMK
aW5kZXggY2MyMDdjYjU2ZTMuLjdlOWJmYWM2MzRmIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9z
dG9yYWdlL2lwYy9wcm9jYXJyYXkuYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9wcm9j
YXJyYXkuYwpAQCAtNTI2Nyw2ICs1MjY3LDkgQEAgS25vd25Bc3NpZ25lZFhpZHNEaXNwbGF5KGlu
dCB0cmFjZV9sZXZlbCkKIAl0YWlsID0gcEFycmF5LT50YWlsS25vd25Bc3NpZ25lZFhpZHM7CiAJ
aGVhZCA9IHBBcnJheS0+aGVhZEtub3duQXNzaWduZWRYaWRzOwogCisJaWYgKCFtZXNzYWdlX2xl
dmVsX2lzX2ludGVyZXN0aW5nKHRyYWNlX2xldmVsKSkKKwkJcmV0dXJuOworCiAJaW5pdFN0cmlu
Z0luZm8oJmJ1Zik7CiAKIAlmb3IgKGkgPSB0YWlsOyBpIDwgaGVhZDsgaSsrKQpkaWZmIC0tZ2l0
IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvc3RhbmRieS5jIGIvc3JjL2JhY2tlbmQvc3RvcmFn
ZS9pcGMvc3RhbmRieS5jCmluZGV4IGRlOTA5MmZkZjViLi4yZjJjMGRmN2I3NCAxMDA2NDQKLS0t
IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvc3RhbmRieS5jCisrKyBiL3NyYy9iYWNrZW5kL3N0
b3JhZ2UvaXBjL3N0YW5kYnkuYwpAQCAtMjgyLDYgKzI4Miw5IEBAIExvZ1JlY292ZXJ5Q29uZmxp
Y3QoUmVjb3ZlcnlDb25mbGljdFJlYXNvbiByZWFzb24sIFRpbWVzdGFtcFR6IHdhaXRfc3RhcnQs
CiAJU3RyaW5nSW5mb0RhdGEgYnVmOwogCWludAkJCW5wcm9jcyA9IDA7CiAKKwlpZiAoIW1lc3Nh
Z2VfbGV2ZWxfaXNfaW50ZXJlc3RpbmcoTE9HKSkKKwkJcmV0dXJuOworCiAJLyoKIAkgKiBUaGVy
ZSBtdXN0IGJlIG5vIGNvbmZsaWN0aW5nIHByb2Nlc3NlcyB3aGVuIHRoZSByZWNvdmVyeSBjb25m
bGljdCBoYXMKIAkgKiBhbHJlYWR5IGJlZW4gcmVzb2x2ZWQuCmRpZmYgLS1naXQgYS9zcmMvYmFj
a2VuZC9zdG9yYWdlL2xtZ3IvbG9jay5jIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2xvY2su
YwppbmRleCAyMzQ2NDNlNGRkNy4uNjlkZDIxZjE3OGIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5k
L3N0b3JhZ2UvbG1nci9sb2NrLmMKKysrIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9sbWdyL2xvY2su
YwpAQCAtMTE3Miw3ICsxMTcyLDcgQEAgTG9ja0FjcXVpcmVFeHRlbmRlZChjb25zdCBMT0NLVEFH
ICpsb2NrdGFnLAogCQkJICogbG9nTG9ja0ZhaWx1cmUgPSB0cnVlIGFuZCBsb2NrIGFjcXVpc2l0
aW9uIGZhaWxzIHdpdGggZG9udFdhaXQKIAkJCSAqID0gdHJ1ZQogCQkJICovCi0JCQlpZiAobG9n
TG9ja0ZhaWx1cmUpCisJCQlpZiAobG9nTG9ja0ZhaWx1cmUgJiYgbWVzc2FnZV9sZXZlbF9pc19p
bnRlcmVzdGluZyhMT0cpKQogCQkJewogCQkJCVN0cmluZ0luZm9EYXRhIGJ1ZiwKIAkJCQkJCQls
b2NrX3dhaXRlcnNfc2J1ZiwKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2luaXQvcG9z
dGluaXQuYyBiL3NyYy9iYWNrZW5kL3V0aWxzL2luaXQvcG9zdGluaXQuYwppbmRleCAyNjExODY2
MWYwNy4uMWZiMDBmYWE5NzggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2luaXQvcG9z
dGluaXQuYworKysgYi9zcmMvYmFja2VuZC91dGlscy9pbml0L3Bvc3Rpbml0LmMKQEAgLTI2OSw3
ICsyNjksOCBAQCBQZXJmb3JtQXV0aGVudGljYXRpb24oUG9ydCAqcG9ydCkKIAkvKiBDYXB0dXJl
IGF1dGhlbnRpY2F0aW9uIGVuZCB0aW1lIGZvciBsb2dnaW5nICovCiAJY29ubl90aW1pbmcuYXV0
aF9lbmQgPSBHZXRDdXJyZW50VGltZXN0YW1wKCk7CiAKLQlpZiAobG9nX2Nvbm5lY3Rpb25zICYg
TE9HX0NPTk5FQ1RJT05fQVVUSE9SSVpBVElPTikKKwlpZiAoKGxvZ19jb25uZWN0aW9ucyAmIExP
R19DT05ORUNUSU9OX0FVVEhPUklaQVRJT04pICYmCisJCW1lc3NhZ2VfbGV2ZWxfaXNfaW50ZXJl
c3RpbmcoTE9HKSkKIAl7CiAJCVN0cmluZ0luZm9EYXRhIGxvZ21zZzsKIAotLSAKMi40My4wCgo=
--0000000000002445e7064e381331--