MIME-Version: 1.0
References: 
 <CACJufxHCh_FU-FsEwsCvg9mN6-5tzR6H9ntn+0KUgTCaerDOmg@mail.gmail.com>
 <CACJufxFJFpU0V6zW6nic8_K9NOZqu1g5MOuuSRPTJ9xSAmeNrw@mail.gmail.com>
 <CABV9wwNF45wmhs3gFH7qcyEVQjREQL1y=2ARzLgY__fNT2tWpw@mail.gmail.com>
 <CACJufxFY=GkptsiH8X=VdyYAnNE_=u5j6WyDufTste6CuzRvnw@mail.gmail.com>
 <CALdSSPg7x+zfKaCkq_bBbz7q8nYu93G3-tK+3si_kPwOcnU0iw@mail.gmail.com>
In-Reply-To: 
 <CALdSSPg7x+zfKaCkq_bBbz7q8nYu93G3-tK+3si_kPwOcnU0iw@mail.gmail.com>
From: Robert Treat <rob@xzilla.net>
Date: Thu, 6 Nov 2025 18:29:28 -0500
Message-ID: 
 <CAJSLCQ0rgBK5cgXZzZSHnyBWi95Ngkky8+c1Jf_S0z_x4x6Zrw@mail.gmail.com>
Subject: Re: alter check constraint enforceability
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAJSLCQ0rgBK5cgXZzZSHnyBWi95Ngkky8%2Bc1Jf_S0z_x4x6Zrw%40mail.gmail.com>
Precedence: bulk

On Mon, Aug 11, 2025 at 10:00=E2=80=AFAM Kirill Reshke <reshkekirill@gmail.=
com> wrote:
> On Mon, 11 Aug 2025 at 14:53, jian he <jian.universality@gmail.com> wrote=
:
> > On Thu, Aug 7, 2025 at 7:35=E2=80=AFAM Robert Treat <rob@xzilla.net> wr=
ote:
> > >
> > > + if (rel->rd_rel->relkind =3D=3D RELKIND_RELATION &&
> > > +     cmdcon->is_enforced &&
> > > +     !currcon->conenforced)
> > >
> > > i think I have convinced myself that this is correct, but maybe I wil=
l
> > > ask you if you had any concerns that this needed to also consider
> > > RELKIND_PARTITIONED_TABLE as well?
> > >
> >
> > ATExecAlterCheckConstrEnforceability itself will be recursive to all
> > the children.
> > AlterConstrUpdateConstraintEntry is responsible for changing the catalo=
g state.
> > except the changing the catalog state, if we change the check
> > constraint from NOT ENFORCED
> > to ENFORCED,  we also need to verify it in phase 3.
> > that's the purpose of
> > > + if (rel->rd_rel->relkind =3D=3D RELKIND_RELATION &&
> > > +     cmdcon->is_enforced &&
> > > +     !currcon->conenforced)
> >
> > partitioned tables don't have storage, phase3 table scan to verify
> > check constraint on partitioned table
> > don't have effect.
> >
> > also partitioned table check constraint (name, definition
> > (pg_constraint.conbin) must match with partition
> > otherwise partition can be attached to the partitioned table.
> > so here you don't need to consider RELKIND_PARTITIONED_TABLE.
>
>
> Hi!
> I looked at v3.
>
> Should we rename `ATExecAlterConstrEnforceability` to
> `ATExecAlterFKConstrEnforceability `?
>

+1

Robert Treat
https://xzilla.net