MIME-Version: 1.0
References: <202508301750.cbohxyy2pcce@alvherre.pgsql>
 <202509251758.t77p7r2ocmej@alvherre.pgsql>
 <CAB-JLwZTViGAi01hC9_G4HNwL59W4tKovFPuoL+7ZLwsiKDiiw@mail.gmail.com>
In-Reply-To: 
 <CAB-JLwZTViGAi01hC9_G4HNwL59W4tKovFPuoL+7ZLwsiKDiiw@mail.gmail.com>
From: Robert Treat <rob@xzilla.net>
Date: Thu, 25 Sep 2025 17:31:35 -0400
Message-ID: 
 <CAJSLCQ38JzwVr+O1G9WhVw+G5MuECCD0T_e55097m9-gc2qfnQ@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Marcos Pegoraro <marcos@f10.com.br>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Antonin Houska <ah@cybertec.at>,
	Fujii Masao <masao.fujii@gmail.com>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAJSLCQ38JzwVr%2BO1G9WhVw%2BG5MuECCD0T_e55097m9-gc2qfnQ%40mail.gmail.com>
Precedence: bulk

On Thu, Sep 25, 2025 at 4:21=E2=80=AFPM Marcos Pegoraro <marcos@f10.com.br>=
 wrote:
>
> Em qui., 25 de set. de 2025 =C3=A0s 15:12, =C3=81lvaro Herrera <alvherre@=
kurilemu.de> escreveu:
>
> Some typos I've found on usage of pg_repackdb.
>
> + printf(_("  -n, --schema=3DSCHEMA             repack tables in the spec=
ified schema(s) only\n"));
> + printf(_("  -N, --exclude-schema=3DSCHEMA     do not repack tables in t=
he specified schema(s)\n"));
> both options can point to a single schema, so "(s)" should be removed.
> "in the specified schema(s)" should be "in the specified schema"
>
> Same occurs on this one, which should be table, not table(s)
> + printf(_("  -t, --table=3D'TABLE'             repack specific table(s) =
only\n"));
>

This pattern is used because you can pass more than one argument, for
example, something like

pg_repackdb -d pagila -v -n public -n legacy

While I agree that the wording is a little awkward; I'd prefer "repack
tables only in the specified schema(s)"; but this follows the same
pattern as pg_dump and friends.

Robert Treat
https://xzilla.net