MIME-Version: 1.0
References: 
 <CAEoWx2n6ShLMOnjOtf63TjjgGbgiTVT5OMsSOFmbjGb6Xue1Bw@mail.gmail.com>
 <CABV9wwMPmo-dg=oV+NaJGa_==uo5+TTvk58aNtjVQZBtMcRVBw@mail.gmail.com>
 <CAEoWx2kkh5kCZwYOYaOVShjh3un2mJTGrcFZyhJXd320PHYfJw@mail.gmail.com>
 <CAJSLCQ10_gia2-GzQndwoM-n-v2DWz4LnAY5jyO2ZmNiE+56tA@mail.gmail.com>
 <E9FEE306-E00D-4ECA-97B0-219BE7AB5169@gmail.com>
 <7D4CB5FF-6599-4157-A9E3-7B5E2CB96CEE@gmail.com>
 <CAEoWx2mOW=JMjSNrNsc3b-+8w0wbT2f6FSsyudD_Q-0pe_fkfw@mail.gmail.com>
 <CAHGQGwFk=rrhrwGwPtQxBesbT4DzSZ86Q3ftcwCu3AR5bOiXLw@mail.gmail.com>
 <86974902-199B-413E-B4DA-9A484AB3A119@gmail.com>
 <8F0F27C6-2267-4382-B4B7-C526B2950175@gmail.com>
In-Reply-To: <8F0F27C6-2267-4382-B4B7-C526B2950175@gmail.com>
From: Robert Treat <rob@xzilla.net>
Date: Mon, 2 Mar 2026 23:41:13 -0500
Message-ID: 
 <CAJSLCQ3h6fyMNaH1PnUPXRTdkkH+3+ctEogG4YUWY+XtQUKH6g@mail.gmail.com>
Subject: Re: DOC: fixes multiple errors in alter table doc
To: Chao Li <li.evan.chao@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAJSLCQ3h6fyMNaH1PnUPXRTdkkH%2B3%2BctEogG4YUWY%2BXtQUKH6g%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 2, 2026 at 9:09=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wro=
te:
> > On Mar 2, 2026, at 17:22, Chao Li <li.evan.chao@gmail.com> wrote:
> >> On Mar 2, 2026, at 17:04, Fujii Masao <masao.fujii@gmail.com> wrote:
> >> On Thu, Jan 22, 2026 at 6:38=E2=80=AFPM Chao Li <li.evan.chao@gmail.co=
m> wrote:
> >>> PFA v3: Rebased, and added reviewer and discussion information.
> >>
> >> LGTM.
> >>
> >> Should we apply the same change to the ALTER FOREIGN TABLE docs as wel=
l?
> >
> > Sure, I can make the change.
> >
> >>
> >> While reviewing that section, I noticed that ADD COLUMN IF NOT EXISTS =
appears
> >> to work for ALTER FOREIGN TABLE, but it isn't documented. I'm not sure=
 why
> >> it was left out, but perhaps we should document it and add a regressio=
n test in
> >> a separate patch?
> >>
> >
> > I will verify that, then update the doc and regression test accordingly=
.
> >
> > Best regards,
> > --
> > Chao Li (Evan)
> > HighGo Software Co., Ltd.
> > https://www.highgo.com/
> >
>
> PFA v4:
>
> 0001 - alter table related changes
>
>  * Add test cases for omitting COLUMN of ALTER TABLE ADD/DROP [COLUMN]
>  * Add a test case for ADD COLUMN IF NOT EXIST (already had DROP COLUMN I=
F EXIST)
>
> 0002 - alter foreign table related changes
>
>  * doc: Add IF NOT EXSTS for ADD COLUMN
>  * doc: Mark COLUMN as optional for ADD/DROP COLUMN in the same way as 00=
01
>  * Add test cases for omitting COLUMN of ALTER FOREIGN TABLE ADD/DROP [CO=
LUMN]
>  * Add a test cases for for ADD COLUMN IF NOT EXIST
>  * Add a test cases for for DROP COLUMN IF EXIST
>

LGTM, although I was curious why you went with c12 vs c11 in
+ALTER FOREIGN TABLE ft1 ADD c12 integer; -- omit COLUMN
or maybe that should be changed?


Robert Treat
https://xzilla.net