MIME-Version: 1.0
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Wed, 15 Apr 2026 19:27:16 +0530
Message-ID: 
 <CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA@mail.gmail.com>
Subject: [PATCH] postmaster: fix stale PM_STARTUP comment
To: pgsql-hackers@postgresql.org
Content-Type: multipart/mixed; boundary="0000000000009841fb064f801832"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA%40mail.gmail.com>
Precedence: bulk

--0000000000009841fb064f801832
Content-Type: multipart/alternative; boundary="0000000000009841fa064f801830"

--0000000000009841fa064f801830
Content-Type: text/plain; charset="UTF-8"

Hi,

The comment above the PM_STARTUP startup-process-failure case still says
that there are no other processes running yet, so the postmaster can just
exit.

That no longer matches the current startup flow: PM_STARTUP may already
have auxiliary processes running by that point. The attached patch updates
that comment to describe the current behavior.

Regards,
Ayush

--0000000000009841fa064f801830
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>The comment above the PM_STARTUP startup-proces=
s-failure case still says<br>that there are no other processes running yet,=
 so the postmaster can just<br>exit.<br><br>That no longer matches the curr=
ent startup flow: PM_STARTUP may already<br>have auxiliary processes runnin=
g by that point. The attached patch updates<br>that comment to describe the=
 current behavior.<br><br>Regards,<br>Ayush</div>

--0000000000009841fa064f801830--

--0000000000009841fb064f801832
Content-Type: application/octet-stream;
	name="0001-postmaster-fix-stale-pm_startup-comment.patch"
Content-Disposition: attachment;
	filename="0001-postmaster-fix-stale-pm_startup-comment.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo045hnp0>
X-Attachment-Id: f_mo045hnp0

RnJvbSA5NzJjMTRmYjkxMzRmZGZkNzZlYTZlYmNmOThhNTVhOTQ1YmJjOTg4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQ0KRnJvbTogQXl1c2ggVGl3YXJpIDxheXVzaHRpd2FyaS5zbGcwMUBnbWFp
bC5jb20+DQpEYXRlOiBXZWQsIDE1IEFwciAyMDI2IDE4OjU0OjU2ICswNTMwDQpTdWJqZWN0OiBb
UEFUQ0hdIHBvc3RtYXN0ZXI6IGZpeCBzdGFsZSBQTV9TVEFSVFVQIGNvbW1lbnQNCg0KVGhlIGNv
bW1lbnQgYWJvdmUgdGhlIFBNX1NUQVJUVVAgc3RhcnR1cC1wcm9jZXNzLWZhaWx1cmUgY2FzZSBz
dGlsbCBzYXlzDQp0aGVyZSBhcmUgbm8gb3RoZXIgcHJvY2Vzc2VzIHJ1bm5pbmcgeWV0Lg0KDQpU
aGF0IGlzIG5vIGxvbmdlciBhY2N1cmF0ZTogb3RoZXIgcG9zdG1hc3RlciBjaGlsZHJlbiBtYXkg
YWxyZWFkeSBiZQ0KcnVubmluZyBieSB0aGlzIHBvaW50LiBBZGp1c3QgdGhlIGNvbW1lbnQgdG8g
ZGVzY3JpYmUgdGhlIGN1cnJlbnQNCmJlaGF2aW9yIG1vcmUgYWNjdXJhdGVseS4NCg0KLS0tDQog
c3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9wb3N0bWFzdGVyLmMgfCA1ICsrKy0tDQogMSBmaWxlIGNo
YW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL3Ny
Yy9iYWNrZW5kL3Bvc3RtYXN0ZXIvcG9zdG1hc3Rlci5jIGIvc3JjL2JhY2tlbmQvcG9zdG1hc3Rl
ci9wb3N0bWFzdGVyLmMNCmluZGV4IDZlMGY0MWQyNjYxZS4uZDBiMmUwYmM4ZDJlIDEwMDY0NA0K
LS0tIGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9wb3N0bWFzdGVyLmMNCisrKyBiL3NyYy9iYWNr
ZW5kL3Bvc3RtYXN0ZXIvcG9zdG1hc3Rlci5jDQpAQCAtMjMwNyw4ICsyMzA3LDkgQEAgcHJvY2Vz
c19wbV9jaGlsZF9leGl0KHZvaWQpDQoJCQkvKg0KCQkJICogVW5leHBlY3RlZCBleGl0IG9mIHN0
YXJ0dXAgcHJvY2VzcyAoaW5jbHVkaW5nIEZBVEFMIGV4aXQpDQotCQkJICogZHVyaW5nIFBNX1NU
QVJUVVAgaXMgdHJlYXRlZCBhcyBjYXRhc3Ryb3BoaWMuIFRoZXJlIGFyZSBubw0KLQkJCSAqIG90
aGVyIHByb2Nlc3NlcyBydW5uaW5nIHlldCwgc28gd2UgY2FuIGp1c3QgZXhpdC4NCisJCQkgKiBk
dXJpbmcgUE1fU1RBUlRVUCBpcyB0cmVhdGVkIGFzIGNhdGFzdHJvcGhpYy4gV2hpbGUgb3RoZXIN
CisJCQkgKiBwb3N0bWFzdGVyIGNoaWxkcmVuIG1heSBhbHJlYWR5IGJlIHJ1bm5pbmcsIHRoaXMg
bGVhdmVzIHRoZQ0KKwkJCSAqIHN5c3RlbSBpbiBhbiB1bnJlY292ZXJhYmxlIHN0YXRlIHJlcXVp
cmluZyBpbW1lZGlhdGUgZXhpdC4NCgkJCSAqLw0KCQkJaWYgKHBtU3RhdGUgPT0gUE1fU1RBUlRV
UCAmJg0KCQkJCVN0YXJ0dXBTdGF0dXMgIT0gU1RBUlRVUF9TSUdOQUxFRCAmJg0KLS0gDQoyLjM0
LjENCg==
--0000000000009841fb064f801832--