MIME-Version: 1.0
References: 
 <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
 <0ABA607E-665C-4E25-93EB-A21DF9616E84@gmail.com>
In-Reply-To: <0ABA607E-665C-4E25-93EB-A21DF9616E84@gmail.com>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Wed, 6 May 2026 11:53:38 +0530
Message-ID: 
 <CAJTYsWVshTGyFRCMKnjiRgCnky1FB9vD-mjBHYGWDXppSdO0jQ@mail.gmail.com>
Subject: Re: [PATCH] Clean up property graph error messages
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000f763090651203464"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWVshTGyFRCMKnjiRgCnky1FB9vD-mjBHYGWDXppSdO0jQ%40mail.gmail.com>
Precedence: bulk

--000000000000f763090651203464
Content-Type: multipart/alternative; boundary="000000000000f763090651203462"

--000000000000f763090651203462
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,


On Tue, 5 May 2026 at 08:20, Chao Li <li.evan.chao@gmail.com> wrote:

>
> So, v1 LGTM. Only thing is that I think we can also make =E2=80=9Cmismatc=
hing=E2=80=9D to
> =E2=80=9Cmismatched=E2=80=9D in the errmsg.
>
>
I agree that "mismatched property names" reads better, so I have updated
that in v2.  I did not include the vertexes/vertices change here, since
Peter has already fixed that separately.

Regards,
Ayush

--000000000000f763090651203462
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,<div><br></div></div><br><div class=3D=
"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">O=
n Tue, 5 May 2026 at 08:20, Chao Li &lt;<a href=3D"mailto:li.evan.chao@gmai=
l.com">li.evan.chao@gmail.com</a>&gt; wrote:</div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex">
<br>
So, v1 LGTM. Only thing is that I think we can also make =E2=80=9Cmismatchi=
ng=E2=80=9D to =E2=80=9Cmismatched=E2=80=9D in the errmsg.<br><br></blockqu=
ote><div>=C2=A0</div>I agree that &quot;mismatched property names&quot; rea=
ds better, so I have updated<br>that in v2.=C2=A0 I did not include the ver=
texes/vertices change here, since<br><div>Peter has already fixed that sepa=
rately.=C2=A0</div><div><br></div><div>Regards,<br>Ayush</div></div></div>

--000000000000f763090651203462--

--000000000000f763090651203464
Content-Type: application/octet-stream;
	name="v2-0001-Clean-up-property-graph-error-messages.patch"
Content-Disposition: attachment;
	filename="v2-0001-Clean-up-property-graph-error-messages.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_moto71qm0>
X-Attachment-Id: f_moto71qm0

RnJvbSA1YTI4YzY5NWVjOTIxOGQ1M2EwZjliOTEzYmM5ZDMxMDY3MTA0ZDhjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBeXVzaCBUaXdhcmkgPGF5dXNodGl3YXJpLnNsZzAxQGdtYWls
LmNvbT4KRGF0ZTogV2VkLCA2IE1heSAyMDI2IDA2OjA3OjEyICswMDAwClN1YmplY3Q6IFtQQVRD
SCB2Ml0gQ2xlYW4gdXAgcHJvcGVydHkgZ3JhcGggZXJyb3IgbWVzc2FnZXMKCkZpeCBhIHR5cG8g
aW4gdGhlIGVycm9yIG1lc3NhZ2UgZm9yIG1pc21hdGNoZWQgcHJvcGVydHkgbmFtZXMgaW4KcHJv
cGVydHkgZ3JhcGggbGFiZWxzLgoKQWxzbyBtb3ZlIGFuIHVucmVhY2hhYmxlIFJlbGVhc2VTeXND
YWNoZSgpIGJlZm9yZSBlcmVwb3J0KEVSUk9SKSBpbgpjaGVja19lbGVtZW50X3Byb3BlcnRpZXMo
KSwgY29weWluZyB0aGUgZWxlbWVudCBhbGlhcyBhbmQgcmVsYXRpb24gT0lEIGZpcnN0CnNvIHRo
ZSBlcnJvciBwYXRoIGRvZXMgbm90IHJlZmVyZW5jZSB0aGUgcmVsZWFzZWQgc3lzY2FjaGUgdHVw
bGUuCi0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMvcHJvcGdyYXBoY21kcy5jICAgICAgICAgICAg
ICAgfCAxNCArKysrKysrKystLS0tLQogLi4uL3JlZ3Jlc3MvZXhwZWN0ZWQvY3JlYXRlX3Byb3Bl
cnR5X2dyYXBoLm91dCAgICAgfCAgOCArKysrLS0tLQogc3JjL3Rlc3QvcmVncmVzcy9zcWwvY3Jl
YXRlX3Byb3BlcnR5X2dyYXBoLnNxbCAgICAgfCAgNCArKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDE1
IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5k
L2NvbW1hbmRzL3Byb3BncmFwaGNtZHMuYyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3Byb3BncmFw
aGNtZHMuYwppbmRleCA0ODI4NGI4NGRiOS4uNmEzNWJhNjk4ZWUgMTAwNjQ0Ci0tLSBhL3NyYy9i
YWNrZW5kL2NvbW1hbmRzL3Byb3BncmFwaGNtZHMuYworKysgYi9zcmMvYmFja2VuZC9jb21tYW5k
cy9wcm9wZ3JhcGhjbWRzLmMKQEAgLTExMTMsNiArMTExMyw4IEBAIGNoZWNrX2VsZW1lbnRfcHJv
cGVydGllcyhPaWQgcGVvaWQpCiAJCQkJCQlIZWFwVHVwbGUJdHVwbGUzOwogCQkJCQkJRm9ybV9w
Z19wcm9wZ3JhcGhfZWxlbWVudCBlbGZvcm07CiAJCQkJCQlMaXN0CSAgICpkcGNvbnRleHQ7CisJ
CQkJCQljaGFyCSAgICplbGVtZW50X25hbWU7CisJCQkJCQlPaWQJCQllbGVtZW50X3JlbGlkOwog
CQkJCQkJY2hhcgkgICAqZHBhLAogCQkJCQkJCQkgICAqZHBiOwogCkBAIC0xMTIwLDcgKzExMjIs
MTEgQEAgY2hlY2tfZWxlbWVudF9wcm9wZXJ0aWVzKE9pZCBwZW9pZCkKIAkJCQkJCWlmICghdHVw
bGUzKQogCQkJCQkJCWVsb2coRVJST1IsICJjYWNoZSBsb29rdXAgZmFpbGVkIGZvciBwcm9wZXJ0
eSBncmFwaCBlbGVtZW50ICV1IiwgcGVvaWQpOwogCQkJCQkJZWxmb3JtID0gKEZvcm1fcGdfcHJv
cGdyYXBoX2VsZW1lbnQpIEdFVFNUUlVDVCh0dXBsZTMpOwotCQkJCQkJZHBjb250ZXh0ID0gZGVw
YXJzZV9jb250ZXh0X2ZvcihnZXRfcmVsX25hbWUoZWxmb3JtLT5wZ2VyZWxpZCksIGVsZm9ybS0+
cGdlcmVsaWQpOworCQkJCQkJZWxlbWVudF9uYW1lID0gcHN0cmR1cChOYW1lU3RyKGVsZm9ybS0+
cGdlYWxpYXMpKTsKKwkJCQkJCWVsZW1lbnRfcmVsaWQgPSBlbGZvcm0tPnBnZXJlbGlkOworCQkJ
CQkJUmVsZWFzZVN5c0NhY2hlKHR1cGxlMyk7CisKKwkJCQkJCWRwY29udGV4dCA9IGRlcGFyc2Vf
Y29udGV4dF9mb3IoZ2V0X3JlbF9uYW1lKGVsZW1lbnRfcmVsaWQpLCBlbGVtZW50X3JlbGlkKTsK
IAogCQkJCQkJZHBhID0gZGVwYXJzZV9leHByZXNzaW9uKG5hLCBkcGNvbnRleHQsIGZhbHNlLCBm
YWxzZSk7CiAJCQkJCQlkcGIgPSBkZXBhcnNlX2V4cHJlc3Npb24obmIsIGRwY29udGV4dCwgZmFs
c2UsIGZhbHNlKTsKQEAgLTExNDEsMTAgKzExNDcsOCBAQCBjaGVja19lbGVtZW50X3Byb3BlcnRp
ZXMoT2lkIHBlb2lkKQogCQkJCQkJZXJlcG9ydChFUlJPUiwKIAkJCQkJCQkJZXJyY29kZShFUlJD
T0RFX1NZTlRBWF9FUlJPUiksCiAJCQkJCQkJCWVycm1zZygiZWxlbWVudCBcIiVzXCIgcHJvcGVy
dHkgXCIlc1wiIGV4cHJlc3Npb24gbWlzbWF0Y2g6ICVzIHZzLiAlcyIsCi0JCQkJCQkJCQkgICBO
YW1lU3RyKGVsZm9ybS0+cGdlYWxpYXMpLCBnZXRfcHJvcGdyYXBoX3Byb3BlcnR5X25hbWUocHJv
cG9pZCksIGRwYSwgZHBiKSwKKwkJCQkJCQkJCSAgIGVsZW1lbnRfbmFtZSwgZ2V0X3Byb3BncmFw
aF9wcm9wZXJ0eV9uYW1lKHByb3BvaWQpLCBkcGEsIGRwYiksCiAJCQkJCQkJCWVycmRldGFpbCgi
SW4gYSBwcm9wZXJ0eSBncmFwaCBlbGVtZW50LCBhIHByb3BlcnR5IG9mIHRoZSBzYW1lIG5hbWUg
aGFzIHRvIGhhdmUgdGhlIHNhbWUgZXhwcmVzc2lvbiBpbiBlYWNoIGxhYmVsLiIpKTsKLQotCQkJ
CQkJUmVsZWFzZVN5c0NhY2hlKHR1cGxlMyk7CiAJCQkJCX0KIAogCQkJCQlicmVhazsKQEAgLTEy
NjYsNyArMTI3MCw3IEBAIGNoZWNrX2VsZW1lbnRfbGFiZWxfcHJvcGVydGllcyhPaWQgZWxsYWJl
bG9pZCkKIAlpZiAoZGlmZjEgfHwgZGlmZjIpCiAJCWVyZXBvcnQoRVJST1IsCiAJCQkJZXJyY29k
ZShFUlJDT0RFX0lOVkFMSURfT0JKRUNUX0RFRklOSVRJT04pLAotCQkJCWVycm1zZygibWlzbWF0
Y2hpbmcgcHJvcGVydGllcyBuYW1lcyBpbiBkZWZpbml0aW9uIG9mIGxhYmVsIFwiJXNcIiIsIGdl
dF9wcm9wZ3JhcGhfbGFiZWxfbmFtZShsYWJlbGlkKSkpOworCQkJCWVycm1zZygibWlzbWF0Y2hl
ZCBwcm9wZXJ0eSBuYW1lcyBpbiBkZWZpbml0aW9uIG9mIGxhYmVsIFwiJXNcIiIsIGdldF9wcm9w
Z3JhcGhfbGFiZWxfbmFtZShsYWJlbGlkKSkpOwogfQogCiAvKgpkaWZmIC0tZ2l0IGEvc3JjL3Rl
c3QvcmVncmVzcy9leHBlY3RlZC9jcmVhdGVfcHJvcGVydHlfZ3JhcGgub3V0IGIvc3JjL3Rlc3Qv
cmVncmVzcy9leHBlY3RlZC9jcmVhdGVfcHJvcGVydHlfZ3JhcGgub3V0CmluZGV4IDRmYzQ3NTlm
MThlLi5lYmI1ZjcwNzg3YiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9j
cmVhdGVfcHJvcGVydHlfZ3JhcGgub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQv
Y3JlYXRlX3Byb3BlcnR5X2dyYXBoLm91dApAQCAtMjA4LDEzICsyMDgsMTMgQEAgRVJST1I6ICBt
aXNtYXRjaGluZyBudW1iZXIgb2YgcHJvcGVydGllcyBpbiBkZWZpbml0aW9uIG9mIGxhYmVsICJs
MSIKIENSRUFURSBQUk9QRVJUWSBHUkFQSCBneAogICAgIFZFUlRFWCBUQUJMRVMgKAogICAgICAg
ICB0MSBLRVkgKGEpIExBQkVMIGwxIFBST1BFUlRJRVMgKGEsIGIpLAotICAgICAgICB0MiBLRVkg
KGkpIExBQkVMIGwxIFBST1BFUlRJRVMgKGkgQVMgYSwgaiBBUyBqKSAgLS0gbWlzbWF0Y2hpbmcg
cHJvcGVydHkgbmFtZXMgb24gbGFiZWwKKyAgICAgICAgdDIgS0VZIChpKSBMQUJFTCBsMSBQUk9Q
RVJUSUVTIChpIEFTIGEsIGogQVMgaikgIC0tIG1pc21hdGNoZWQgcHJvcGVydHkgbmFtZXMgb24g
bGFiZWwKICAgICApOwotRVJST1I6ICBtaXNtYXRjaGluZyBwcm9wZXJ0aWVzIG5hbWVzIGluIGRl
ZmluaXRpb24gb2YgbGFiZWwgImwxIgorRVJST1I6ICBtaXNtYXRjaGVkIHByb3BlcnR5IG5hbWVz
IGluIGRlZmluaXRpb24gb2YgbGFiZWwgImwxIgogQUxURVIgUFJPUEVSVFkgR1JBUEggZzQgQUxU
RVIgVkVSVEVYIFRBQkxFIHQxIEFERCBMQUJFTCB0M2wxIFBST1BFUlRJRVMgKGEgQVMgeCwgYiBB
UyB5eSwgYiBBUyB6eik7ICAtLSBtaXNtYXRjaGluZyBudW1iZXIgb2YgcHJvcGVydGllcyBvbiBs
YWJlbAogRVJST1I6ICBtaXNtYXRjaGluZyBudW1iZXIgb2YgcHJvcGVydGllcyBpbiBkZWZpbml0
aW9uIG9mIGxhYmVsICJ0M2wxIgotQUxURVIgUFJPUEVSVFkgR1JBUEggZzQgQUxURVIgVkVSVEVY
IFRBQkxFIHQxIEFERCBMQUJFTCB0M2wxIFBST1BFUlRJRVMgKGEgQVMgeCwgYiBBUyB6eik7ICAt
LSBtaXNtYXRjaGluZyBwcm9wZXJ0eSBuYW1lcyBvbiBsYWJlbAotRVJST1I6ICBtaXNtYXRjaGlu
ZyBwcm9wZXJ0aWVzIG5hbWVzIGluIGRlZmluaXRpb24gb2YgbGFiZWwgInQzbDEiCitBTFRFUiBQ
Uk9QRVJUWSBHUkFQSCBnNCBBTFRFUiBWRVJURVggVEFCTEUgdDEgQUREIExBQkVMIHQzbDEgUFJP
UEVSVElFUyAoYSBBUyB4LCBiIEFTIHp6KTsgIC0tIG1pc21hdGNoZWQgcHJvcGVydHkgbmFtZXMg
b24gbGFiZWwKK0VSUk9SOiAgbWlzbWF0Y2hlZCBwcm9wZXJ0eSBuYW1lcyBpbiBkZWZpbml0aW9u
IG9mIGxhYmVsICJ0M2wxIgogQUxURVIgUFJPUEVSVFkgR1JBUEggZzQgQUxURVIgVkVSVEVYIFRB
QkxFIHQxIEFERCBMQUJFTCB0M2wxIFBST1BFUlRJRVMgKGEgQVMgeCk7ICAtLSBtaXNtYXRjaGlu
ZyBudW1iZXIgb2YgcHJvcGVydGllcyBvbiBsYWJlbAogRVJST1I6ICBtaXNtYXRjaGluZyBudW1i
ZXIgb2YgcHJvcGVydGllcyBpbiBkZWZpbml0aW9uIG9mIGxhYmVsICJ0M2wxIgogQUxURVIgUFJP
UEVSVFkgR1JBUEggZzEgT1dORVIgVE8gcmVncmVzc19ncmFwaF91c2VyMTsKZGlmZiAtLWdpdCBh
L3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2NyZWF0ZV9wcm9wZXJ0eV9ncmFwaC5zcWwgYi9zcmMvdGVz
dC9yZWdyZXNzL3NxbC9jcmVhdGVfcHJvcGVydHlfZ3JhcGguc3FsCmluZGV4IDI0MWY5M2RmMzAy
Li5kMWY5M2ZlOTRhOCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvY3JlYXRlX3By
b3BlcnR5X2dyYXBoLnNxbAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9jcmVhdGVfcHJvcGVy
dHlfZ3JhcGguc3FsCkBAIC0xNjMsMTAgKzE2MywxMCBAQCBDUkVBVEUgUFJPUEVSVFkgR1JBUEgg
Z3gKIENSRUFURSBQUk9QRVJUWSBHUkFQSCBneAogICAgIFZFUlRFWCBUQUJMRVMgKAogICAgICAg
ICB0MSBLRVkgKGEpIExBQkVMIGwxIFBST1BFUlRJRVMgKGEsIGIpLAotICAgICAgICB0MiBLRVkg
KGkpIExBQkVMIGwxIFBST1BFUlRJRVMgKGkgQVMgYSwgaiBBUyBqKSAgLS0gbWlzbWF0Y2hpbmcg
cHJvcGVydHkgbmFtZXMgb24gbGFiZWwKKyAgICAgICAgdDIgS0VZIChpKSBMQUJFTCBsMSBQUk9Q
RVJUSUVTIChpIEFTIGEsIGogQVMgaikgIC0tIG1pc21hdGNoZWQgcHJvcGVydHkgbmFtZXMgb24g
bGFiZWwKICAgICApOwogQUxURVIgUFJPUEVSVFkgR1JBUEggZzQgQUxURVIgVkVSVEVYIFRBQkxF
IHQxIEFERCBMQUJFTCB0M2wxIFBST1BFUlRJRVMgKGEgQVMgeCwgYiBBUyB5eSwgYiBBUyB6eik7
ICAtLSBtaXNtYXRjaGluZyBudW1iZXIgb2YgcHJvcGVydGllcyBvbiBsYWJlbAotQUxURVIgUFJP
UEVSVFkgR1JBUEggZzQgQUxURVIgVkVSVEVYIFRBQkxFIHQxIEFERCBMQUJFTCB0M2wxIFBST1BF
UlRJRVMgKGEgQVMgeCwgYiBBUyB6eik7ICAtLSBtaXNtYXRjaGluZyBwcm9wZXJ0eSBuYW1lcyBv
biBsYWJlbAorQUxURVIgUFJPUEVSVFkgR1JBUEggZzQgQUxURVIgVkVSVEVYIFRBQkxFIHQxIEFE
RCBMQUJFTCB0M2wxIFBST1BFUlRJRVMgKGEgQVMgeCwgYiBBUyB6eik7ICAtLSBtaXNtYXRjaGVk
IHByb3BlcnR5IG5hbWVzIG9uIGxhYmVsCiBBTFRFUiBQUk9QRVJUWSBHUkFQSCBnNCBBTFRFUiBW
RVJURVggVEFCTEUgdDEgQUREIExBQkVMIHQzbDEgUFJPUEVSVElFUyAoYSBBUyB4KTsgIC0tIG1p
c21hdGNoaW5nIG51bWJlciBvZiBwcm9wZXJ0aWVzIG9uIGxhYmVsCiAKIEFMVEVSIFBST1BFUlRZ
IEdSQVBIIGcxIE9XTkVSIFRPIHJlZ3Jlc3NfZ3JhcGhfdXNlcjE7Ci0tIAoyLjQzLjAKCg==
--000000000000f763090651203464--