MIME-Version: 1.0
References: <ahP-JT4ZRPyobnLb@paquier.xyz> <ahQGnTqb7i0UUz70@paquier.xyz>
In-Reply-To: <ahQGnTqb7i0UUz70@paquier.xyz>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Mon, 25 May 2026 13:54:28 +0530
Message-ID: 
 <CAJTYsWVuyVK4OTQok2t1=Wz2F5bG+rS6hKuGqK8aBaw-2T7LgA@mail.gmail.com>
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and
 -DEXEC_BACKEND at startup
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000052f6a0652a01c82"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWVuyVK4OTQok2t1%3DWz2F5bG%2BrS6hKuGqK8aBaw-2T7LgA%40mail.gmail.com>
Precedence: bulk

--000000000000052f6a0652a01c82
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 25 May 2026 at 13:52, Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, May 25, 2026 at 04:45:41PM +0900, Michael Paquier wrote:
> > I did not take the cycles necessary for a bisect, but it looks like
> > this has been around for a few months at least.  I have pinged
> > f3c9e341cdf1 as a safe startup point for now, so that's a 2026 issue.
>
> Well, well:
> 0c8e082fba8d36434552d3d7800abda54acafd57 is the first bad commit
> committer: =C3=81lvaro Herrera <alvherre@kurilemu.de>
> date: Wed, 4 Feb 2026 16:56:57 +0100
> Assign "backend" type earlier during process start-up
>
> I have also checked manually a revert of this commit, and saw that the
> problem is gone, so it does not look like I have messed up my bisect.
>

I was doing a Binary search to look for commits around those paths.

I also checked 0c8e082fba8 directly: its parent starts clean with the
same setup, while 0c8e082fba8 reports the NULL pointer passed to fwrite().

So this looks to be caused by 0c8e082fba8.  After that commit, the
syslogger
child sets MyBackendType =3D B_LOGGER in SubPostmasterMain(), before
process_shared_preload_libraries().  A message emitted from _PG_init() then
takes the direct write_syslogger_file() path, but the syslogger FILE handle=
s
are not reopened until later in SysLoggerMain().

So I think the bad assumption is that MyBackendType =3D=3D B_LOGGER means
write_syslogger_file() is ready to use.  A fix probably needs to make the
direct syslogger-file path conditional on the FILE handles being ready, and
that should cover stderr, CSV and JSON paths.

Regards,
Ayush

--000000000000052f6a0652a01c82
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,</div><br><div class=3D"gmail_quote gm=
ail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 25 May 2=
026 at 13:52, Michael Paquier &lt;<a href=3D"mailto:michael@paquier.xyz">mi=
chael@paquier.xyz</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex">On Mon, May 25, 2026 at 04:45:41PM +0900, Michael Paquier =
wrote:<br>
&gt; I did not take the cycles necessary for a bisect, but it looks like<br=
>
&gt; this has been around for a few months at least.=C2=A0 I have pinged<br=
>
&gt; f3c9e341cdf1 as a safe startup point for now, so that&#39;s a 2026 iss=
ue.<br>
<br>
Well, well:<br>
0c8e082fba8d36434552d3d7800abda54acafd57 is the first bad commit <br>
committer: =C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@kurilemu.de" =
target=3D"_blank">alvherre@kurilemu.de</a>&gt;<br>
date: Wed, 4 Feb 2026 16:56:57 +0100<br>
Assign &quot;backend&quot; type earlier during process start-up <br>
<br>
I have also checked manually a revert of this commit, and saw that the<br>
problem is gone, so it does not look like I have messed up my bisect.<br></=
blockquote><div><br></div><div>I was doing a Binary search to=C2=A0look for=
 commits around those paths.</div><div><br></div>I also checked 0c8e082fba8=
 directly: its parent starts clean with the</div><div class=3D"gmail_quote =
gmail_quote_container">same setup, while 0c8e082fba8 reports the NULL point=
er passed to fwrite().<br><br>So this looks to be caused by 0c8e082fba8.=C2=
=A0 After that commit, the syslogger=C2=A0</div><div class=3D"gmail_quote g=
mail_quote_container">child sets MyBackendType =3D B_LOGGER in SubPostmaste=
rMain(), before<br>process_shared_preload_libraries().=C2=A0 A message emit=
ted from _PG_init() then<br>takes the direct write_syslogger_file() path, b=
ut the syslogger FILE handles<br>are not reopened until later in SysLoggerM=
ain().<br><br>So I think the bad assumption is that MyBackendType =3D=3D B_=
LOGGER means<br>write_syslogger_file() is ready to use.=C2=A0 A fix probabl=
y needs to make the<br>direct syslogger-file path conditional on the FILE h=
andles being ready, and<br>that should cover stderr, CSV and JSON paths.<br=
><br>Regards,<br><div>Ayush=C2=A0</div></div></div>

--000000000000052f6a0652a01c82--