public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ayush Tiwari <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: [email protected]
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] postmaster: fix stale PM_STARTUP comment
Date: Tue, 21 Apr 2026 10:33:48 +0530
Message-ID: <CAJTYsWVyHuRn-uFgqozGqxSTkriPh-gByZGHzabsSjedcCfi-g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAJTYsWVoD3V9yhhqSae1_wqcnTdpFY-hDT7dPm5005ZFsL_bpA@mail.gmail.com>
	<[email protected]>
	<CAJTYsWVw3h1hTDyUdaDb8MmmXF0qQKzV3YkQUwC1DhvcApFvTw@mail.gmail.com>
	<CAJTYsWX=EkwTvA15=T8dE1c4iVoapTT5=nkrByd2h-18NU8hZA@mail.gmail.com>
	<[email protected]>
	<CAJTYsWUEm1h_k+4Wwnri+n+V8MGPSAeyU27ehH+YwiFjJwYRvA@mail.gmail.com>
	<[email protected]>

On Tue, 21 Apr 2026 at 06:30, Michael Paquier <[email protected]> wrote:

> On Mon, Apr 20, 2026 at 12:11:45PM +0530, Ayush Tiwari wrote:
>
> No need to.  I have poked at this problem a bit more, stracing my way
> as you did, and after more testing across v15~HEAD, I have applied it.
> For v15, a difference becomes necessary at HandleChildCrash(), or we
> would begin to fail the shutdown sequence should the startup process
> have the idea to PANIC.  This maps with the changes in v18 and HEAD
> where this has been replaced by a switch/case.
>
> Another thing that I have spent a long time looking at is
> process_pm_child_exit() and the interference that this could generate
> for the startup process case, but here as well I did not spot any
> issue, so I think that we are in the clear.
>
> There was also a comment at the top of postmaster.c that incorrectly
> claimed that the checkpointer and the background writer were only
> started after switch to PM_RECOVERY, which was wrong.  I have tweaked
> that while on it.
>
> That was a good catch overall.
>
>
Thanks a lot Michael for looking into it and pushing it!

Regards,
Ayush

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] postmaster: fix stale PM_STARTUP comment
  In-Reply-To: <CAJTYsWVyHuRn-uFgqozGqxSTkriPh-gByZGHzabsSjedcCfi-g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox