MIME-Version: 1.0
References: 
 <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
 <459ea164-aa38-43dd-8c93-dbb1063d20b5@eisentraut.org>
In-Reply-To: <459ea164-aa38-43dd-8c93-dbb1063d20b5@eisentraut.org>
From: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Date: Thu, 7 May 2026 14:34:05 +0530
Message-ID: 
 <CAJTYsWWGfGmdbKAet5jj326ik6zbKivtn9KBfFxB9uLNLuk6yA@mail.gmail.com>
Subject: Re: [PATCH] Clean up property graph error messages
To: Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000a47af50651369023"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJTYsWWGfGmdbKAet5jj326ik6zbKivtn9KBfFxB9uLNLuk6yA%40mail.gmail.com>
Precedence: bulk

--000000000000a47af50651369023
Content-Type: text/plain; charset="UTF-8"

Hi,


On Thu, 7 May 2026 at 14:15, Peter Eisentraut <peter@eisentraut.org> wrote:

>
> > and moves a
> > ReleaseSysCache() call before an ERROR ereport in
> > check_element_properties().
> >
> > The existing code should be cleaned up by
> > the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> > placed after ereport(ERROR) was unreachable.
>
> I think that's fine.  I don't think the change makes this better.
>

IIUC that is dead code right now, it never reaches that point to release?

Regards,
Ayush

--000000000000a47af50651369023
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi,<div><br></div></div><br><div class=3D=
"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">O=
n Thu, 7 May 2026 at 14:15, Peter Eisentraut &lt;<a href=3D"mailto:peter@ei=
sentraut.org">peter@eisentraut.org</a>&gt; wrote:</div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex">
<br>
&gt; and moves a<br>
&gt; ReleaseSysCache() call before an ERROR ereport in<br>
&gt; check_element_properties().<br>
&gt; <br>
&gt; The existing code should be cleaned up by<br>
&gt; the resource owner on the ERROR path, but the explicit ReleaseSysCache=
()<br>
&gt; placed after ereport(ERROR) was unreachable.<br>
<br>
I think that&#39;s fine.=C2=A0 I don&#39;t think the change makes this bett=
er.<br></blockquote><div><br></div><div>IIUC that is dead code right now, i=
t never reaches that point to release?<br><br>Regards,<br>Ayush=C2=A0</div>=
</div></div>

--000000000000a47af50651369023--