public inbox for [email protected]
help / color / mirror / Atom feedFrom: shiyu qin <[email protected]>
To: [email protected]
Subject: Correction to comment wording in tableam.c
Date: Mon, 5 Jan 2026 14:06:22 +0800
Message-ID: <CAJUCM3uJjoLR1zfKoZD4J71T-hdeFdFw1kTQoMkywKZP0hZsvw@mail.gmail.com> (raw)
Hi Hackers,
I found an issue in the comments of the tableam.c file.
In the comment that currently reads:
Note that most function in here are documented in tableam.h
I believe the wording is incorrect. The phrase "most function" is
used, but based on the actual context, it is intended to refer to
"most functions", not a single specific function.
Therefore, this sentence should be corrected to:
Note that most functions in here are documented in tableam.h
This change better reflects the intended meaning and improves the
accuracy of the comment.
Regards,
shiyu qin
Attachments:
[application/octet-stream] v1-0001-Correction-to-comment-wording-in-tableam.c.patch (1.1K, ../CAJUCM3uJjoLR1zfKoZD4J71T-hdeFdFw1kTQoMkywKZP0hZsvw@mail.gmail.com/2-v1-0001-Correction-to-comment-wording-in-tableam.c.patch)
download | inline diff:
From 5d0f1f4f88a3c3456ad6ade26942c723667c7f6d Mon Sep 17 00:00:00 2001
From: shiyu qin <[email protected]>
Date: Mon, 5 Jan 2026 13:53:36 +0800
Subject: [PATCH v1] Correction to comment wording in tableam.c
Note that 'function' here does not refer to a specific function;
it is intended to indicate that most functions are involved,
so it should be changed to 'functions'.
Author: shiyu qin<[email protected]>
---
src/backend/access/table/tableam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/table/tableam.c b/src/backend/access/table/tableam.c
index 0f7ce6a..8749179 100644
--- a/src/backend/access/table/tableam.c
+++ b/src/backend/access/table/tableam.c
@@ -11,7 +11,7 @@
* src/backend/access/table/tableam.c
*
* NOTES
- * Note that most function in here are documented in tableam.h, rather than
+ * Note that most functions in here are documented in tableam.h, rather than
* here. That's because there's a lot of inline functions in tableam.h and
* it'd be harder to understand if one constantly had to switch between files.
*
--
1.8.3.1
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Correction to comment wording in tableam.c
In-Reply-To: <CAJUCM3uJjoLR1zfKoZD4J71T-hdeFdFw1kTQoMkywKZP0hZsvw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox