Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gNEq1-0006TO-L1 for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Nov 2018 10:25:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gNEq0-0005Cn-2T for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Nov 2018 10:25:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gNEpz-0005CV-Pr for pgsql-hackers@lists.postgresql.org; Thu, 15 Nov 2018 10:25:27 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gNEpx-0004Dr-OE for pgsql-hackers@postgresql.org; Thu, 15 Nov 2018 10:25:27 +0000 Received: by mail-oi1-x241.google.com with SMTP id a77so10385623oii.5 for ; Thu, 15 Nov 2018 02:25:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9ul4qP0v+7ecN5SFuqEpVK4AcaQr7Qg0wMZB35dh1FA=; b=D3eFVtftYisW0lQWM1nrrjzigV8VYFqZ2AnWEvlVn9MABiFAKe/7Dr3Zjqh0tZULIk 55lrhQ/9vkPfVo+4SISDLW+Cz3iLg6mYlMTJKefIdDhHERFxhOycSvDbcXw8MxmGHBUr 8rLvQhj7dc62jS2Jxyv/oB6/S6dW241dJ6AeUAE/Ok3Zvkk94OOl9jgnVStG1EHRFIfc zQ8UTCKv43JQSxUKybMQYBaXEhZojxI3Go7EvHwQ+yKFGH33b8gGB5P6MuMnTbFoGFZw /o2l8sAjtD42Pejxqk2k3i1/3gHHsm7roQzQ2OLItvnqT/bO0N30MKjrLyA1BL9E150+ FZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9ul4qP0v+7ecN5SFuqEpVK4AcaQr7Qg0wMZB35dh1FA=; b=PZjgHHCvEo9d/+/QRYLFJzRLE7OXeqvjqfJDomr4bOLnnnDAnu2EhY2diHHZiF4NAf zslG2oGPnvIKhzJadsHzYchGdtl1vlqpiZke3Fr8ZBsl3AVhMxYyMZfMRrbGttzhuWvu +VIRO+Y6VGlVQnzkGRj9lr855en5NKuYBadDcgjh8KIfTKr9+T1S9QKIe44B82T2r+n3 OM1mL3+7LZIVVMDp1n49Uj1mD/DmnEnkYI1wHKgfGSgOu46fvv+JSHBxVglA3vQThqDT aRAI7gQq4+EPElNfEvdcrxVRzDyuOkNQHV2TnSVPrkQDImB4PG+9Gh7iQYCi6p0fuKFT DdIA== X-Gm-Message-State: AGRZ1gJE4EJZS/0mG6RmQV5F+TrtYIQjWZdpa77xLm288fNR5FFgQ/BS qmV9Vpl7cFOz5gOl/U49HQgKkRNIzKhjbop3CapGBw== X-Google-Smtp-Source: AJdET5eOZF368HL9kFqFNxUE4DRRzpcGTwBqQ94FkjyH/ppOUSKTK4iRjVuKFJRxn2zCfmiM1kzUWDhZCRfExUqBVgU= X-Received: by 2002:aca:4b4f:: with SMTP id y76mr3153516oia.88.1542277522859; Thu, 15 Nov 2018 02:25:22 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a8a:513:0:0:0:0:0 with HTTP; Thu, 15 Nov 2018 02:25:21 -0800 (PST) In-Reply-To: <20181115014807.kqhndjzbvdmkbkhv@alap3.anarazel.de> References: <20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de> <20181114080152.xkk6coduvfrh4ntr@alap3.anarazel.de> <20181115014807.kqhndjzbvdmkbkhv@alap3.anarazel.de> From: John Naylor Date: Thu, 15 Nov 2018 17:25:21 +0700 Message-ID: Subject: Re: [RFC] Removing "magic" oids To: Andres Freund Cc: pgsql-hackers@postgresql.org Content-Type: multipart/mixed; boundary="000000000000e5570c057ab177ec" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e5570c057ab177ec Content-Type: text/plain; charset="UTF-8" On 11/15/18, Andres Freund wrote: > I've now revised this slightly. genbki.pl now computes the maximum oid > explicitly assigned in .dat files, and assignes oids to all 'oid' > columns without a value. It does so starting directly at the maximum > value. I personally don't see need to have implicit .bki oids be in a > different range, and having them assigned more densely is good for some > things (e.g. the fmgr builtins table, even though we currently assign > all proc oids manually). I don't see an advantage to having a different range, but maybe it should error out if $maxoid reaches FirstBootstrapObjectId. This patch breaks reformat_dat_file.pl. I've attached a fix, which also de-lists oid as a special key within the *.dat files. It might be good to put off reformatting until feature freeze, so as not to break others' patches. -John Naylor --000000000000e5570c057ab177ec Content-Type: text/x-patch; charset="US-ASCII"; name="fix-reformat-dat-files.patch" Content-Disposition: attachment; filename="fix-reformat-dat-files.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 ZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2NhdGFsb2cvcmVmb3JtYXRfZGF0X2ZpbGUucGwgYi9z cmMvaW5jbHVkZS9jYXRhbG9nL3JlZm9ybWF0X2RhdF9maWxlLnBsCmluZGV4IGNhMjBmYjg2ZGEu LjE0ZTU2MWMxNjggMTAwNzU1Ci0tLSBhL3NyYy9pbmNsdWRlL2NhdGFsb2cvcmVmb3JtYXRfZGF0 X2ZpbGUucGwKKysrIGIvc3JjL2luY2x1ZGUvY2F0YWxvZy9yZWZvcm1hdF9kYXRfZmlsZS5wbApA QCAtMjgsOCArMjgsNyBAQCB1c2UgQ2F0YWxvZzsKIAogIyBOYW1lcyBvZiB0aGUgbWV0YWRhdGEg ZmllbGRzIG9mIGEgY2F0YWxvZyBlbnRyeS4gIChsaW5lX251bWJlciBpcyBhbHNvCiAjIGEgbWV0 YWRhdGEgZmllbGQsIGJ1dCB3ZSBuZXZlciB3cml0ZSBpdCBvdXQsIHNvIGl0J3Mgbm90IGxpc3Rl ZCBoZXJlLikKLW15IEBNRVRBREFUQSA9Ci0gICgnb2lkJywgJ29pZF9zeW1ib2wnLCAnYXJyYXlf dHlwZV9vaWQnLCAnZGVzY3InLCAnYXV0b2dlbmVyYXRlZCcpOworbXkgQE1FVEFEQVRBID0gKCdv aWRfc3ltYm9sJywgJ2FycmF5X3R5cGVfb2lkJywgJ2Rlc2NyJywgJ2F1dG9nZW5lcmF0ZWQnKTsK IAogbXkgQGlucHV0X2ZpbGVzOwogbXkgJG91dHB1dF9wYXRoID0gJyc7CkBAIC0xOTMsNyArMTky LDcgQEAgc3ViIHN0cmlwX2RlZmF1bHRfdmFsdWVzCiAJewogCQlteSAkYXR0bmFtZSA9ICRjb2x1 bW4tPntuYW1lfTsKIAkJZGllICJzdHJpcF9kZWZhdWx0X3ZhbHVlczogJGNhdG5hbWUuJGF0dG5h bWUgdW5kZWZpbmVkXG4iCi0JCSAgaWYgIWRlZmluZWQgJHJvdy0+eyRhdHRuYW1lfTsKKwkJICBp ZiAhZGVmaW5lZCAkcm93LT57JGF0dG5hbWV9IGFuZCAkYXR0bmFtZSBuZSAnb2lkJzsKIAogCQlp ZiAoZGVmaW5lZCAkY29sdW1uLT57ZGVmYXVsdH0KIAkJCWFuZCAoJHJvdy0+eyRhdHRuYW1lfSBl cSAkY29sdW1uLT57ZGVmYXVsdH0pKQo= --000000000000e5570c057ab177ec--