MIME-Version: 1.0
References: <CAHut+PuvsyA5v8y7rYoY9mkDQzUhwaESM05yCByTMaDoRh30tA@mail.gmail.com>
 <CAJpy0uC6bDq9FhjGP8DnvRgoem1n3Z3ketZKKBg8zi=BMng1DQ@mail.gmail.com> <CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com>
In-Reply-To: <CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com>
From: shveta malik <shveta.malik@gmail.com>
Date: Tue, 3 Sep 2024 11:42:32 +0530
Message-ID: <CAJpy0uANPf_XYdDKeWYcweJyemdsGJ0Z+mjJba_0W9mCuEpEkg@mail.gmail.com>
Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shveta.malik@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAJpy0uANPf_XYdDKeWYcweJyemdsGJ0Z%2BmjJba_0W9mCuEpEkg%40mail.gmail.com>
Precedence: bulk

On Tue, Sep 3, 2024 at 10:43=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.co=
m> wrote:
>
> > >
> > > To summarize, the current description wrongly describes the field as =
a
> > > time duration:
> > > "The time since the slot has become inactive."
> > >
> > > I suggest replacing it with:
> > > "The slot has been inactive since this time."
> > >
> >
> > +1 for the change. If I had read the document without knowing about
> > the patch, I too would have interpreted it as a duration.
> >
>
> The suggested change looks good to me as well. I'll wait for a day or
> two before pushing to see if anyone thinks otherwise.

Shall we make the change in code-comment as well:

typedef struct ReplicationSlot
{
...
        /* The time since the slot has become inactive */
        TimestampTz inactive_since;
}

thanks
Shveta