MIME-Version: 1.0
References: 
 <CAKFQuwY=WLF0OH8JE5T8S=aj0LBydiSn02fkRE73Sm_KSLRqJQ@mail.gmail.com>
 <78ff5cc9-268f-4be8-ae0b-c1a07dc24852@proxel.se>
 <CAKFQuwb3dG_tLFbWc_A_NMu-1b7xfGhPBa=dnAGptBT_CNBqLw@mail.gmail.com>
In-Reply-To: 
 <CAKFQuwb3dG_tLFbWc_A_NMu-1b7xfGhPBa=dnAGptBT_CNBqLw@mail.gmail.com>
From: shveta malik <shveta.malik@gmail.com>
Date: Wed, 8 Apr 2026 09:29:59 +0530
Message-ID: 
 <CAJpy0uAv36NnfLH=t+XUbwF+o1DYvF4P+cFbwh9R2DvmRW7nQg@mail.gmail.com>
Subject: Re: doc: Improve wal_level and effective_wal_level GUC around logical
 replication
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Andreas Karlsson <andreas@proxel.se>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 shveta malik <shveta.malik@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJpy0uAv36NnfLH%3Dt%2BXUbwF%2Bo1DYvF4P%2BcFbwh9R2DvmRW7nQg%40mail.gmail.com>
Precedence: bulk

Few comments:

1)
+        Running read-only queries on a standby server.

Looks incomplete and disconnected from previous sentence.

2)
+        level used by the system.  Namely, whether replica has been promoted to
+        logical (minimal never promotes).

We shall replace replica, logical, minimal with below
<literal>replica</literal>
<literal>logical</literal>
<literal>minimal</literal>

Also shall we add 'wal_level'? Otherwise, 'replica' on its own could
be understood as a replica server:

Namely, whether wal_level replica has been promoted to ....

3)
+        The <xref linkend="guc-effective-wal-level"/> parameter
reports the actual
+        level used by the system.  Namely, whether replica has been promoted to
+        logical (minimal never promotes).
+        This parameter can only be set at server start.

"This" here is misleading. Does this refer to wal_level or effective_wal_level?

4)
Below that is <literal>minimal</literal>,

Shall we change "that" to <literal>replica</literal> to avoid any confusion?

thanks
Shveta