MIME-Version: 1.0
References: 
 <CAHg+QDeuf9tCq3ce=kgFMJP0m=PZC+wi6B=yS+7V0vNXjLS31w@mail.gmail.com>
 <CAHGQGwFZaWj8DctXuhWQZwSqi631=NKzQJyDV4yqT1Qapt8MFQ@mail.gmail.com>
 <CALDaNm1Jjun=by60V-4EpLZe4pAKy0qVZ7ptyHGVCuDyKfo2xQ@mail.gmail.com>
 <CAHg+QDcu2x0mjkBSqRxP_8EQ6UmpuX_jMgdKLDkAL1=N6wzZCQ@mail.gmail.com>
 <CAJpy0uCmW_NUZN8mw26onvfoFzH_oMrFSKhLUhz896nDgf8c7Q@mail.gmail.com>
 <CAHg+QDcf_9prAX=TaSO3UUiCLVD53bEw-KLqzAEXi+ud7h+Z4w@mail.gmail.com>
 <CAJpy0uBShUF_xm0=BVWivpWHt-4zs__k_3wL1RRjpi0Av8nsog@mail.gmail.com>
 <CAHg+QDf5PVyFgesBNs1GvOnuk_khoXifo96A7QW1EJ8zhhBxyw@mail.gmail.com>
 <CAJpy0uCCqFLY7pu0RQVcS9fRr0FimFMuHPsMBQ-KzEGX3BEGPA@mail.gmail.com>
 <CAJpy0uDHMvpUAdwXA3X7ugmO8S7kry-ZtrKUcugpX3WWp8hykw@mail.gmail.com>
 <CAHg+QDdEGGQrmQXwH0_Y+DRe_tx5jxv9K+7vpCnooQn2_6QykA@mail.gmail.com>
 <CAJpy0uBo-OuzyZZ=LY8L48Udt8=1Mffh2rrpXaTbKK_F9sJx7A@mail.gmail.com>
 <CAHg+QDeKC=_31Fvs2pOVkJCdkpNuoJmLmXV5hOApStpODYWsXw@mail.gmail.com>
 <CAHGQGwEoENMBTu0=f2h5_GFfTc-dGEo+_CfS0jinPwTX2AcyYA@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwEoENMBTu0=f2h5_GFfTc-dGEo+_CfS0jinPwTX2AcyYA@mail.gmail.com>
From: shveta malik <shveta.malik@gmail.com>
Date: Wed, 27 May 2026 16:29:59 +0530
Message-ID: 
 <CAJpy0uB3sb2wfXaoYd8XnK53GcpTLW6BJLJve_K6JdNy8-dpgg@mail.gmail.com>
Subject: Re: [PATCH] Release replication slot on error in SQL-callable slot
 functions
To: Fujii Masao <masao.fujii@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 shveta malik <shvetamalik@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000001ed0730652ca8485"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJpy0uB3sb2wfXaoYd8XnK53GcpTLW6BJLJve_K6JdNy8-dpgg%40mail.gmail.com>
Precedence: bulk

--0000000000001ed0730652ca8485
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 27, 2026 at 1:42=E2=80=AFPM Fujii Masao <masao.fujii@gmail.com>=
 wrote:
>
> On Wed, May 27, 2026 at 1:31=E2=80=AFPM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> > Thank you for the changes and review.
>
> When I applied the v4 patch together with Shveta's diff patch and
> ran the regression tests, the tests failed.

That is because my top-up patch lacks slot.out changes, I wanted Satya
to first confirm if the changes are acceptable to him. Attached
another top-up patch for test-output correction.

> Could pg_create_physical_replication_slot() still have the same issue
> if it throws an error after ReplicationSlotCreate() and that error is
> caught by a PL/pgSQL EXCEPTION block?
>
> Also, do maybe pg_copy_physical_replication_slot(), pg_drop_replication_s=
lot(),
> and ALTER_REPLICATION_SLOT potentially have the same issue as well?
>

pg_copy_physical_replication_slot() should not have it as the common
'copy_replication_slot' is already fixed in the patch.  I will review
the others.

thanks
Shveta

--0000000000001ed0730652ca8485
Content-Type: text/plain; charset="US-ASCII";
 name="0001-test-result-changes.patch.txt"
Content-Disposition: attachment;
	filename="0001-test-result-changes.patch.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mpny9f770>
X-Attachment-Id: f_mpny9f770

RnJvbSBmY2NiMDQzODIxM2E4MmFmNTgyZjVkM2ExMWMwOWEwMDYwOTk5NTY1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTaHZldGEgTWFsaWsgPHNodmV0YS5tYWxpa0BnbWFpbC5jb20+
CkRhdGU6IFdlZCwgMjcgTWF5IDIwMjYgMTY6MjE6MDIgKzA1MzAKU3ViamVjdDogW1BBVENIXSB0
ZXN0IHJlc3VsdCBjaGFuZ2VzCgotLS0KIGNvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9z
bG90Lm91dCB8IDYgKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9z
bG90Lm91dCBiL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9zbG90Lm91dAppbmRleCBm
NGNiMjM0MDI4Yi4uM2EwNGQyZmJlNjcgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvdGVzdF9kZWNvZGlu
Zy9leHBlY3RlZC9zbG90Lm91dAorKysgYi9jb250cmliL3Rlc3RfZGVjb2RpbmcvZXhwZWN0ZWQv
c2xvdC5vdXQKQEAgLTQ4MSw2ICs0ODEsNyBAQCBFWENFUFRJT04gV0hFTiBPVEhFUlMgVEhFTgog
RU5EOwogJCQ7CiBOT1RJQ0U6ICBjYXVnaHQ6IGNvdWxkIG5vdCBhY2Nlc3MgZmlsZSAibm9uZXhp
c3RlbnRfcGx1Z2luX3h5eiI6IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3RvcnkKKy0tIHRoZSBjb25j
ZXJuZWQgc2xvdCBtdXN0IG5vdCBleGlzdCAoaXQgd2FzIGRyb3BwZWQgb24gZXJyb3IpCiBTRUxF
Q1QgY291bnQoKikgPSAwIEFTIHNsb3Rfd2FzX2Ryb3BwZWQgRlJPTSBwZ19yZXBsaWNhdGlvbl9z
bG90cwogICAgIFdIRVJFIHNsb3RfbmFtZSA9ICdyZWdyZXNzaW9uX3Nsb3RfZXJyb3InOwogIHNs
b3Rfd2FzX2Ryb3BwZWQgCkBAIC00ODgsNyArNDg5LDggQEAgU0VMRUNUIGNvdW50KCopID0gMCBB
UyBzbG90X3dhc19kcm9wcGVkIEZST00gcGdfcmVwbGljYXRpb25fc2xvdHMKICB0CiAoMSByb3cp
CiAKLVNFTEVDVCAnaW5pdCcgRlJPTSBwZ19jcmVhdGVfbG9naWNhbF9yZXBsaWNhdGlvbl9zbG90
KCdyZWdyZXNzaW9uX3Nsb3RfdDMnLCAndGVzdF9kZWNvZGluZycsIHRydWUpOworLS0gdGhlIHNl
c3Npb24gaXMgc3RpbGwgdXNhYmxlCitTRUxFQ1QgJ2luaXQnIEZST00gcGdfY3JlYXRlX2xvZ2lj
YWxfcmVwbGljYXRpb25fc2xvdCgncmVncmVzc2lvbl9zbG90X3QzJywgJ3Rlc3RfZGVjb2Rpbmcn
LCBmYWxzZSk7CiAgP2NvbHVtbj8gCiAtLS0tLS0tLS0tCiAgaW5pdApAQCAtNTEwLDcgKzUxMiw3
IEBAIEVYQ0VQVElPTiBXSEVOIE9USEVSUyBUSEVOCiBFTkQ7CiAkJDsKIE5PVElDRTogIGNhdWdo
dCBleHBlY3RlZCBlcnJvcgotLS0gdGhlIHNlc3Npb24gaXMgc3RpbGwgaGVhbHRoeQorLS0gdGhl
IHNlc3Npb24gaXMgc3RpbGwgdXNhYmxlCiBTRUxFQ1Qgc2xvdF9uYW1lIEZST00gcGdfcmVwbGlj
YXRpb25fc2xvdF9hZHZhbmNlKCdyZWdyZXNzaW9uX3Nsb3RfdDMnLCBwZ19jdXJyZW50X3dhbF9s
c24oKSk7CiAgICAgIHNsb3RfbmFtZSAgICAgIAogLS0tLS0tLS0tLS0tLS0tLS0tLS0KLS0gCjIu
MzQuMQoK
--0000000000001ed0730652ca8485--