Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wXck3-003NqH-0v for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jun 2026 10:34:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wXck2-00FfD1-0L for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jun 2026 10:34:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wXck1-00FfCs-2D for pgsql-hackers@lists.postgresql.org; Thu, 11 Jun 2026 10:34:29 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wXck0-00000002AGl-04bl for pgsql-hackers@lists.postgresql.org; Thu, 11 Jun 2026 10:34:28 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2c0c379e8ffso53645835ad.3 for ; Thu, 11 Jun 2026 03:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781174066; cv=none; d=google.com; s=arc-20240605; b=eL7+iMDpgAZ4JAmgfBopH81rm8Zk35YL7Jff0ewy7EvgnZrK9RoBYX9vlnDJRiQdgG MZJWraR1Y80pAsAJO6tUNWcyXe+HRMkv7p3Pj5MoGoDM6K8IyVFSXF6eVNKGO5cLUar3 pgoSB4NV1Mzcwwdj0SANvCtSh6DIcwr/xxF5UPzE+7RzpctznxM9dWbeCF4wHFam2KHk LJUOWvOCeC0Dh/kfBp2iWXh5W8o/hJe3DofcF8jLbvSBXPzgt4dkGQUXsD3dielPBLAa 8WTz5PsR53SRlNAPUy8haAF+a2hAYhnet0ref+zwBsU6ZlxpJbUoJ3WPaYWvnVlS3ioJ E7uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+HF54MrEFoUfhEA9e8y+okmMUJwnqJmmW7/SmWZgZGs=; fh=S8lPsuy6Ukv0A+vAvm9AEAoGtAfp9lZ9xQfvEfKxrQw=; b=k/F/82YwVpu66fslV7z4xIMQctutDQGMJxGDAL+X9Kn5yJIU3tmMjVX9s/xFdRJN7A cXYUR7CoLcG3pZIOFwHDCE34KLZT9+yL6UWt4fzFzbol5bmTFRR7dYIUMmi07b+Wjq/H kmh+HfAY/vrDgzzHaP9dWsIEMLIgR0NAasWdmCD9GrLGWN29c4JPuAXZSPWsFFI4Hk3G hx9RLWVbn5r5VgedNWfPtkVYDxFyKDOIVEPXijxeLqlT/m1ihQqyS0QjJJDzoD992xec w/lYZ4oDepdF94Bi8h2UKATw4lfsIqV9CpbEUyqFQyyp+Vwm29PBllgkAbOzUf+T7DSA at3w==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781174066; x=1781778866; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+HF54MrEFoUfhEA9e8y+okmMUJwnqJmmW7/SmWZgZGs=; b=K4SnibS0Chq5GYvDEGq5dbwNvyEROJLU4gFjY+40tvXksp/symDlGiZWFKdPYxxzm1 skQ4i6pssNtIjK4uB/TPbz5lQ9Qw0ApgFUAgMz7WoJ/UkbFlac/xIUgv5gCGe/VfHr07 nC9l/C8iY15EuEJUvE612f6Ih7T6uoeGkcRyXUEdJCfoPJNsxIXgOKLjKfPlrlCUUvGK jssMrrsf3HydA9Dg3U8rO/E9gdTMSCCNpHskOOnY6egyLA/ilVf3gh59LQCU8cdFkC4X SbNu4kfUcVpHDNtuTrhkn3BVkYCvtu303Ws62bn5GSz+1ZxG/Gh2nqQpGIVEsl1EjMfa mLHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781174066; x=1781778866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+HF54MrEFoUfhEA9e8y+okmMUJwnqJmmW7/SmWZgZGs=; b=KOCoETy/h1jC8/ew/uIP9OIDjC4i02yIueA6vxcyt5jA3C9bHlvO+6VEsY1dm4DeBV aYG1tVMCRMPh2iyX7F90Qy30FAKrQtzCRt8MGnSlcstBq8p/HVz24EDUm/oVMQxTEXxC vhEImWJHpo+sh5mKqFq6L0fxZFs8LauZdDxTk0z8FuVxdWyIvrEChNS9GF8x2YAvFUPm gCNml7o+u6V7AHqEnlYFXW7KfWRui+7+2LmbUW3PWEE/wZJlt7OeJcI4bzoTOr73F4wE RlcGpjcCxsDgLlX6EmaiEhOnfjTyXuCoko3KyH8PscodzkQmVqzECLi28izl5OgxCVQW MFSw== X-Forwarded-Encrypted: i=1; AFNElJ98IYvWryLJ3efiojA9wVsMxGzVAi8WrNANVoQBYN3pmc+OluFAYTWx8bcg1RXUPoJjjMPAMBEA3gyOIkx1@lists.postgresql.org X-Gm-Message-State: AOJu0YyZG0JmS7xYtkxDO4jA1+ETJSrqEloX1PWh8NlMqAK6BakzPQsv /YzLtRTfqHq0WuEdBFoAmX5GcWuPLkZB5LKN8L90OSxmwy8XjUp969UhsUmvmR+rah5WiR+YSqk 9FOO4VCcjWT3Q82HpI1UOUjpVznA0VSI= X-Gm-Gg: Acq92OEt/DljkiQo5jjPrZUDgy80Abszx06yaMwq+aTk0kHLdP+r30Nt+uJwLqibKUH 7bDb2xV5wKuOnjhIeF/lC+HE3u0kx+nPKNF/EavK2C3G1dBJTTuMM/G1iFhIV6fiBqZhK2IMRp8 NrafdoVAx97tQrVB07Y5qY/qSjkmljHTpaiVXoQiLfQRPobCvxw/FW2+TGdPdnoxu5hTauFoJj4 SVNu2KqkK3cuukCPtnHhANOrCbOz/uFpcUCkHS0QJItgIpw/mfLDSLZxqfmfRT9ggvL5acT3pvf 9bAEYIGAZVmNJdBFfLsiG+LAlhBD9TUBQBykRJa2BzU78bTszSwubfOtFxBO650A2Bt8n8ToQjM tGRuO2S6ylIzFAlPCTJ0a9Bnwncib/Vs= X-Received: by 2002:a17:903:2a88:b0:2ae:450c:951e with SMTP id d9443c01a7336-2c2f372f9edmr27538325ad.17.1781174066081; Thu, 11 Jun 2026 03:34:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: shveta malik Date: Thu, 11 Jun 2026 16:04:13 +0530 X-Gm-Features: AVVi8CewY-H1lfFDDroWZSUhxcStPCRhnIIxImSLl1Hudp8jjZD9y-r2zOBVggk Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: Amit Kapila , vignesh C , Nisha Moond , Peter Smith , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers , shveta malik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jun 11, 2026 at 10:44=E2=80=AFAM Dilip Kumar wrote: > > > Please find the rebased patch > 1. It includes the new 0005 patch for reporting errors for DDLs on clt. > > Open comments: > 1. Recent comments from Nisha and Shveta after v47 are still open > 2. Vignesh's patch for "describe related" changes needs a rebase. Can > you do that, Vignesh? Meanwhile, I will close all the open comments > and try to share a new version by EOD today. > Thanks. A few comments: 1) If I rename pg_conflict schema; apply worker handles it well as I do not see any issue, but pg_dump starts giving problem:. ./pg_dump -d postgres -p 5434 > sub.log pg_dump: error: query failed: ERROR: permission denied: "pg_conflict_log_16390" is a conflict log table DETAIL: Conflict log tables are managed by the system for logical replicat= ion. pg_dump: detail: Query was: LOCK TABLE public.tab1, conflict_new.pg_conflict_log_16390 IN ACCESS SHARE MODE Can dependency on name be removed even from pg_dump to avoid above issue? 2) + /* + * Conflict log tables are used internally for logical replication conflic= t + * logging and should not be modified directly, as it could disrupt + * conflict logging. + */ + if (IsConflictLogTableClass(classform)) + ereport(ERROR, + (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), + errmsg("permission denied: \"%s\" is a conflict log table", + rv->relname), + errdetail("Conflict log tables are managed by the system for logical replication."))); The comment is too generic. Suggestion: /* * Disallow extended statistics on conflict log tables. These are * internal, system-managed tables with no indexes, making * statistics useless for planning while adding unnecessary * catalog dependency overhead. */ 3) If we want to keep one generic DETAIL msg, shall it be changed to: Conflict log tables are system-managed tables for logical replication confl= icts. ~~ Will review more tomorrow. thanks Shveta