MIME-Version: 1.0
References: 
 <CAFPTHDZXX9WQ_X1ZfEvS248T+pKuk6SmCnXcvgPM059N1xPUfA@mail.gmail.com>
 <CAJpy0uDLUEjHHME8om1vAf6qkXCeRR6cBvkpK8yWBAC=T0ZFLA@mail.gmail.com>
 <CAFPTHDZg1JrunGgOj332hr+gUuH_Jm7skqPpYSvd-QE3yEdRDQ@mail.gmail.com>
 <CAJpy0uBz7MCSUkvFJD9ij65vBahNmY+bfCgdGKRqXovYs+K_TA@mail.gmail.com>
 <CAJpy0uDsuNqjWd-TmGBxqSS1rnVCJ3B8=SYrtxQ=Vs8kb71QFA@mail.gmail.com>
 <CAJpy0uAMWg3KcXtVBS7B0rnchLNrCCVYBByJCzAp=u5LERgtfA@mail.gmail.com>
 <CAFPTHDZwEhxhDAeqcPi0GuYN6xBs8gFXHOMUnbg3u2Xigcz4Zg@mail.gmail.com>
 <CAE9k0PmTyCU1A9YEf+MRgfeZ8yK1bAYJu=o0bH8DNUTzXejQyQ@mail.gmail.com>
 <CAA4eK1L6czEzG4mLNZSyjYC5nX0FMSjjk3csKuxPD3Ph5-7Yvw@mail.gmail.com>
 <CAJpy0uAhGQJ=msVsn2GsqWXr+YESJK6x9NBvrUtKvtvp1OVuKQ@mail.gmail.com>
 <CAJpy0uAOuu-M6wobH2wHOdTymm-cX9+MqwPyRNoOt=sPKBdCew@mail.gmail.com>
 <CAFPTHDZiWYXoKoo4VcBYNH9a=gxDZhfkcBeXt5w6cLw4_ysyKw@mail.gmail.com>
 <OS9PR01MB12149D9054CC7F2DC3F0D26A1F577A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <CAA4eK1KYxQALt46k5uWOO6SUtNjvjOaXwfNjH0AU656YrcGZEw@mail.gmail.com>
 <CAFPTHDZYonM+SXG19VVjgWduXQJSuDhcOUWq0NCiiuQubCSt6g@mail.gmail.com>
 <CAFPTHDYud1zr0VyizhyhEQXfHMgXVcHrPzE56WUKGCFNskQq2A@mail.gmail.com>
 <CAA4eK1JTau3fV7br6xwAV+LXXwM65RuGCuM2J3PQpCONtL1KXA@mail.gmail.com>
 <OS9PR01MB1691377CDB1468CDC9820BBEB9470A@OS9PR01MB16913.jpnprd01.prod.outlook.com>
 <TY4PR01MB1690715895CDE6FEFA13C2A2C947EA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
 <CAJpy0uA1txsV5RhjZjLBDrUjvxVyBDtMXzHr6=DzLHf7ybBrqg@mail.gmail.com>
 <TY4PR01MB1690739DE978BCBD12358478E947DA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
 <CAJpy0uAfu-VPqCknLLvJ+PUx_cyoR-b70xUNT6Pyv8N-odKizQ@mail.gmail.com>
 <CAJpy0uBeAdz6-3P26Eryeq3TyjA-GiKY3z0hFMxzZD=AYGqQ3Q@mail.gmail.com>
 <TY4PR01MB169072DEE7CC20E9B06F0164C947DA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <TY4PR01MB169072DEE7CC20E9B06F0164C947DA@TY4PR01MB16907.jpnprd01.prod.outlook.com>
From: shveta malik <shveta.malik@gmail.com>
Date: Fri, 6 Mar 2026 10:55:02 +0530
Message-ID: 
 <CAJpy0uC0T_tp62zxJN_2d_A=Ypvf14ebjGFepckeJugW5OHOyA@mail.gmail.com>
Subject: Re: [PATCH] Support automatic sequence replication
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Ajin Cherian <itsajin@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 Ashutosh Sharma <ashu.coek88@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 shveta malik <shveta.malik@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000247c7c064c5447b8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJpy0uC0T_tp62zxJN_2d_A%3DYpvf14ebjGFepckeJugW5OHOyA%40mail.gmail.com>
Precedence: bulk

--000000000000247c7c064c5447b8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 5, 2026 at 5:04=E2=80=AFPM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
>
> Thanks for catching this, I changed it to check the increment before repo=
rting warning.
>

Thanks! I have changed comments atop sequencesync.c to get rid of old
implementation details (worker dependency upon INIT state) and
rephrased a little bit. Please take it if you find it okay.  Attaching
patch as txt file. It is a top-up for 0001.

thanks
Shveta

--000000000000247c7c064c5447b8
Content-Type: text/plain; charset="US-ASCII";
	name="0001-header-comment-improvement.patch.txt"
Content-Disposition: attachment;
	filename="0001-header-comment-improvement.patch.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mmeg6urz0>
X-Attachment-Id: f_mmeg6urz0

RnJvbSAyMmE1NzViYzJhYjQzNzk1YzcyZjIyNDA0ODVjMTg5MjYyNjcyMDM1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTaHZldGEgTWFsaWsgPHNodmV0YS5tYWxpa0BnbWFpbC5jb20+
CkRhdGU6IEZyaSwgNiBNYXIgMjAyNiAxMDo0NTowMSArMDUzMApTdWJqZWN0OiBbUEFUQ0hdIGhl
YWRlciBjb21tZW50IGltcHJvdmVtZW50CgotLS0KIC4uLi9yZXBsaWNhdGlvbi9sb2dpY2FsL3Nl
cXVlbmNlc3luYy5jICAgICAgICB8IDQ5ICsrKysrKysrKy0tLS0tLS0tLS0KIDEgZmlsZSBjaGFu
Z2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMv
YmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3NlcXVlbmNlc3luYy5jIGIvc3JjL2JhY2tlbmQv
cmVwbGljYXRpb24vbG9naWNhbC9zZXF1ZW5jZXN5bmMuYwppbmRleCBjZGU5ZWFiYTQ3NC4uYTgw
ZDVlNWIzMzUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvc2Vx
dWVuY2VzeW5jLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9zZXF1ZW5j
ZXN5bmMuYwpAQCAtMTksMzcgKzE5LDMyIEBACiAgKiBDUkVBVEUgU1VCU0NSSVBUSU9OCiAgKiBB
TFRFUiBTVUJTQ1JJUFRJT04gLi4uIFJFRlJFU0ggUFVCTElDQVRJT04KICAqCi0gKiBUaGUgYXBw
bHkgd29ya2VyIHBlcmlvZGljYWxseSBzY2FucyBwZ19zdWJzY3JpcHRpb25fcmVsIGZvciBzZXF1
ZW5jZXMgaW4KLSAqIElOSVQgc3RhdGUuIFdoZW4gc3VjaCBzZXF1ZW5jZXMgYXJlIGZvdW5kLCBp
dCBzcGF3bnMgYSBzZXF1ZW5jZXN5bmMgd29ya2VyCi0gKiB0byBoYW5kbGUgc3luY2hyb25pemF0
aW9uLgotICoKLSAqIEEgc2luZ2xlIHNlcXVlbmNlc3luYyB3b3JrZXIgaXMgcmVzcG9uc2libGUg
Zm9yIHN5bmNocm9uaXppbmcgYWxsIHNlcXVlbmNlcy4KLSAqIEl0IGJlZ2lucyBieSByZXRyaWV2
aW5nIHRoZSBsaXN0IG9mIHNlcXVlbmNlcyB0aGF0IGFyZSBmbGFnZ2VkIGZvcgotICogc3luY2hy
b25pemF0aW9uLCBpLmUuLCB0aG9zZSBpbiB0aGUgSU5JVCBzdGF0ZS4gVGhlc2Ugc2VxdWVuY2Vz
IGFyZSB0aGVuCi0gKiBwcm9jZXNzZWQgaW4gYmF0Y2hlcywgYWxsb3dpbmcgbXVsdGlwbGUgZW50
cmllcyB0byBiZSBzeW5jaHJvbml6ZWQgd2l0aGluIGEKLSAqIHNpbmdsZSB0cmFuc2FjdGlvbi4g
VGhlIHdvcmtlciBmZXRjaGVzIHRoZSBjdXJyZW50IHNlcXVlbmNlIHZhbHVlcyBhbmQgcGFnZQot
ICogTFNOcyBmcm9tIHRoZSByZW1vdGUgcHVibGlzaGVyLCB1cGRhdGVzIHRoZSBjb3JyZXNwb25k
aW5nIHNlcXVlbmNlcyBvbiB0aGUKLSAqIGxvY2FsIHN1YnNjcmliZXIsIGFuZCBmaW5hbGx5IG1h
cmtzIGVhY2ggc2VxdWVuY2UgYXMgUkVBRFkgdXBvbiBzdWNjZXNzZnVsCisgKiBUaGUgYXBwbHkg
d29ya2VyIHBlcmlvZGljYWxseSBzY2FucyBwZ19zdWJzY3JpcHRpb25fcmVsIGZvciBzZXF1ZW5j
ZXMKKyAqIFdoZW4gc2VxdWVuY2VzIGFyZSBmb3VuZCwgaXQgc3Bhd25zIGEgc2VxdWVuY2VzeW5j
IHdvcmtlciB0byBoYW5kbGUKICAqIHN5bmNocm9uaXphdGlvbi4KICAqCi0gKiBUaGUgc2VxdWVu
Y2VzeW5jIHdvcmtlciB0aGVuIGZldGNoZXMgYWxsIHNlcXVlbmNlcyB0aGF0IGFyZQotICogaW4g
dGhlIFJFQURZIHN0YXRlLCBxdWVyaWVzIHRoZSBwdWJsaXNoZXIgZm9yIGN1cnJlbnQgc2VxdWVu
Y2UgdmFsdWVzLCBhbmQKLSAqIHVwZGF0ZXMgYW55IHNlcXVlbmNlcyB0aGF0IGhhdmUgZHJpZnRl
ZCBhbmQgdGhlbiBnb2VzIHRvIHNsZWVwLiBUaGUgc2xlZXAKLSAqIGludGVydmFsIHN0YXJ0cyBh
cyBTRVFTWU5DX01JTl9TTEVFUF9NUyBhbmQgZG91YmxlcyBhZnRlciBlYWNoIHdha2UgY3ljbGUK
LSAqICh1cCB0byBTRVFTWU5DX01BWF9TTEVFUF9NUykuIFdoZW4gZHJpZnQgaXMgZGV0ZWN0ZWQs
IHRoZSBpbnRlcnZhbCByZXNldHMgdG8KLSAqIHRoZSBtaW5pbXVtIHRvIGVuc3VyZSB0aW1lbHkg
dXBkYXRlcy4KLSAqCi0gKiBBZnRlciBDUkVBVEUgU1VCU0NSSVBUSU9OLCBzZXF1ZW5jZXMgYmVn
aW4gaW4gdGhlIElOSVQgc3RhdGUuIFNlcXVlbmNlcwotICogYWRkZWQgdGhyb3VnaCBBTFRFUiBT
VUJTQ1JJUFRJT04uLiBSRUZSRVNIIFBVQkxJQ0FUSU9OIGFsc28gc3RhcnQgaW4gdGhlIElOSVQK
LSAqIHN0YXRlLiBBbGwgSU5JVCBzZXF1ZW5jZXMgYXJlIHN5bmNocm9uaXplZCB1bmNvbmRpdGlv
bmFsbHksIHRoZW4gdHJhbnNpdGlvbgotICogdG8gdGhlIFJFQURZIHN0YXRlLiBPbmNlIGluIHRo
ZSBSRUFEWSBzdGF0ZSwgc2VxdWVuY2VzIGFyZSBjaGVja2VkIGZvciBkcmlmdAotICogZnJvbSB0
aGUgcHVibGlzaGVyIGFuZCBzeW5jaHJvbml6ZWQgb25seSB3aGVuIGRyaWZ0IGlzIGRldGVjdGVk
LgorICogQSBzaW5nbGUgc2VxdWVuY2VzeW5jIHdvcmtlciBpcyByZXNwb25zaWJsZSBmb3Igc3lu
Y2hyb25pemluZyBhbGwgc2VxdWVuY2VzCisgKiBmb3IgYSBzdWJzY3JpcHRpb24uIEl0IGJlZ2lu
cyBieSByZXRyaWV2aW5nIHRoZSBsaXN0IG9mIHNlcXVlbmNlcy4gVGhlc2UKKyAqIHNlcXVlbmNl
cyBhcmUgdGhlbiBwcm9jZXNzZWQgaW4gYmF0Y2hlcywgYWxsb3dpbmcgbXVsdGlwbGUgZW50cmll
cyB0byBiZQorICogc3luY2hyb25pemVkIHdpdGhpbiBhIHNpbmdsZSB0cmFuc2FjdGlvbi4gVGhl
IHdvcmtlciBmZXRjaGVzIHRoZSBjdXJyZW50CisgKiBzZXF1ZW5jZSB2YWx1ZXMgYW5kIHBhZ2Ug
TFNOcyBmcm9tIHRoZSByZW1vdGUgcHVibGlzaGVyIGFuZCB1cGRhdGVzIHRoZQorICogY29ycmVz
cG9uZGluZyBzZXF1ZW5jZXMgb24gdGhlIGxvY2FsIHN1YnNjcmliZXIuIFNlcXVlbmNlcyBpbiB0
aGUgSU5JVAorICogc3RhdGUgYXJlIHVuY29uZGl0aW9uYWxseSB1cGRhdGVkIHRvIHRoZSBsYXRl
c3QgdmFsdWVzIGZyb20gdGhlIHB1Ymxpc2hlcgorICogYW5kIHRoZW4gbW92ZWQgdG8gdGhlIFJF
QURZIHN0YXRlLiBGb3Igc2VxdWVuY2VzIGFscmVhZHkgaW4gdGhlIFJFQURZCisgKiBzdGF0ZSwg
dGhlIHdvcmtlciBjaGVja3MgZm9yIGRyaWZ0IGFuZCB1cGRhdGVzIHRoZW0gb25seSB3aGVuIG5l
ZWRlZC4KICAqCiAgKiBTZXF1ZW5jZSBzdGF0ZSB0cmFuc2l0aW9ucyBmb2xsb3cgdGhpcyBwYXR0
ZXJuOgotICogIElOSVQgLS0+IFJFQURZIC0+LSsKLSAqICAgICAgICAgICAgIF4gICAgICB8IChj
aGVjay9zeW5jaHJvbml6ZSkKLSAqICAgICAgICAgICAgIHwgICAgICB8Ci0gKiAgICAgICAgICAg
ICArLS08LS0tKworCisgKiAgICAgICAoc3luY2hyb25pemUpCisgKiAgSU5JVCAtLS0tLS0tLS0t
LS0tLT4gUkVBRFkgLT4tKworICogICAgICAgICAgICAgICAgICAgICAgICAgXiAgICAgIHwgKGNo
ZWNrLWRyaWZ0L3N5bmNocm9uaXplKQorICogICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAg
IHwKKyAqICAgICAgICAgICAgICAgICAgICAgICAgICstLTwtLS0rCisgKgorICogQmV0d2VlbiBj
eWNsZXMsIHRoZSB3b3JrZXIgc2xlZXBzIGZvciBTRVFTWU5DX01JTl9TTEVFUF9NUy4gSWYgbm8g
ZHJpZnQgaXMKKyAqIG9ic2VydmVkIGluIGFueSBzZXF1ZW5jZSwgdGhlIHNsZWVwIGludGVydmFs
IGRvdWJsZXMgYWZ0ZXIgZWFjaCB3YWtlIGN5Y2xlCisgKiB1cCB0byBTRVFTWU5DX01BWF9TTEVF
UF9NUy4gV2hlbiBkcmlmdCBpcyBkZXRlY3RlZCwgdGhlIGludGVydmFsIHJlc2V0cyB0bworICog
dGhlIG1pbmltdW0gdG8gZW5zdXJlIHRpbWVseSB1cGRhdGVzLgogICoKICAqIFRvIGF2b2lkIGNy
ZWF0aW5nIHRvbyBtYW55IHRyYW5zYWN0aW9ucywgdXAgdG8gTUFYX1NFUVVFTkNFU19TWU5DX1BF
Ul9CQVRDSAogICogc2VxdWVuY2VzIGFyZSBzeW5jaHJvbml6ZWQgcGVyIHRyYW5zYWN0aW9uLiBU
aGUgbG9ja3Mgb24gdGhlIHNlcXVlbmNlCi0tIAoyLjM0LjEKCg==
--000000000000247c7c064c5447b8--