MIME-Version: 1.0
References: 
 <CANhcyEVSXyQkvmrsOWPdQqnm2J3GMyQQrKhyCJiBQzqs6AvSow@mail.gmail.com>
 <CALDaNm125dv88fUDgBPBM-N-hXbF0NLqKe-ymEpMRNymUYRQAA@mail.gmail.com>
 <CANhcyEUxgzaNJNNO_-12wYwGLihpuKmsMH2g4TFnRPx5AQVZmg@mail.gmail.com>
 <CAJpy0uBB4N8KOrHchdgprVi2Ws1+gTcEr+bC2A_ziAHOcZcTqA@mail.gmail.com>
 <CAJpy0uCAJQvBjD7qNWWGnZP_LDwS8AiUJC7YMict9UcYqH=XeQ@mail.gmail.com>
 <CANhcyEU_Yq9ZJ2n5Sqa7RoHze0TD0RGxLQQgV1F6Jm2AROEh8g@mail.gmail.com>
 <CANhcyEWj-ECj=WC+HD_kv27Dn6FkTngFQCVJVTVZfJnjCTKMBQ@mail.gmail.com>
 <CANhcyEW03XO5tLb7opt1yQGHWJ7Ew=L65EWcdrKH=F0mUpuR3A@mail.gmail.com>
 <CAHut+Ptu0Bkwnr5eetdmFhJC7SsEtKjNe_cTwOg5wF65fjyV8w@mail.gmail.com>
 <CANhcyEU+4Z6NXMEk6OmctFv=_pY8K5AiazkfVmn7zxhwQO6CEQ@mail.gmail.com>
 <CAHut+PvOWjKJfNorGO8whnaAtqZb-4zN8u6aOajCw3hn-tMwyA@mail.gmail.com>
 <CANhcyEV_Sv+xQzsjo6hbowDbGV5J7RhFWuQQxWeUWPNPd0k1=w@mail.gmail.com>
 <CAHut+Pt6O3YD8h61RCtzMrRwgvS=RDRNf4KuXAUn1WYnoFU_uQ@mail.gmail.com>
 <CANhcyEU=Vi2oNRWTSph3x2884J7aTt5BTb4AzwmmY0uQAsEMMg@mail.gmail.com>
 <CAHut+Pv9ru8tNLz1LaPjuG-1X5dsLd36cFbb11e=bhYrHz60CQ@mail.gmail.com>
 <CANhcyEVDStqoR3qDSgsv5VEuBMzMX4YpdEfW-7VPX3c5Vf1YJA@mail.gmail.com>
 <CAHut+PsFNboBR8E+NRY_3hMqdpbj3y3jX1+vQTow2khgj4t=qw@mail.gmail.com>
 <CANhcyEW+aJ1rAAodQZDvCd-WpQ+b8r5wBs8H+mNdQS8URmkODg@mail.gmail.com>
 <CAHut+PvXpsFrNn2NOhepVOS7Zf_OvX-m71Wu+m-o_q9odYFXnA@mail.gmail.com>
 <CANhcyEWfzDRCiny6A_swAD7WUgdb37-TA4xTAUQ3JJXK9UPBZQ@mail.gmail.com>
 <CAJpy0uCLhrwK_s3VbEjO+qD7amdxuYgNxi8OX4VLdb5pZkorwQ@mail.gmail.com>
 <CANhcyEVzkYgMu0ah7kUmPgk6n14xsFZL8XvhiJXNsCW9oRjdGg@mail.gmail.com>
 <CAHut+PsgCQa2hcT8TNqejV3y4U5ouj=ZCOLMxgVGvBrUEkLaKg@mail.gmail.com>
In-Reply-To: 
 <CAHut+PsgCQa2hcT8TNqejV3y4U5ouj=ZCOLMxgVGvBrUEkLaKg@mail.gmail.com>
From: shveta malik <shveta.malik@gmail.com>
Date: Fri, 26 Jun 2026 14:23:04 +0530
Message-ID: 
 <CAJpy0uCV-L8DP+AfZq2Rj1xEjyzwZW-ugfmmXMPpotiyNTHG_A@mail.gmail.com>
Subject: Re: Support EXCEPT for ALL SEQUENCES publications
To: Shlok Kyal <shlok.kyal.oss@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Peter Smith <smithpb2250@gmail.com>,
	shveta malik <shveta.malik@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJpy0uCV-L8DP%2BAfZq2Rj1xEjyzwZW-ugfmmXMPpotiyNTHG_A%40mail.gmail.com>
Precedence: bulk

Please find a few trivial comments on v13-001:

1)

check_publication_add_relation:

+ * 'pubrelkind' is the relkind accepted by the publication clause,
+ * while 'targetrelkind' is the relkind of the relation being added.

pubrelkind is the argument while targetrelkind is not. We generally
explain arguements here.

Can we rephrase to:
 * 'pubrelkind' is the relkind accepted by the publication clause.
 * The relkind of relation in given 'pri' is checked for compatibility
 * against it. Error is emitted if they are not compatible.

2)
describePublications:

  }
- else
+ if (puballtables)
  {

Now since else is converted to independent 'if' block we can add a
blank line before it for better readability.

Same for this:

  }
+ if (puballsequences)
+ {


3)

We have each test header like below starting from begining of file:

---------------------------------------------
-- Tests for inherited tables, and
-- EXCEPT clause tests for inherited tables
---------------------------------------------

---------------------------------------------
-- EXCEPT clause tests for partitioned tables
---------------------------------------------

So we can convert ours too in above format so that it is more visible:
+-- Test ALL SEQUENCES with EXCEPT clause

4)
We can add these tests to sql file:

a) SEQ keyword equivalent test to below table one:

-- fail - first table in the EXCEPT list should use TABLE keyword
CREATE PUBLICATION testpub_foralltables_excepttable2 FOR ALL TABLES
EXCEPT (testpub_tbl1, testpub_tbl2);

b) Try to add either of temporay or unlogged seq to except list.

thanks
Shveta