Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wS5a8-002wec-17 for pgsql-hackers@arkaria.postgresql.org; Wed, 27 May 2026 04:09:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wS5a5-0072IY-0J for pgsql-hackers@arkaria.postgresql.org; Wed, 27 May 2026 04:09:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wS5a4-0072IQ-20 for pgsql-hackers@lists.postgresql.org; Wed, 27 May 2026 04:09:21 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wS5a3-00000000xb9-41MN for pgsql-hackers@lists.postgresql.org; Wed, 27 May 2026 04:09:20 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-393da8f389bso95477901fa.1 for ; Tue, 26 May 2026 21:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779854957; cv=none; d=google.com; s=arc-20240605; b=LPS8mQt98B7/0r8RtRmnSv38Tei9V1cgZSGgJl8FKjrWEKs4aIDySdcMAGxd1k5MAL 9LYuWKmgtsk0HdmQ8b4fHpfhHfY4GpK/vddPrskcvsTxgycZqaGhDFNu0+6Y9DFsRqPw wT1IcTeI8IWDUvWZOc9Oh6zz/4bVIX1p3UCjo9B2JQXgPlluM/Z/YrJrimm7ks02JoXx GiFeoM6His3eN1hH/Hj+Wc0Q904e6wEwlxmJbfF8Kmy47ekQc8VXikFG6KbEephd2sQW VQjiuFjSz6dWpO1nrp+O5qAp4D5gEtDeakSGj9g6CYF1QqVoMUjwOoRbN/TNq+gmMXaJ W/Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=OZt53X5suBQhNsmtKZQJ3G4le85HvaTuPOfex5uP4oE=; fh=WsH8HuO3emxwI0zoWArNnNru1EUK2qvZgn3xgPOXU3M=; b=Jkzl2eC74ql/liPki+Xiwxv43qEBitsdGhBIa3nTJg9+EOD6GEhpH8NNS4tCscgu/Z 7inqAE4OgzUMl7Ano4FkTPe7FRaulkuMvqJtw5mt+dRX2kD/pYOErGmrA8pdL4y4nUcl qekZ7gV77LNhMzPWCOWITBNqxStQF9C86aWYKVj0/irXTQReADFBarAYU5bzibkacNK9 ccaa5LPnWrdABNIT4HSCl7IHXnpJtC88sDJTD+9gsj1TdBKz2pPnF7alnJGuIXfRG8Qh nrgwvB21AODSDdXw+TXuAndE3XhUqrQJPPYFFJtJNFwJqgRf0IrMbymfogL+YM4nhKFQ cqyg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779854957; x=1780459757; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OZt53X5suBQhNsmtKZQJ3G4le85HvaTuPOfex5uP4oE=; b=oVcLbqCn9ipZYEyUuPrqpipekGP8+q5oU3XmI4nfM0KcJSR5fkbVszFV19wd01xhDi G2cca4ohEFqBmPOm9/Cy66UzJatq97/0sBo+/vrYjOipk0npcUn4+hcxgIBThwOy/Ght 8ZPeZt6aGVFkkTuRHr4Yymcp+27UNh81ug04aem1dYyq/7EfDjSyBZZYtD1rQyLU/2Uh /MLFqfJNZnK26iqcFtBqynQ/EdtoDS3iQSNVSqMVSQGnRurwFgcGuPEbo+QabcNErVdx +6WaJ5kFg18drMG+DVAged7R8AdWJrNl6nsosM5APmdgtBydsKPyHftatz45O3SmCCyu Anzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779854957; x=1780459757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OZt53X5suBQhNsmtKZQJ3G4le85HvaTuPOfex5uP4oE=; b=nQlQHgR6BEou9slMZ4GpeiYU8L+3xeXw9dQQXRwfjB4SdzvZRALO9VoO1Vd+w/nBLA iv9jdhLhxPSemsuWFWJX/0QlYl+g3ldGGIMDxSfwd+oFkigZ4EgVEreZF1tPywUzb53V Hv+rKKYql2cMTFMiDslbk3Z9eJbexgCWL1jzLkw1hwK7AuSsR1HggYNc+VOIqG5ulbUx if/6e9m3vGeCCA+4DYGEh7JqZRo+b+uVKqDghMPMDxSIdp3VuPdTzRYAeSn8/XchtDpg TSfcMUXt4IPV5gIWTTkz7ey93VhXaHntcKyGgYlrZlmZfi2ct8+5Dkl6tQNdlM4AtAyS P7Uw== X-Forwarded-Encrypted: i=1; AFNElJ+5u6NZSvvFI/Pgm3oQThiPGIx02DzNAYNm5Al1GYhCJNrydRlMTvE4rV1t5SS88NTmsg3pdqCDpKVR1GXD@lists.postgresql.org X-Gm-Message-State: AOJu0Yx0NHVkHKYFyNvbTWkItu9HqQd6PecEhdbk5AMzTsueXSb3Fn2G vev0eH3sgrCDt9pq3t24o3p9BJgIygCj0dCb3Q9l49ih4Bh7BpJ+cNqAzdUD7/5bRi2XACDwofJ jK1/Eje9AeBaIVizmFYwrFX9vlI5snyQ= X-Gm-Gg: Acq92OE4RP/R+M9bTHFp7l6LfjfY2Q+Sj+AXIvtvAjOxbzVwSfSw0HizPFiHkhIAKU4 pv+zx5d5iQQ3EcI4V+aUholg4VpguBUd2RPWKt/CP/x1die+ZkOBrFeCVN4yIvPvVip46a9uw8E rEeovLOQyc2kVqb8f/M3gXecOOPmEongU+Le/iJ7qb0WOilo0d9Xe+NntfocRxpk+WSxF14t1BM zTGECbU15SxsnrMXBAL3SMuMIQFdzFmtQUQvMWnnSZFULeDhW4Wo9gbw4tgZjzv8q8cCHn68hIo yJ4Y8vU4HeIE13PRWRE70lCh3DWwFMf/NvWnDmoYpMcAVOgGi590LUT+QV1awN8= X-Received: by 2002:a2e:be14:0:b0:38e:83a6:d4c with SMTP id 38308e7fff4ca-395d8bcdb6amr73067301fa.7.1779854956850; Tue, 26 May 2026 21:09:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: shveta malik Date: Wed, 27 May 2026 09:39:01 +0530 X-Gm-Features: AVHnY4I_xbNc-m10Fhiz1Yx4xYwJc5IxXOAVcmmflZZGaEb0BFSibpDjgxPcKkw Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Peter Smith Cc: vignesh C , Nisha Moond , Dilip Kumar , Amit Kapila , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers , shveta malik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 27, 2026 at 4:20=E2=80=AFAM Peter Smith = wrote: > > On Tue, May 26, 2026 at 7:38=E2=80=AFPM shveta malik wrote: > ... > > 1) > > heap_create: > > + errdetail("Conflict schema modifications are currently disallowed."))= ); > > LookupCreationNamespace: > > + errmsg("cannot move objects into or out of the pg_conflict schema")))= ; > > > > Can we make it same through-out, either we use 'Conflict schema' at > > both the places or pg_conflict schema. Since in these 2 functions, in > > previous messages, we are using names like 'System catalog', 'TOAST > > schema' etc, I think we can use Conflict schema at both the places. > > What do others think on this? > > > > The suggested name of "Conflict schema" LGTM. My only concern was that > a user may not know where that is referring to. OTOH, things like > "System catalog" have 100s of mentions and whole documentation > chapters dedicated to them. If we go with "Conflict schema", then the > documentation needs to also consistently use that term, describe what > it is for, and make it very easy to look up and discover that > "Conflict schema" is 'pg_conflict'. I agree that if we use 'Conflict schema' in the error messages, we need to refer it the same way in doc. Let's wait for others' opinions on this too. > > Currently (in patches 0008/9) there is very little explanation even > about what pg_conflict is, apart from just observing in passing that > the CLT gets written to that "dedicated namespace". It seems a bit > backwards describing the parent schema by the contents: Instead of > saying when there is a CLT it gets written there, IMO it should be the > other way around, and say there is a "Conflict schema" which is where > the CLTs (if any) reside. Yes, the suggestion makes sense. I will look at the doc patch again for thi= s. thanks Shveta