Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1weoa0-0052MW-0x for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Jul 2026 06:37:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1weoZz-00C3yU-0o for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Jul 2026 06:37:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1weoWu-00C0zx-2z for pgsql-hackers@lists.postgresql.org; Wed, 01 Jul 2026 06:34:41 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1weoWt-000000012M2-0Rgv for pgsql-hackers@lists.postgresql.org; Wed, 01 Jul 2026 06:34:40 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-c8b49639fbaso135761a12.0 for ; Tue, 30 Jun 2026 23:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782887678; cv=none; d=google.com; s=arc-20260327; b=jK30eLeRbGGeX7szihAEjVWs6vjSYkmsCkLIrJv2qtWpBwMI/BKlbWmlzfHpCDwzpn fRIGKzU1VrWgC7KzfrzHhm+kVDnV4SoREBwQuk11qdzIBySJP13uX/0zug85SxZ3vo+t xJj3d85HlpFayhsSZM0bgDD+qXL9tXvc9aTAuxkOIAM0l7j7TuHIB8VsSOEteEbuSPGo Y6X3eQWMVPYtWhaGjcMey5yMGh7NDPyvuxo+StsQTKuWQB9u/tobIHomNV1H28gZfgmF KvMHPnpfBcWRuPmnBXa03GlsxJqds41d++0ABvILUbntcDahYyqJ39kNHS/+nNGBe3xq R2SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=eLWT5l6zDdwX/pIDz0+3V0zkaX7mizg/lWw249lc8FM=; fh=+sNJJ8kVjdTgYwkdXnXS9PABsHEFvpJrrEwF+N2f08o=; b=rEwvQ1uemP2Ghbn6zeDXIbLPGV2jwtSAjY2DXOLAGjepTKNyyMJKtmo7g+p8re16CV 1vxzRNuwCsSc+DWWY9rTy2EMd+pqJwSvhXtpRKSc6I9jOl4EVssrTPxQJNrwIcp3TLLD E8nzHV/CvkS4jOXKj9PKtuk1nb7PiDT/R3SzpKlNDBQZOKVvI38LlwTwleWCQgyvh1Tb us3loB1l2S4ioySKA1rQexBTvwP5uDpJCdsrnDAo+FOq3Q+LlB4nmr4ruhhN/ydTev14 fcZzBBqGDCr7Goa1b6EbnL8LqYfaKaLoDSrph8s2Spt2ZCMNjHGVI9ODM7rOIqq3CAm6 UzcA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782887678; x=1783492478; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eLWT5l6zDdwX/pIDz0+3V0zkaX7mizg/lWw249lc8FM=; b=ZYK1lxKcbJgS3s0qG0RVKlAqgM+1GmyX9aw3JrR9H3UfCLZu55LPy6lJjD4g+2ajWm OLQst5xmycIiBZtnZRRTHLRg4OVu0nhJSoJBmOHnfDAYQgev5qrDHBaScMNdbd8T4z8L uUrzdWIHMlY2WRONEFsYoGqHnnYVIE9Wqf9VPc4EtKI12TotxTlZycQ8ZhKhpL75UqMz ooAlLDmNIAJ0Z1XBzFQcX3rVBOCXRTmejIWjQMt4Nrr43Z0/rXRB0smRTSRxZcO4X1Pp s4x5hdrXtj43WzUP6+SHeoWOvXVuyyy5iCoBmnF0h/A5L4PGrcbzigv5Hhnzyyepzpqw Vp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782887678; x=1783492478; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eLWT5l6zDdwX/pIDz0+3V0zkaX7mizg/lWw249lc8FM=; b=hlWQtXOBHQYjsBafuXz79YVe/GOVLqsd3vep4VD7zCXD/d+zqzL+Wy5Xl4FPn3oEU6 W/d3rOhmh3Qyjf6YRf6ejqNW4uPZWXhpDev0IElysscGeNPWwKXgoReSe0ZgnSznetCR /mcMST+C135zQRB1l1Re6JBcemnbwfwRIIyqRxDfMN3pdb+mupdz2PdXOc6A6dNz1XCW 2wBaRN3y/gLeR6kkBSjtsdHiZHM6dvLeE+KAVHD6njxGGoGysvnDzxeuwHN+siYiFypb 1TF10mWmNN7JE6soKerliKY0QDhNC3Kqtw3EqS7/zqCcvMcwqmH/CIK+iOzXdSG1+TuW WiXw== X-Forwarded-Encrypted: i=1; AHgh+Rrmi3AWwSL4cKhKIn9v9flcXJ78VweS9DK3ylnc5fCMyH6VmNqKaHy1L0/6IeynuTBhjBAoNjeyKfF/Vc5K@lists.postgresql.org X-Gm-Message-State: AOJu0YxiN7QGk5ih7qX0duw72fOl2A4wa/9iWDWDFd0aoGnyc/oozC/B aMwI7su7SR20xXdZffrUrpLelQ0qrtZSLlxFp6VqXe4oUG0IxKARK/NaiLwM3j3sR0K90GQg2Tb +UsiYLChOllu2wdQn6x/XcXYVWbjsZog= X-Gm-Gg: AfdE7cn0TDC+UL37djJkec6jlHx3u+QO49g01CHL/YdlK/UV2rAelCxR7UB+gu4HZ0W vySI29FihvmDwKVN0DiD3zMh4lHH/GhU9P/L4GoQb0ZBW92fWhWOpLsrAEKJIIZUQMMKVKOzbqZ kHWM8M/SbHGPVVQEYyDWEOl/yVrZbWiIwZ6922GJjenC7YeUIqPNkoJOqZeIWRBy1kNlaRAKcom nBDw3Nef4twqtCchOy4hZ46bmgv+ruR8qUo9bEU2UiktRov8WGaNMDe8q2znp85g86H1DGT/fWE 0yenmoGF4f9kGLNvpqkQW33s1tZWX4cmqmFLrXRG/aJMh+ZRonduuA== X-Received: by 2002:a05:6300:4049:b0:3b3:f46:1eea with SMTP id adf61e73a8af0-3bfed1bffc2mr423937637.7.1782887678109; Tue, 30 Jun 2026 23:34:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: shveta malik Date: Wed, 1 Jul 2026 12:04:25 +0530 X-Gm-Features: AVVi8CdU3VTKHqszlTbyaRFNCRztei09peFLgX44JY40L7hs5Tu0Jpmpckd4cpU Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: Amit Kapila , Peter Smith , vignesh C , Nisha Moond , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers , shveta malik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jun 30, 2026 at 5:20=E2=80=AFPM Dilip Kumar = wrote: > > > I have merged these patches and also merged 0001 and 0002. Also fixed > other open comments from Nisha, Shlok, and Peter > These are not needed: +++ b/src/include/replication/conflict.h +#include "catalog/pg_type.h" +++ b/src/backend/commands/lockcmds.c +#include "catalog/catalog.h" Plus we can have relevant docs added to this patch. I do not have any further comments on 001. thanks Shveta