Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLWqT-002RxG-0G for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Nov 2025 01:18:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vLWqR-009geJ-27 for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Nov 2025 01:18:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLWqR-009geB-1F for pgsql-hackers@lists.postgresql.org; Wed, 19 Nov 2025 01:18:51 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vLWqP-000H6G-2j for pgsql-hackers@lists.postgresql.org; Wed, 19 Nov 2025 01:18:51 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-b763b4238fcso919266b.0 for ; Tue, 18 Nov 2025 17:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763515127; x=1764119927; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1DIEhb8URroyrtsH6XOaaucDroMSPWZMnx3kz1tWJjs=; b=MPbRCa50PX8NePps8W0wrbG4IhrIqwFsRtep/QbDwKjBc/+feOHVE2Q6Iqwj4fsGk0 4VarjNfu6h510W3fxroa3OCuKOSFuD77ZXT+vnwuBgmpmiG8h2UeSQkd++axPfqSPYqz N7QBQFb36DabA4LFSGWSRrzzmpqV+lsA2EubAKP3um+1/ThpvAXh1e/e6Lke4O7X6lKy cjM7+ftD5BbqaDW27g5g9Ve+h9p35j0weNZoOLNfJxzzlNcUQafMPdOOcDqqa43tSQ6/ q8e2Km8/Sat3zP+mlomh4U1zyINJJG8Il33iTp/VJFO2eZP0tWJviXGn6Uw4WoVkzm4T 6l9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763515127; x=1764119927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1DIEhb8URroyrtsH6XOaaucDroMSPWZMnx3kz1tWJjs=; b=JtftIoIlkoRcySteJ+Yd5o3j8hQ4RDqIwr+DgF3b08yG5gmeCtiwoasbUYAKfYQYok PqweoslpthWPQyWlm1D6nbSocn4pTnKrEKPZmQxm0LWENv4LLuj5pN5o/9S/ZaGq4kPE 0nTmfjBzWVEjMYQX0qxi+vKC/Y94FFDDijpU0RTjCaABaGrc0/BE7KpuBrrOFDv8zGYI d297Hb3T05iSaDPtZ6pW6ecykEXZ5WU/cepxBogb8xlytNs5weagzfn/Y+A/MmTyt7uI EoBtSMUfQxbsUi/aZvC4Te1d2t75gE8nGeCBnhlgpdDQ9UyTg4IvZZdnc2sasQCKq6f+ c0Iw== X-Gm-Message-State: AOJu0Yw2rv9/k1BRO3MYRfG07hS4zC4w+tsZieqtmpd5Uqo9dgxhqNk/ wa/RPRbScbtB1i/xGQbtWXR/mUu2SOJt3Km3guN/VVSqOkOiqw8NPulZ/SJbt42xG3m5weczu/0 bs8Yj7/k3j523FU4yamMXcMNr/AIbyFM= X-Gm-Gg: ASbGncux/KjOY5+mpDj49xu2i4h81IYiKfFFPMkr6qOytPlt6nnIzBsXJ5pEpT2rota WAu+xiz4acxZCW3twcMb2Js3UAte6i1Q3JreZNOqCShzFzDd7kzGW8aHaj97MR8VYGOCGE5M3Js rtKeOMo4s+17pTIue+QHcfb54bFbObelK5/DOb6z+Gk045tSa6WPxxjYWqi9esfLPfQdeOQlKg4 +lO366uSVy1AwO3ROxiewMpbVRIFM5Q1djqb/T7/QlLwZrthxc0nGm5zTOE0UkoWw1HPdlU+qFw 0QAt X-Google-Smtp-Source: AGHT+IHvKhVp8GBwgMnLZs1BfVfUr87Q349VZe8aR3/XkbkraqZl3b7tExzE81n0wyS6C8KJQE9bY9Kpmm/rF8cJBmk= X-Received: by 2002:a05:6402:13ca:b0:63c:3b80:17c3 with SMTP id 4fb4d7f45d1cf-6450052e743mr2419555a12.5.1763515126805; Tue, 18 Nov 2025 17:18:46 -0800 (PST) MIME-Version: 1.0 References: <20250911054220.3784-1-root@ip-172-31-36-228.ec2.internal> In-Reply-To: From: Andrew Kim Date: Tue, 18 Nov 2025 17:18:36 -0800 X-Gm-Features: AWmQ_bkSTSvHVg5r7u-3oYWWS7YoDYskXclWL8v_1A2aoIqDGxvDq0CVhFAs3Xs Message-ID: Subject: Re: Proposal for enabling auto-vectorization for checksum calculations To: John Naylor Cc: pgsql-hackers@lists.postgresql.org, Oleg Tselebrovskiy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Nov 17, 2025 at 8:48=E2=80=AFPM John Naylor wrote: > > On Tue, Nov 18, 2025 at 10:32=E2=80=AFAM Andrew Kim wrote: > > > I've double-checked everything after applying the v9 checksum patches > > and updating pg_filedump accordingly. > > Following your suggestion, I removed the checksum_impl.h include and > > the Assert redefinition, keeping only the port/checksum.h include. > > build compiles cleanly with the new architecture, and pg_filedump > > functions correctly with the AVX2 optimizations. > > If you agree with this approach, I'd like to prepare a patch for > > upstream submission. > > Thanks, but there is no action required now. I mentioned some > observations, and I'm going to experiment a bit further. > > Also, it's way too early to be suggesting changes to other projects, > since we haven't committed anything yet. Even things committed can > occasionally be reverted before beta 1 anyway. It makes sense, I fully understand. I will standby and wait for your next update. -Andrew Kim > -- > John Naylor > Amazon Web Services