Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uyghV-00BObf-IV for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Sep 2025 01:11:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uyghT-003koN-9i for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Sep 2025 01:11:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uyghS-003knu-WC for pgsql-hackers@lists.postgresql.org; Wed, 17 Sep 2025 01:11:11 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uyghQ-001Dq4-0S for pgsql-hackers@lists.postgresql.org; Wed, 17 Sep 2025 01:11:11 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-61a54560c1fso1256150a12.0 for ; Tue, 16 Sep 2025 18:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758071467; x=1758676267; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=rxgd9YgB66hKjiBXbYRnRmBzTHm/FCTayUnclaEKZcA=; b=cpdrKgHChYpb1UtgGBG+Mg6QGO5tL7vnt+aJ8LUx+iJVSt+jbYifwtosVrVEk3XLPO B4PKI7kwHYnNMBYo3FQEeK3UhBCJEj7Phzm7JTCDBn4DWD3GBUsI8ZERrOMW7XgLpLMl tWd9+mO1NanGfDjF8cLRGqzLIL6zYy021SP1iuQrlrkOiGi3wHu7KcmIiKBvsjDnfPbM JX5UUQwRn46V9JNYsxrPoUtpw3dF5pPj6ZFkkIb8MoYECDmPXdFNcBOzJrAFsPZFrk0g eYzjf+WwtG9BYvsDYPGUr9RhNQW7bVheXQHF653XoiJ2ENJPHR1AQq7N5McIeQ2i3Yfm Oh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758071467; x=1758676267; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rxgd9YgB66hKjiBXbYRnRmBzTHm/FCTayUnclaEKZcA=; b=IlSyhzopC0k4QhUU0SPN+5hOvtNIJwuWnVIE3Dr+1sMM+yGAj3UKSjxEd4AqsEISav L9DivOE4QmC0hCQn4irHqgTnymsiErgifLE++LYR21KmANhSvsrM64Me13qqNRAYWNT6 z/ltm9z0Q3aEPKvhJalDEuDWmEoyH54Ta7I66AGxC2ib/Zg78ExMUYgRaV1/jPr+tGge bsC47l4DTslYbSezZTM1JM1kHIK649guR2q6QsW6TmISwjXNAsTe3LWGufyawGHdoKTt k76Votur+kAjZisIM2rk5d2dx0FWou/z/Y0Oau5QQciIt5zY5G7+Nj0oGIRftR7nFtGK pMUQ== X-Gm-Message-State: AOJu0Yz5PBUyjbDu/gtK+FH0TOTENcT85qTxswFBE/EMItVE52dae4Yw kW0jwMfe1Et7D5h2XcHY69MSS/KBHefSxYDYN4qQpzQjChHqobMWfIoWzuPxDk3CjFXKWfpQ3VQ Ow/orOWSx0LhqbN3WjqPGp3az8pJbB65saJ/R X-Gm-Gg: ASbGncu9dighU5hv+Ptf0NrIHHw8vIRFOMhvDWFnRXZvk7jILpt7YQU0FU3NtOVUB6T bDagA5ZnGHI215HqvgSZ0oLOAqZd3cltMNGcckoPbz8wUXLmwtmjEdm9SQi8qR2a0tSXMCir1Fd dJBFJu6kOVqmm8+IKtffn7lhijFsOQYBpPylJr8gVEw2vJfOSn3owll+TUTfqnQEOyInZS6/nUp uAnJwmkNbCNonGs7Tk= X-Google-Smtp-Source: AGHT+IE6bkv+Z0o4OWsrLNeWLRUXky7ARG/av4mBgT9ULYnZlJz+MahXJbuVZooGSR2rtnTPAwj0ZZOg+pAewhaE1RA= X-Received: by 2002:a05:6402:4310:b0:61c:e9a3:b15a with SMTP id 4fb4d7f45d1cf-62f8443401emr319776a12.5.1758071467392; Tue, 16 Sep 2025 18:11:07 -0700 (PDT) MIME-Version: 1.0 From: Andrew Kim Date: Tue, 16 Sep 2025 18:10:56 -0700 X-Gm-Features: AS18NWAIwRCbXBiF9l1U8IJmniXHifM1EST3yW48TtSXI5eeDLtcmD-EogIJ6EE Message-ID: Subject: Re: Proposal for enabling auto-vectorization for checksum calculations To: pgsql-hackers@lists.postgresql.org Cc: johncnaylorls@gmail.com, Matthew Sterrett , byavuz81@gmail.com, slpmcf@gmail.com, raghuveer.devulapalli@intel.com, akash.shankaran@intel.com, Andrew Kim , Andrew Kim , eshe.n.pickett@intel.com Content-Type: multipart/alternative; boundary="0000000000004dc1a4063ef4e90c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000004dc1a4063ef4e90c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > I don't know if this is related to the crashes, but it doesn't seem > like a good idea to #include the function pointer stuff everywhere, > that should probably go into src/port like the others. Just a gentle reminder on this patch series =E2=80=94 I=E2=80=99ve already = rebased it on the latest tip of master and addressed the earlier review comments: * Moved the function pointer definitions into src/port as suggested. * Rebased cleanly on the current master branch. Could someone take another look and share any further feedback? Thanks a lot for your time and review, Andrew Kim --0000000000004dc1a4063ef4e90c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> I don't know if this is related to the crashes, b= ut it doesn't seem
> like a good idea to #include the function po= inter stuff everywhere,
> that should probably go into src/port like = the others.
Just a gentle reminder on this patch series =E2=80=94 I=E2= =80=99ve already rebased it on
the latest tip of master and addressed th= e earlier review comments:

=C2=A0 * Moved the function pointer defin= itions into src/port as suggested.
=C2=A0 * Rebased cleanly on the curre= nt master branch.

Could someone take another look and share any furt= her feedback?

Thanks a lot for your time and review,
Andrew Kim --0000000000004dc1a4063ef4e90c--