MIME-Version: 1.0
References: 
 <CAJTYsWUzok2+mvSYkbVUwq_SWWg-GdHqCuYumN82AU97SjwjCA@mail.gmail.com>
 <CAJTYsWVK6rw++WU94=gFk5ZR5ZXhT3BYOFxhm6tT9xOGG-drnA@mail.gmail.com>
 <CAE8JnxMXxJBs+U5HKkOfLd66vQHZ14XREHcEh-7_p-osaccFmQ@mail.gmail.com>
 <57388743-e380-4145-8b77-86ed23b062de@vondra.me>
In-Reply-To: <57388743-e380-4145-8b77-86ed23b062de@vondra.me>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Mon, 9 Mar 2026 09:34:46 -0400
Message-ID: 
 <CAKAnmm+gW9J4hr38g0uSUsswAVq+=bUYSSXp9tZrMegLyWieOg@mail.gmail.com>
Subject: Re: tid_blockno() and tid_offset() accessor functions
To: Tomas Vondra <tomas@vondra.me>
Cc: Alexandre Felipe <o.alexandre.felipe@gmail.com>,
	Ayush Tiwari <ayushtiwari.slg01@gmail.com>, pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000085fd60064c977957"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmm%2BgW9J4hr38g0uSUsswAVq%2B%3DbUYSSXp9tZrMegLyWieOg%40mail.gmail.com>
Precedence: bulk

--00000000000085fd60064c977957
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 8, 2026 at 3:31=E2=80=AFPM Tomas Vondra <tomas@vondra.me> wrote=
:

> No opinion. For displaying the bogus TID value (like "(-1,0)") it's
> probably OK to show values that are a bit weird. If anything, we should
> be more careful on input, it's too late for tid_block() to decide what to
> do with an "impossible" TID value.
>

This one doesn't sit right with me. I think it's not too late. No reason
why tid_block cannot be stricter here than tid itself and complain. Other
than that, the patch looks good to me.


Cheers,
Greg

--00000000000085fd60064c977957
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sun, Mar 8, 2026 at 3:31=E2=80=AFPM To=
mas Vondra &lt;<a href=3D"mailto:tomas@vondra.me">tomas@vondra.me</a>&gt; w=
rote:=C2=A0</div><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">No opinion. For displaying the bog=
us TID value (like &quot;(-1,0)&quot;) it&#39;s probably OK to show values =
that are a bit weird. If anything, we should<br>
be more careful on input, it&#39;s too late for tid_block() to decide what =
to do with an &quot;impossible&quot; TID value.<br></blockquote><div><br></=
div><div>This one doesn&#39;t sit right with me. I think it&#39;s not too l=
ate. No reason why tid_block cannot be stricter here than tid itself and co=
mplain. Other than that, the patch looks good to me.</div><div><br></div><d=
iv><br></div><div>Cheers,</div></div><div dir=3D"ltr" class=3D"gmail_signat=
ure"><div dir=3D"ltr"><div>Greg</div><div><br></div></div></div></div>

--00000000000085fd60064c977957--