MIME-Version: 1.0
References: <aIyNxBWFCybgBZBS@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAKAnmm+USTr5MeKuyrAvbCjHqbSFbZ+czJsV7fPYt9nECQkf-A@mail.gmail.com>
 <aJsKKZqwM4GIPTcK@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <aJsKKZqwM4GIPTcK@ip-10-97-1-34.eu-west-3.compute.internal>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Tue, 12 Aug 2025 08:54:07 -0400
Message-ID: 
 <CAKAnmmJ+WW8=28dvQGvPvGh1APh0FxDbdTkdahoatN35y2cgxw@mail.gmail.com>
Subject: Re: Adding locks statistics
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000003fb53a063c2a8b97"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmmJ%2BWW8%3D28dvQGvPvGh1APh0FxDbdTkdahoatN35y2cgxw%40mail.gmail.com>
Precedence: bulk

--0000000000003fb53a063c2a8b97
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 12, 2025 at 5:32=E2=80=AFAM Bertrand Drouvot <
bertranddrouvot.pg@gmail.com> wrote:

> I considered pg_stat_locks, but chose the singular form to be consistent
> with
> pg_stat_database, pg_stat_subscription, and friends.
>

Counter-examples: pg_stat_statements, pg_stat_subscription_stats. Our names
are not consistent. :) It just feels a better fit to have a plural name for
a table tracking aggregates of multiple types of objects.

(Ignore my git complaint, was obviously half-asleep when I wrote that).

> Docs: seem good. Needs a section on how to reset via
> > SELECT pg_stat_reset_shared('lock');
>

I meant something closer to the actual description of the view.  Having it
buried in the pg_stat_reset_shared section is not intuitive for people
looking up the view in the docs.


> Because it looks like that they are ordered by alphabetical order.
>

That makes sense.


> - I'm not sure that's worth for this particular case and code paths.
>

Will let others opine on that.

Thanks! Did you observe some noticeable performance penalties?
>

No, but I did not give it any particularly heavy testing. More of a idle
thought when pulling up a brand new system and seeing the thousands of
locks for the tiniest bit of database action.

Cheers,
Greg

--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support

--0000000000003fb53a063c2a8b97
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Aug 12, 2025 at 5:32=E2=80=AFAM B=
ertrand Drouvot &lt;<a href=3D"mailto:bertranddrouvot.pg@gmail.com">bertran=
ddrouvot.pg@gmail.com</a>&gt; wrote:</div><div class=3D"gmail_quote gmail_q=
uote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I conside=
red pg_stat_locks, but chose the singular form to be consistent with<br>
pg_stat_database, pg_stat_subscription, and friends.<br></blockquote><div><=
br></div><div>Counter-examples: pg_stat_statements, pg_stat_subscription_st=
ats. Our names are not consistent. :) It just feels a better fit to have a =
plural name for a table tracking aggregates=C2=A0of multiple types of objec=
ts.</div><div><br></div><div>(Ignore my git complaint, was obviously half-a=
sleep when I wrote that).</div><div><br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex">
&gt; Docs: seem good. Needs a section on how to reset via<br>
&gt; SELECT pg_stat_reset_shared(&#39;lock&#39;);<br></blockquote><div><br>=
</div><div>I meant something closer to the actual description of the view.=
=C2=A0 Having it buried in the pg_stat_reset_shared section is not intuitiv=
e for people looking up the view in the docs.</div><div>=C2=A0</div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex">
Because it looks like that they are ordered by alphabetical order.<br></blo=
ckquote><div><br></div><div>That makes sense.</div><div>=C2=A0</div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex">- I&#39;m not sure that&#39;s wo=
rth for this particular case and code paths.<br></blockquote><div><br></div=
><div>Will let others opine on that.</div><div><br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Thanks! Did you observe some noticeable pe=
rformance penalties?<br></blockquote><div><br></div><div>No, but I did not =
give it any particularly heavy testing. More of a idle thought when pulling=
 up a brand new system and seeing the thousands of locks for the tiniest bi=
t of database action.</div><div>=C2=A0</div><div>Cheers,</div><div>Greg</di=
v><div><br></div></div><div dir=3D"ltr" class=3D"gmail_signature"><div dir=
=3D"ltr"><div>--</div><div>Crunchy Data - <a href=3D"https://www.crunchydat=
a.com" target=3D"_blank">https://www.crunchydata.com</a></div><div>Enterpri=
se Postgres Software Products &amp; Tech Support</div><div><br></div></div>=
</div></div>

--0000000000003fb53a063c2a8b97--