MIME-Version: 1.0
References: <fe99e0ca-e564-480e-b865-5f0cee30bc60@tantorlabs.com>
 <c7ce658a-e0eb-4c5f-92a8-511314d89bbb@tantorlabs.com> <6707FCA9-FD1A-4609-A1A6-142456C14E0C@yandex-team.ru>
 <CAKAnmmLD8C-Y6CVF74Ccup8h9YpzBYzSvWWRG_Qf8+5YEMh4-g@mail.gmail.com> <Zz0MFPq1s4WFxxpL@paquier.xyz>
In-Reply-To: <Zz0MFPq1s4WFxxpL@paquier.xyz>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Wed, 20 Nov 2024 10:59:12 -0500
Message-ID: <CAKAnmmJ9dbO0Zka_UaMuAynHShagqTwisfnx+SDiwRbRjOK-cA@mail.gmail.com>
Subject: Re: Sample rate added to pg_stat_statements
To: Michael Paquier <michael@paquier.xyz>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000003b9c4a06275a3d88"
Archived-At: <https://www.postgresql.org/message-id/CAKAnmmJ9dbO0Zka_UaMuAynHShagqTwisfnx%2BSDiwRbRjOK-cA%40mail.gmail.com>
Precedence: bulk

--0000000000003b9c4a06275a3d88
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 19, 2024 at 5:07=E2=80=AFPM Michael Paquier <michael@paquier.xy=
z> wrote:

> One piece of it would be to see how much of such "bottlenecks" we
> would be able to get rid of by integrating pg_stat_statements into
> the central pgstats with the custom APIs, without pushing the module
> into core.


Any particular reason these days we cannot push this into core and allow
disabling on startup? To say this extension is widely used would be an
understatement.

Cheers,
Greg

--0000000000003b9c4a06275a3d88
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Nov 19, 2024 at 5:07=E2=80=AFPM M=
ichael Paquier &lt;<a href=3D"mailto:michael@paquier.xyz">michael@paquier.x=
yz</a>&gt; wrote:</div><div class=3D"gmail_quote"><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex">One piece of it would be to see how much of such &=
quot;bottlenecks&quot; we<br>
would be able to get rid of by integrating pg_stat_statements into <br>
the central pgstats with the custom APIs, without pushing the module<br>
into core.</blockquote><div><br></div><div>Any particular reason these days=
 we cannot push this into core and allow disabling on startup? To say this =
extension is widely used would be an understatement.</div><div><br></div><d=
iv>Cheers,</div><div>Greg</div><div><br></div></div></div>

--0000000000003b9c4a06275a3d88--