MIME-Version: 1.0
References: 
 <CAAXajwDOvTwLQ=rO5hOKsR_VTikST1rN-moO46YhYEgsO00dqg@mail.gmail.com>
 <2DCDBFFC-4B03-4EBC-88A3-06AD29933F17@yandex-team.ru>
 <CAAXajwD5pT+BtQqLTn=6DDs8NAWgqm4S6esSn0Zr3Ev1kVbYPg@mail.gmail.com>
 <CAKNkYnzAOcMr4j-ku=+jr29EssA=Ct3NX99rr=+HcRVeQD_Yyw@mail.gmail.com>
In-Reply-To: 
 <CAKNkYnzAOcMr4j-ku=+jr29EssA=Ct3NX99rr=+HcRVeQD_Yyw@mail.gmail.com>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Thu, 2 Apr 2026 08:34:23 -0400
Message-ID: 
 <CAKAnmmJs-N7u2aRXPo5cqm9jXjmKqSNQcTrPs9dOm=cuT0hS1w@mail.gmail.com>
Subject: Re: [PATCH] Add prepared_orphaned_transaction_timeout GUC
To: zaartur@gmail.com
Cc: Nikhil Chawla <chawlanikhil24@gmail.com>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
	pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000f96b90064e796de6"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmmJs-N7u2aRXPo5cqm9jXjmKqSNQcTrPs9dOm%3DcuT0hS1w%40mail.gmail.com>
Precedence: bulk

--000000000000f96b90064e796de6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 30, 2026 at 6:44=E2=80=AFAM Artur Zakirov <zaartur@gmail.com> w=
rote:

> It seems we don't have ways to enforce this rule, and a user doesn't need
> to have advanced privileges to run PREPARE TRANSACTION. Correct me if I'm
> wrong. What if instead of adding a GUC we would add a new role, only this
> role (and superuser) will be able to run PREPARE TRANSACTION.
>

Well, it is certainly a better solution than a global timeout. But there
are a ton of other ways that a user can mess things up. 2PC is very
powerful, and very hard to get implement. It is disabled by default for
good reason. Someone enabling it needs to have all their ducks in a row,
and should have their own ways to monitor, and handle, errant transactions.
So a strong -1 from me on the timeout, and a weak -1 on a GUC/permission
solution (which could get hashed out more, perhaps).

Cheers,
Greg

--000000000000f96b90064e796de6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Mar 30, 2026 at 6:44=E2=80=AFAM A=
rtur Zakirov &lt;<a href=3D"mailto:zaartur@gmail.com">zaartur@gmail.com</a>=
&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">It seems we don&#39;t have ways to=
 enforce this rule, and a user doesn&#39;t need to have advanced privileges=
 to run PREPARE TRANSACTION. Correct me if I&#39;m wrong. What if instead o=
f adding a GUC we would add a new role, only this role (and superuser) will=
 be able to run PREPARE TRANSACTION.<br></blockquote><div><br></div><div>We=
ll, it is certainly a better solution than a global timeout. But there are =
a ton of other ways that a user can mess things up. 2PC is very powerful, a=
nd very hard to get implement. It is disabled by default for good reason. S=
omeone enabling it needs to have all their ducks in a row, and should have =
their own ways to monitor, and handle, errant transactions. So a strong -1 =
from me on the timeout, and a weak -1 on a GUC/permission solution (which c=
ould get hashed out more, perhaps).</div><div><br></div><div>Cheers,</div><=
/div><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>Greg<=
/div><div><br></div></div></div></div>

--000000000000f96b90064e796de6--