MIME-Version: 1.0
References: 
 <4f20d57b2aeb447b8eb1495319940c5f@G08CNEXMBPEKD06.g08.fujitsu.local>
 <CALj2ACUHruScDf2dvnVso03bhSdr7MVvLie5C8ND1dR+hJrFEg@mail.gmail.com>
 <8499D41B-628A-4CE0-9139-00D718F9D06B@amazon.com>
 <CA+TgmoYKBMdizs7-NBrhLHJXCv4dAAmBKHvER0PDmV+rBCy7KA@mail.gmail.com>
 <20210802203724.ujmzgwukenm2en3j@alap3.anarazel.de>
 <CA+TgmoaaF46+A_Y-DTxDJpPGcqKxJU=ZPzFisqqouRL_WxYBSQ@mail.gmail.com>
 <9B2E85FE-14BC-407A-93B7-4EE2F84BEF05@amazon.com>
 <CAKAnmm+o5-ROvnghC-79=1Jr4bqJxmyu98Qax=KSukdL6JZm0g@mail.gmail.com>
 <77F481D5-2F4C-405E-9335-E68550375D4B@amazon.com>
In-Reply-To: <77F481D5-2F4C-405E-9335-E68550375D4B@amazon.com>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Wed, 11 Aug 2021 09:41:43 -0400
Message-ID: 
 <CAKAnmmJsHnNc65aLQErabTdcF=B+bMfSnLNUezC7nnsMb8bCDg@mail.gmail.com>
Subject: Re: make MaxBackends available in _PG_init
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000008fe87a05c948c902"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmmJsHnNc65aLQErabTdcF%3DB%2BbMfSnLNUezC7nnsMb8bCDg%40mail.gmail.com>
Precedence: bulk

--0000000000008fe87a05c948c902
Content-Type: text/plain; charset="UTF-8"

On Mon, Aug 9, 2021 at 8:22 PM Bossart, Nathan <bossartn@amazon.com> wrote:

> > Is this going to get tripped by a call from restore_backend_variables?
>
> I ran 'make check-world' with EXEC_BACKEND with no problems, so I
> don't think so.
>

v3 looks good, but I'm still not sure how to test the bit mentioned above.
I'm not familiar with this part of the code (SubPostmasterMain etc.), but
running make check-world with EXEC_BACKEND does not seem to execute that
code, as I added exit(1) to restore_backend_variables() and the tests still
ran fine. Further digging shows that even though the #ifdef EXEC_BACKEND
path is triggered, no --fork argument was being passed. Is there something
else one needs to provide to force that --fork (see line 189 of
src/backend/main/main.c) when testing?

Cheers,
Greg

--0000000000008fe87a05c948c902
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Aug 9, 2021 at 8:22 PM Bossart, N=
athan &lt;<a href=3D"mailto:bossartn@amazon.com">bossartn@amazon.com</a>&gt=
; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex">&gt; Is this going to get tripped by a call from restor=
e_backend_variables?<br>
<br>
I ran &#39;make check-world&#39; with EXEC_BACKEND with no problems, so I<b=
r>
don&#39;t think so.<br></blockquote><div><br></div><div>v3 looks good, but =
I&#39;m still not sure how to test the bit mentioned above. I&#39;m not fam=
iliar with this part of the code (SubPostmasterMain etc.), but running make=
 check-world with EXEC_BACKEND does not seem to execute that code, as I add=
ed exit(1) to restore_backend_variables() and the tests still ran fine. Fur=
ther digging shows that even though the #ifdef EXEC_BACKEND path is trigger=
ed, no --fork argument was being passed. Is there something else one needs =
to provide to force that --fork (see line 189 of src/backend/main/main.c) w=
hen testing?</div><div><br></div><div>Cheers,</div><div>Greg</div><div><br>=
</div><div><br></div></div></div>

--0000000000008fe87a05c948c902--