MIME-Version: 1.0
References: <CAKAnmmJz8Hh=8Ru8jgzySPWmLBhnv4=oc_0KRiz-UORJ0Dex+w@mail.gmail.com>
 <CAHM0NXiD15-23=r1B9rHzKhS8e0+zwp_a6PncdLNetyF0xpNpA@mail.gmail.com>
 <c180a366-fecc-4f3a-9c40-79eec526f70c@uni-muenster.de> <CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
 <8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org>
In-Reply-To: <8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Fri, 22 Mar 2024 10:46:48 -0400
Message-ID: <CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com>
Subject: Re: Adding comments to help understand psql hidden queries
To: Peter Eisentraut <peter@eisentraut.org>
Cc: David Christensen <david+pg@pgguru.net>, Jim Jones <jim.jones@uni-muenster.de>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e44b02061440e6c6"
Archived-At: <https://www.postgresql.org/message-id/CAKAnmmL6-U%2BQPsuWM0r8mNq0Lo80d8L%3DcR7JLk7pypXJfwt%3DEA%40mail.gmail.com>
Precedence: bulk

--000000000000e44b02061440e6c6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 21, 2024 at 6:20=E2=80=AFPM Peter Eisentraut <peter@eisentraut.=
org>
wrote:

> lines are supposed to align vertically.  With your patch, the first line
> would have variable length depending on the command.
>

Yes, that is a good point. Aligning those would be quite tricky, what if we
just kept a standard width for the closing query? Probably the 24 stars we
currently have to match "QUERY", which it appears nobody has changed for
translation purposes yet anyway. (If I am reading the code correctly, it
would be up to the translators to maintain the vertical alignment).

Cheers,
Greg

--000000000000e44b02061440e6c6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Mar 21, 2024 at 6:20=E2=80=AFPM P=
eter Eisentraut &lt;<a href=3D"mailto:peter@eisentraut.org">peter@eisentrau=
t.org</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
lines are supposed to align vertically.=C2=A0 With your patch, the first li=
ne <br>
would have variable length depending on the command.<br></blockquote><div><=
br></div><div>Yes, that is a good point. Aligning those would be quite tric=
ky, what if we just kept a standard width for the closing query?=C2=A0Proba=
bly=C2=A0the 24 stars we currently have to match &quot;QUERY&quot;, which i=
t appears nobody has changed for translation purposes yet anyway. (If I am =
reading the code correctly, it would be up to the translators to maintain t=
he vertical=C2=A0alignment).</div><div><br></div><div>Cheers,</div><div>Gre=
g</div><div>=C2=A0<br></div></div></div>

--000000000000e44b02061440e6c6--