MIME-Version: 1.0
References: 
 <CAKAnmmJz8Hh=8Ru8jgzySPWmLBhnv4=oc_0KRiz-UORJ0Dex+w@mail.gmail.com>
 <CAHM0NXiD15-23=r1B9rHzKhS8e0+zwp_a6PncdLNetyF0xpNpA@mail.gmail.com>
 <c180a366-fecc-4f3a-9c40-79eec526f70c@uni-muenster.de>
 <CAHM0NXheC3YO=ANPX0fCZKcQxMVBdgDzk9fc=-4TTCUN0aLYWA@mail.gmail.com>
 <8c9b9b7d-0868-46d4-963c-8b1906bd7a1b@eisentraut.org>
 <CAKAnmmL6-U+QPsuWM0r8mNq0Lo80d8L=cR7JLk7pypXJfwt=EA@mail.gmail.com>
 <CAHM0NXjO-Thdj+DqT5SOfLGVP-aVKhguiRfmkLDu4BJ_H-gg0A@mail.gmail.com>
 <CAKAnmmJq-13e74uSwDSnx0isA+9N0ByV+cscV4knpWo_mpM1FQ@mail.gmail.com>
 <CAHM0NXi5G9RwtH_MRQkh2jcZMvn8Uubm9pMn=KW-AuwYcNk51w@mail.gmail.com>
 <72f6995a-75a6-4579-9e93-45a80f6bd956@eisentraut.org>
 <CAHM0NXi19okhdByr6cNDwqHtjG7umjbY5OmRMwgropZHs01KGw@mail.gmail.com>
 <CAHM0NXhzU4oZJ00VUvbDL9gLoW2xUTLKZphoRCL3QWLGh5GE7A@mail.gmail.com>
 <2597072.1737232674@sss.pgh.pa.us>
 <CAHM0NXgs4-k3cSg2J0rJd2CPiT40ZfYGs4SK6MAHi-HB3B7dUA@mail.gmail.com>
 <CP4P284MB1968C2980DDC89049E619DD7ECAC2@CP4P284MB1968.BRAP284.PROD.OUTLOOK.COM>
 <CAKAnmmJfa1JsBp8pUYjGXfnHg70f0CynHctin8P8d-Og0pphYA@mail.gmail.com>
 <3616299.1774287304@sss.pgh.pa.us>
In-Reply-To: <3616299.1774287304@sss.pgh.pa.us>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Mon, 23 Mar 2026 18:50:16 -0400
Message-ID: 
 <CAKAnmmLBiq4kMHGVJrGVH5stkxvEFcxjM5c8X650ipX5cG6H-g@mail.gmail.com>
Subject: Re: Adding comments to help understand psql hidden queries
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Maiquel Grassi <grassi@hotmail.com.br>,
 David Christensen <david+pg@pgguru.net>,
	Peter Eisentraut <peter@eisentraut.org>,
 Jim Jones <jim.jones@uni-muenster.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000cd49fb064db8ddf0"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmmLBiq4kMHGVJrGVH5stkxvEFcxjM5c8X650ipX5cG6H-g%40mail.gmail.com>
Precedence: bulk

--000000000000cd49fb064db8ddf0
Content-Type: text/plain; charset="UTF-8"

Thanks for looking this over. I'm pretty happy with the patch as is now. I
agree the INTERNAL QUERY is a nice touch. I once thought about adding
"psql" into the header somehow as a kind of application_name self
labelling, but I think INTERNAL QUERY will be distinct enough.

Notably, I didn't like that some of the headers said "table" and some said
> "relation".  I made them all say "table", although you could certainly
> argue for the opposite.


I originally had "table", but then it felt weird in my testing when I was
describing a sequence or view it said table. So I'm a weak +1 for relation.

--
Cheers,
Greg

--000000000000cd49fb064db8ddf0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Thanks for looking this over. I&#39;m pre=
tty happy with the patch as is now. I agree the INTERNAL QUERY is a nice to=
uch. I once thought about adding &quot;psql&quot; into the header somehow a=
s a kind of application_name self labelling, but I think INTERNAL QUERY wil=
l be distinct enough.<div><br></div></div><div class=3D"gmail_quote gmail_q=
uote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Notably, =
I didn&#39;t like that some of the headers said &quot;table&quot; and some =
said &quot;relation&quot;.=C2=A0 I made them all say &quot;table&quot;, alt=
hough you could certainly argue for the opposite.</blockquote><div><br></di=
v><div>I originally had &quot;table&quot;, but then it felt weird in my tes=
ting when I was describing a sequence or view it said table. So I&#39;m a w=
eak=C2=A0+1 for relation.=C2=A0</div><div><br></div><div>--</div></div><div=
 dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>Cheers,</div><=
div>Greg</div><div><br></div></div></div></div>

--000000000000cd49fb064db8ddf0--