MIME-Version: 1.0
References: <fe99e0ca-e564-480e-b865-5f0cee30bc60@tantorlabs.com>
 <c7ce658a-e0eb-4c5f-92a8-511314d89bbb@tantorlabs.com> <6707FCA9-FD1A-4609-A1A6-142456C14E0C@yandex-team.ru>
In-Reply-To: <6707FCA9-FD1A-4609-A1A6-142456C14E0C@yandex-team.ru>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Tue, 19 Nov 2024 09:39:21 -0500
Message-ID: <CAKAnmmLD8C-Y6CVF74Ccup8h9YpzBYzSvWWRG_Qf8+5YEMh4-g@mail.gmail.com>
Subject: Re: Sample rate added to pg_stat_statements
To: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Cc: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000ec48590627450182"
Archived-At: <https://www.postgresql.org/message-id/CAKAnmmLD8C-Y6CVF74Ccup8h9YpzBYzSvWWRG_Qf8%2B5YEMh4-g%40mail.gmail.com>
Precedence: bulk

--000000000000ec48590627450182
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 19, 2024 at 7:12=E2=80=AFAM Andrey M. Borodin <x4mmm@yandex-tea=
m.ru>
wrote:

> +1 for the idea. I heard a lot of complaints about that pgss is costly.
> Most of them were using it wrong though.


I'm curious what "using it wrong" means exactly?

Oh, and a +1 in general to the patch, OP, although it would also be nice to
start finding the bottlenecks that cause such performance issues.

Cheers,
Greg

--000000000000ec48590627450182
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Nov 19, 2024 at 7:12=E2=80=AFAM A=
ndrey M. Borodin &lt;<a href=3D"mailto:x4mmm@yandex-team.ru">x4mmm@yandex-t=
eam.ru</a>&gt; wrote:</div><div class=3D"gmail_quote"><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">+1 for the idea. I heard a lot of complaints a=
bout that pgss is costly. Most of them were using it wrong though.</blockqu=
ote><div><br></div><div>I&#39;m curious what &quot;using it wrong&quot; mea=
ns exactly?</div><div><br></div><div>Oh, and a=C2=A0+1 in general to the pa=
tch, OP, although it would also be nice to start finding the bottlenecks th=
at cause such performance issues.</div><div><br></div><div>Cheers,</div><di=
v>Greg</div><div><br></div></div></div>

--000000000000ec48590627450182--