MIME-Version: 1.0
References: 
 <CAJTYsWUzok2+mvSYkbVUwq_SWWg-GdHqCuYumN82AU97SjwjCA@mail.gmail.com>
 <CAD21AoBdgM+4X=Wg0T==C9ahenm2nUb=q5AxxeEb_JVoKOzbgw@mail.gmail.com>
 <fe2ay3acydk6sd3iwkvol7t3kgswzfsuaz2vdgqornx4hg7ji2@dpwilwuzq7a2>
 <CAD21AoC48MQ4W5vU1ZPaXXtFPtiacEREN_XXrn3SRRku5cighg@mail.gmail.com>
 <8a2e78c3-2f63-455f-80a9-cbd9eebaa245@eisentraut.org>
 <CAEze2Wgg=HyBqOLOYh_1Nx8GcLWRKvrwPVOE6iqi=9D8mMCACg@mail.gmail.com>
In-Reply-To: 
 <CAEze2Wgg=HyBqOLOYh_1Nx8GcLWRKvrwPVOE6iqi=9D8mMCACg@mail.gmail.com>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Fri, 13 Mar 2026 13:18:09 -0400
Message-ID: 
 <CAKAnmmLVcPH1p=C=K7uAxg1Q+VeCJzty8xr=f7wmJSK3GBzcfQ@mail.gmail.com>
Subject: Re: tid_blockno() and tid_offset() accessor functions
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
	Andres Freund <andres@anarazel.de>,
 Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	pgsql-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000b5a064064ceb0f82"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmmLVcPH1p%3DC%3DK7uAxg1Q%2BVeCJzty8xr%3Df7wmJSK3GBzcfQ%40mail.gmail.com>
Precedence: bulk

--000000000000b5a064064ceb0f82
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 13, 2026 at 1:08=E2=80=AFPM Matthias van de Meent <
boekewurm+postgres@gmail.com> wrote:

> As for naming; I'd personally prefer to have 'heap' included in the names
> here (e.g. heaptid_blkno(tid) or heap_blkno[_of](tid)), because
> not all AMs may map tid.blkno exactly to a block number in the main fork.


All our docs and code mention blocks and offsets as the components of a
tid, so -1 on making things more obtuse.

--=20
Cheers,
Greg

--000000000000b5a064064ceb0f82
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Mar 13, 2026 at 1:08=E2=80=AFPM M=
atthias van de Meent &lt;<a href=3D"mailto:boekewurm%2Bpostgres@gmail.com">=
boekewurm+postgres@gmail.com</a>&gt; wrote:</div><div class=3D"gmail_quote =
gmail_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">As=
 for naming; I&#39;d personally prefer to have &#39;heap&#39; included in t=
he names here (e.g. heaptid_blkno(tid) or heap_blkno[_of](tid)), because<br=
>
not all AMs may map tid.blkno exactly to a block number in the main fork.</=
blockquote><div><br></div><div>All our docs and code mention blocks and off=
sets as the components of a tid, so -1 on making things more obtuse.</div><=
div><br></div></div><span class=3D"gmail_signature_prefix">-- </span><br><d=
iv dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div>Cheers,</div=
><div>Greg</div><div><br></div></div></div></div>

--000000000000b5a064064ceb0f82--