MIME-Version: 1.0
References: 
 <CAEoWx2=SLga-xH09Cq_PAvsHhQHrBK+V0vF821JKgzS=Bm0haA@mail.gmail.com>
 <CAKFQuwZXt2dAuHFs6MtRCzfMP6YZFzssuzdW2woJBVmco=CDdQ@mail.gmail.com>
 <CAEoWx2nic2MaPUEKwb0Me1iwO3LsCf8wUHm55pjqaTRgJEZpcQ@mail.gmail.com>
 <CAKFQuwahxpPKT-LXGJ34BO5cVBUxFxzgNPTY8E_VW-cuNU_DkQ@mail.gmail.com>
 <CAEoWx2kQ9aSn-0LGPKc=woj+h-HR4uBV9TL20aeM3HzLmFqgFQ@mail.gmail.com>
 <6eff5e43-cacd-4a2a-ad1d-e3b313c86050@uni-muenster.de>
 <950BB7B5-0180-4C36-82A0-7E17B920F740@gmail.com>
 <CAEoWx2mZsWnyS_XLDL5mL+yuU_g65p_tmHNesyfngqow7gtS3A@mail.gmail.com>
 <fb70022a-5403-4e16-9efc-28b041f35d9a@uni-muenster.de>
 <8ECD9403-F0BB-4971-94CF-2709EEB4E3B9@gmail.com>
 <f4f70647-8738-48b3-abbd-5b52cde97374@uni-muenster.de>
 <9174F0CF-2F70-4B4F-AED4-CAF113B7F093@gmail.com>
 <14669a83-c7b4-4cdf-890c-dceecd025ee1@uni-muenster.de>
 <3F59D90E-9A47-4C1C-B330-D62D668A462E@gmail.com>
 <5e01263a-1994-44d5-9e98-7212acf9c985@uni-muenster.de>
 <CAKAnmmKzzOWKQVhaAt8LrBmUW=FLWBqS4v8cwKOG53hBToQZRA@mail.gmail.com>
 <D1AB25A4-B3D2-4E57-AE0F-1CBD3823EB19@gmail.com>
In-Reply-To: <D1AB25A4-B3D2-4E57-AE0F-1CBD3823EB19@gmail.com>
From: Greg Sabino Mullane <htamfids@gmail.com>
Date: Wed, 11 Mar 2026 12:39:19 -0400
Message-ID: 
 <CAKAnmmLWdEvFR+-+5HXzMEnd8fLfyvkK4QxtSHMBhoXC5Qvcug@mail.gmail.com>
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
To: Chao Li <li.evan.chao@gmail.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000026be43064cc24934"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKAnmmLWdEvFR%2B-%2B5HXzMEnd8fLfyvkK4QxtSHMBhoXC5Qvcug%40mail.gmail.com>
Precedence: bulk

--00000000000026be43064cc24934
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 11, 2026 at 3:05=E2=80=AFAM Chao Li <li.evan.chao@gmail.com> wr=
ote:

> Are you concerning that rendering the full message text is the extra work=
?
> This is not a hot path, so I don=E2=80=99t think that would be a big deal=
.
> Actually, adding two more fields sounds more expensive


Well, the recurring creation and freeing of the strings is the part that
seems inefficient. But you don't even need to store the strings at all if
you are tracking the action+rel. In such a case, the final strings can be
created on the fly inside of EmitPartitionNoRecurseNotice, right? Then you
just need a list to store the combos of action+relation.

Yes, as SET SCHEMA doesn=E2=80=99t go through the standard ALTER TABLE proc=
ess:
> AlterTable() -> ATController() -> ATPrepCmd().
>
> If you get some idea, please let me know.
>

Nothing worth the trouble, to be honest. As you rightly pointed out, this
is not a hot path.


Cheers,
Greg

--00000000000026be43064cc24934
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">On Wed, Mar 11, 2026 at =
3:05=E2=80=AFAM Chao Li &lt;<a href=3D"mailto:li.evan.chao@gmail.com" targe=
t=3D"_blank">li.evan.chao@gmail.com</a>&gt; wrote:</div><div class=3D"gmail=
_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex">Are you concernin=
g that rendering the full message text is the extra work? This is not a hot=
 path, so I don=E2=80=99t think that would be a big deal. Actually, adding =
two more fields sounds more expensive</blockquote><div><br></div><div>Well,=
 the recurring creation and freeing of the strings is the part that seems i=
nefficient. But you don&#39;t even need to store the strings at all if you =
are tracking the action+rel. In such a case, the final strings can be creat=
ed on the fly inside of=C2=A0EmitPartitionNoRecurseNotice, right? Then you =
just need a list to store the combos of action+relation.</div><div><br></di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex">Yes, as SET SCHEMA does=
n=E2=80=99t go through the standard ALTER TABLE process: AlterTable() -&gt;=
 ATController() -&gt; ATPrepCmd().<br>
<br>
If you get some idea, please let me know.<br></blockquote><div><br></div><d=
iv>Nothing worth the trouble, to be honest. As you rightly pointed out, thi=
s is not a hot path.</div><div><br></div><div><br></div></div><div dir=3D"l=
tr" class=3D"gmail_signature"><div dir=3D"ltr"><div>Cheers,</div><div>Greg<=
/div><div><br></div></div></div></div>
</div>

--00000000000026be43064cc24934--