Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vyWSH-000BOW-1l for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Mar 2026 14:47:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vyWSG-005VPW-02 for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Mar 2026 14:47:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vyWSF-005VPN-1z for pgsql-hackers@lists.postgresql.org; Fri, 06 Mar 2026 14:47:04 +0000 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vyWSE-00000000mlJ-1LA3 for pgsql-hackers@lists.postgresql.org; Fri, 06 Mar 2026 14:47:03 +0000 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-40f0e14b9f9so2822218fac.1 for ; Fri, 06 Mar 2026 06:47:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772808421; cv=none; d=google.com; s=arc-20240605; b=i5dt2pqlihA23blYd44AYFe7uHKzAI4bcyO8uxyvoVb6hBpDCIjouotywDWRHhheMq 406iyU3KYamua+3LQJacwTu0mwQSslQwgbtiXFzOQZTSQ1485cKKLAMVEASKQD6CVFzS RqGqP7HqlvXg+F4z53yApKXf4kGfWwqkrfpVgmBF3qWbDL1EKtw2TQjrxfzj9CQbzYNI VUu/Rnr86hCJn/vOH1JhORClp66WkCSiw0MM37UDiaytq4qiRAsaJfDEsV/5xi4+LXgr MAzzUU96sqSx6btp22RMEHa09IArkRBn1lS92ZDcDxBUe4wwsnQRORn/z8D9Ks+b9P8h 8FRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=4Rm4h+TTA64rZw7coenuPKKPRlzkzv1maViaMFlNyWs=; fh=6ppgGpCP+xdusU7/w6dCOLQL/hRUIlfhqWvhpenoAcg=; b=ejkUW+jqPTRX9Lp97OLNSLNZa3bLb5LftcCu+9eIQ10DCSoWXO639mlwxVdz8KEa6Z S90HYJSHEfcw9tpmBnc6QfNIwtFXsJ6f/HV6I/tLNmiUUc9zDt0+Hie8yKJLJIFpZZ91 yz8qldTfG2eqdmt6EKvGVCp0U8fIXBWbxJR1/4hKIw28W6oyUvDP9rDyBfSqg+d3uh7E fPB8eNcRSmn9s4OsNb+4F7kuPBrkAaztQZvEsTwHrxd7DH4VHe95i+777XQ/DscmBTSi ToG1aVAHOEURS8e1HEFynjqB7KylJUN2zg423DMFt0nofzQNFBvpzt2Xl8mNqEIaRXDl Yn1g==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772808421; x=1773413221; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4Rm4h+TTA64rZw7coenuPKKPRlzkzv1maViaMFlNyWs=; b=P+iScgKeXTC4YDF4neFi6NXN6TsE36Juxzy2zWBFHuNtBt0pPzOGJgHOaSb6weqGeC dL9fqPp04QwDllTcRiBOsSq9WpsCiUAFsuFRYqNOQ7m3D6NALKXrw+HrXTTd1Rcaow4+ Rf0fCZqPe1TbQc+IG/gn7LMnI5TpnG9jt4RqbWJCGSKYU+AzF039WVyWw08APx2vPtAq pJAgO/7gA0hb/P/ByMDr09yJfGWh4FMhmOz1MgfreZJb2Gynyqy52uSawkyfLbJWq+8o kWH+8K7MD/ZjWfKePV+GWmgldJU50FiATAAqxQ4WdOueb/gjDGeF85RfWvVxa2hWFtrb EAeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772808421; x=1773413221; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Rm4h+TTA64rZw7coenuPKKPRlzkzv1maViaMFlNyWs=; b=kKDqu1sGST0T6NzcbQdCSTM//6iG8TAxBwaFsaeOPrJgnO6rabhCYjQ/WKfnbloEch vU31Zc3rPlmFOjGV82qwPOyh/w0Fr0hwgppAPUHpJC1XnsyoMt2f70wqLDRutVbIw1ZX Bx8t/M3wjrhe5BQz3PobffY3dCUT41P/+8xW/BCgOI+s35hwSzlIT0K+9O+B6zLBzztE vBC7DGAnkWo1cc1ZsZVxDo6m9EwfEpp7ZGKViAUPd+6Mj+FWVS17sNUREdyZx7QetMUJ WNhHZweG77BVUyJx6VPH5fRJ1fc1p+NcmKtghUjzVXGqEF9NV2sqTberYJmWddeQwzqf Uevg== X-Gm-Message-State: AOJu0YxLD/+R9hx4CeTgza8BAXZdIsoCXB6sSebqPx00l0sf09Zsdnnq 0TiBx/X9L6CYxc2+RlaMhnA5L8MMMqNHg7yDrXbLxMk2SHN45DrSrLl1rGZ7PSafHsaIjWei7KX XH1qIGNOtH0y7y+wTkQbqIqoEo2jCgJA4jQ== X-Gm-Gg: ATEYQzzW+dEt7oHxqeEa6CYQOc0BEIR6XhV4MaKyD6DM84OhDfwFqzOuqBh+DMJT8gP BQnYZmspNiNiKdEqNZRnrJLUtxfttTyTtv7Ic1WGJgocxQS+0MoqUashDxQeATR/X4xGPmAtTsT P4HBG3whyMpj3Or+W41oEOQ25TYAkcqF8qWOapYZDzGSvrvTeqffEJqWLFZLtcttN7X7r7aVU/Q /ihzALK/bBvc4zwB4GdHgLUgYAG05NQvEFWsFBKGNVSw3wbT8VKKHgbWBsc1G/bmyXeNCxEbAc0 b2kTPuY= X-Received: by 2002:a05:6870:ed8d:b0:404:436d:66ce with SMTP id 586e51a60fabf-416e3f61d54mr1545182fac.23.1772808421325; Fri, 06 Mar 2026 06:47:01 -0800 (PST) MIME-Version: 1.0 References: <1136161.1769654478@sss.pgh.pa.us> In-Reply-To: From: "David G. Johnston" Date: Fri, 6 Mar 2026 07:46:24 -0700 X-Gm-Features: AaiRm52ARp_kKAYOt2IPY-4K2zXQBNx4ut7bwdIbOEwrpcWJgIhFckwoSbaaa6o Message-ID: Subject: Re: pg_plan_advice To: Robert Haas Cc: PostgreSQL Hackers Content-Type: multipart/alternative; boundary="000000000000354115064c5c2050" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000354115064c5c2050 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 4, 2026 at 9:20=E2=80=AFAM Robert Haas = wrote: > On Wed, Mar 4, 2026 at 10:45=E2=80=AFAM David G. Johnston > wrote: > > I do need to work in a way to better annotate/comment on the why of > these. Any suggestions for a better flow or feedback format? Inline > comments wrapped in sgml comments? Or just copy the diff into the email > body and inline comment there - leaving the original diff attachment as-i= s? > > My suggestion is to break these fixes up into three categories: clear > errors, stylistic suggestions, substantive concerns. > > Thank you for putting in the time to respond. That was quite helpful. I've tweaked my tooling to help me remember to do this going forward. David J. --000000000000354115064c5c2050 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 4, 2026 at 9:20=E2=80=AFAM Robert Haas <robertmhaas@gmail.com> wrote:<= /span>
On Wed, Mar 4, 2026 at 10:45=E2= =80=AFAM David G. Johnston
<david.g= .johnston@gmail.com> wrote:
> I do need to work in a way to better annotate/comment on the why of th= ese.=C2=A0 Any suggestions for a better flow or feedback format?=C2=A0 Inli= ne comments wrapped in sgml comments?=C2=A0 Or just copy the diff into the = email body and inline comment there - leaving the original diff attachment = as-is?

My suggestion is to break these fixes up into three categories: clear
errors, stylistic suggestions, substantive concerns.


Thank you for putting in the time to respond.=C2=A0 That wa= s quite helpful.=C2=A0 I've tweaked my tooling to help me remember to d= o this going forward.

David J.

--000000000000354115064c5c2050--