MIME-Version: 1.0
References: 
 <CAKFQuwYe1vf7k+gx_f5ny1mpz_CrhMhaa_NgVb-87_=DHj3JEw@mail.gmail.com>
 <e7286453-7d8c-460d-b6fa-95df54c3ca13@proxel.se>
 <f828ab0a-0231-4673-a407-e550cdc549bd@proxel.se>
In-Reply-To: <f828ab0a-0231-4673-a407-e550cdc549bd@proxel.se>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Fri, 3 Apr 2026 12:44:41 -0700
Message-ID: 
 <CAKFQuwYMbsUQ65CYsyVxKrcqa2BmvRmBh6bAuXocoMEp3sZwGg@mail.gmail.com>
Subject: Re: Docs: Distinguish table and index storage parameters in CREATE
 TABLE
To: Andreas Karlsson <andreas@proxel.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000079bacd064e938e02"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwYMbsUQ65CYsyVxKrcqa2BmvRmBh6bAuXocoMEp3sZwGg%40mail.gmail.com>
Precedence: bulk

--00000000000079bacd064e938e02
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 3, 2026 at 12:35=E2=80=AFPM Andreas Karlsson <andreas@proxel.se=
> wrote:

> On 4/3/26 9:27 PM, Andreas Karlsson wrote:
> > On 4/3/26 8:18 PM, David G. Johnston wrote:
> >> Per the discussion on -general [1] I propose that we stop using the
> >> generic label storage_parameter on the create table reference page and
> >> instead set up proper labels for table and index variants.
> >
> > Nice patch, I like these changes! But you forgot to mention that you
> > added the index storage parameters as in <indexterm>. Not sure if it is
> > worth sending a new version of the patch for but something probably
> > useful for the committer to knw.
>
> Shouldn't also update ALTER INDEX and LATER TABLE to match?
>
>
I gave it a thought and decided there was no ambiguity to resolve on those
pages.

I'm not opposed to it but figured I'd wait for a committer to show interest
and ask the scope to be expanded to a full docs review instead of just
addressing the immediate user-reported confusion.  When I do expand the
scope on my own it seems to scare them off.

David J.

--00000000000079bacd064e938e02
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,helvetica,sans-serif"><span style=3D"font-family:Arial,Helve=
tica,sans-serif">On Fri, Apr 3, 2026 at 12:35=E2=80=AFPM Andreas Karlsson &=
lt;<a href=3D"mailto:andreas@proxel.se">andreas@proxel.se</a>&gt; wrote:</s=
pan></div></div><div class=3D"gmail_quote gmail_quote_container"><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex">On 4/3/26 9:27 PM, Andreas Karlsson=
 wrote:<br>
&gt; On 4/3/26 8:18 PM, David G. Johnston wrote:<br>
&gt;&gt; Per the discussion on -general [1] I propose that we stop using th=
e <br>
&gt;&gt; generic label=C2=A0storage_parameter on the create table reference=
 page and <br>
&gt;&gt; instead set up proper labels for table and index variants.<br>
&gt; <br>
&gt; Nice patch, I like these changes! But you forgot to mention that you <=
br>
&gt; added the index storage parameters as in &lt;indexterm&gt;. Not sure i=
f it is <br>
&gt; worth sending a new version of the patch for but something probably <b=
r>
&gt; useful for the committer to knw.<br>
<br>
Shouldn&#39;t also update ALTER INDEX and LATER TABLE to match?<br><br></bl=
ockquote><div><br></div><div class=3D"gmail_default" style=3D"font-family:a=
rial,helvetica,sans-serif">I gave it a thought and decided there was no amb=
iguity=C2=A0to resolve on those pages.</div><div class=3D"gmail_default" st=
yle=3D"font-family:arial,helvetica,sans-serif"><br></div><div class=3D"gmai=
l_default" style=3D"font-family:arial,helvetica,sans-serif">I&#39;m not opp=
osed to it but figured I&#39;d wait for a committer to show interest and as=
k the scope to be expanded to a full docs review instead of just addressing=
 the immediate user-reported confusion.=C2=A0 When I do expand the scope on=
=C2=A0my own it seems to scare them off.</div><div class=3D"gmail_default" =
style=3D"font-family:arial,helvetica,sans-serif"><br></div><div class=3D"gm=
ail_default" style=3D"font-family:arial,helvetica,sans-serif">David J.</div=
><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-ser=
if"><br></div></div></div>

--00000000000079bacd064e938e02--