MIME-Version: 1.0
In-Reply-To: <b15ecf4f-e5af-4fbb-82c2-a425f453e0b2@oss.nttdata.com>
References: 
 <OSCPR01MB14966930B4357BAE8C9D68A8AF5C72@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAExHW5uOprZgj2rVQ0HT3ckr+fVvhG-DvcVT+wfmwnwynH00pw@mail.gmail.com>
 <OSCPR01MB149660D1F436F8B82912FCB53F5C72@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAExHW5v94uRcr4f3+yhLrLX8UeYusJB06mcSqfdvu8fYUmVc=Q@mail.gmail.com>
 <OS7PR01MB14968CC4F20B99B8E1508CE81F5C32@OS7PR01MB14968.jpnprd01.prod.outlook.com>
 <CAKFQuwYWVT84GM2OqRx8EqNrfzNM-zbpQ5Y2bA1dPO9jUgo_Kg@mail.gmail.com>
 <b15ecf4f-e5af-4fbb-82c2-a425f453e0b2@oss.nttdata.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Mon, 17 Mar 2025 23:10:52 -0700
Message-ID: 
 <CAKFQuwYoBUEYV218EYZeVn7S7S=kdoydw2PnAWszk0aTeS+k6A@mail.gmail.com>
Subject: Re: pg_recvlogical requires -d but not described on the documentation
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000693b48063097c40c"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwYoBUEYV218EYZeVn7S7S%3Dkdoydw2PnAWszk0aTeS%2Bk6A%40mail.gmail.com>
Precedence: bulk

--000000000000693b48063097c40c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, March 17, 2025, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

>
> On 2025/03/12 14:59, David G. Johnston wrote:
>
>> On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) <
>> kuroda.hayato@fujitsu.com <mailto:kuroda.hayato@fujitsu.com>> wrote:
>>
>>
>>     OK, so I will exclude the point in the thread. The patch I've posted
>> contains all of fixes
>>     which is required.
>>
>>
>> The patch fixes the synopsis and the mention of the default value.  Only
>> the later is required.  I cannot figure out a policy that would alter th=
e
>> synopsis in the proposed manner.  I=E2=80=99d suggest leaving it alone f=
or now and
>> tweak any of the option descriptions that may need clarification.
>>
>
> I agree that the synopsis doesn't need to be updated. Attached patch
> clarifies
> the required options for each action in the documentation. Thought?


Will look again tomorrow but seems ok aside from needing an editing pass.

The usage section for help probably needs a look as well.


>
> BTW, I'm curious why --dbname isn't required for the --drop-slot action.
> When I ran
> pg_recvlogical --drop-slot without --dbname, I got the following error:
>
>   pg_recvlogical: error: could not establish database-specific replicatio=
n
> connection
>

That would be a bug.

I think this is too:

set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_basebackup"));

Though I=E2=80=99m not sure what it is doing.

David J.

--000000000000693b48063097c40c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, March 17, 2025, Fujii Masao &lt;<a href=3D"mailto:masao.fujii@os=
s.nttdata.com">masao.fujii@oss.nttdata.com</a>&gt; wrote:<br><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><br>
On 2025/03/12 14:59, David G. Johnston wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) &lt;<a href=3D"mailto=
:kuroda.hayato@fujitsu.com" target=3D"_blank">kuroda.hayato@fujitsu.com</a>=
 &lt;mailto:<a href=3D"mailto:kuroda.hayato@fujitsu.com" target=3D"_blank">=
kuroda.hayato@fujitsu.<wbr>com</a>&gt;&gt; wrote:<br>
<br>
<br>
=C2=A0 =C2=A0 OK, so I will exclude the point in the thread. The patch I=
9;ve posted contains all of fixes<br>
=C2=A0 =C2=A0 which is required.<br>
<br>
<br>
The patch fixes the synopsis and the mention of the default value.=C2=A0 On=
ly the later is required.=C2=A0 I cannot figure out a policy that would alt=
er the synopsis in the proposed manner.=C2=A0 I=E2=80=99d suggest leaving i=
t alone for now and tweak any of the option descriptions that may need clar=
ification.<br>
</blockquote>
<br>
I agree that the synopsis doesn&#39;t need to be updated. Attached patch cl=
arifies<br>
the required options for each action in the documentation. Thought?</blockq=
uote><div><br></div><div>Will look again tomorrow but seems ok aside from n=
eeding an editing pass.</div><div><br></div><div>The usage section for help=
 probably needs a look as well.</div><div>=C2=A0</div><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex">
<br>
BTW, I&#39;m curious why --dbname isn&#39;t required for the --drop-slot ac=
tion. When I ran<br>
pg_recvlogical --drop-slot without --dbname, I got the following error:<br>
<br>
=C2=A0 pg_recvlogical: error: could not establish database-specific replica=
tion connection<br>
</blockquote><div><br></div><div>That would be a bug.</div><div><br></div><=
div>I think this is too:</div><div><br></div><div>set_pglocale_pgservice(ar=
gv[0], PG_TEXTDOMAIN(&quot;pg_basebackup&quot;));<br></div><div><br></div><=
div>Though I=E2=80=99m not sure what it is doing.</div><div><br></div><div>=
David J.</div><div><br></div>

--000000000000693b48063097c40c--