Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxoPc-00HA6V-0U for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Mar 2026 15:45:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vxoPa-00DOe1-1V for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Mar 2026 15:45:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxoPa-00DOdt-0Q for pgsql-hackers@lists.postgresql.org; Wed, 04 Mar 2026 15:45:22 +0000 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vxoPY-00000000YZL-1kWI for pgsql-hackers@lists.postgresql.org; Wed, 04 Mar 2026 15:45:22 +0000 Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-45effa36240so5296598b6e.1 for ; Wed, 04 Mar 2026 07:45:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1772639119; cv=none; d=google.com; s=arc-20240605; b=h22gPY5up3UAvw2GuRB9za2tPt6WMnTZ9hbGglbCUX7+EJ6DllCyHVotz5EJ7Psqx8 g5y5ob0rEeKKy3+vXg2IsbEfUNiWaR/2qvU9VoPh3iIXxhFnXq4o0N0X+ow+tPqptN78 Qdmx+MFNinhFZ+j3wmHYfun57577x1iMpDiy2szsJng8w4beyd+x8/oOV3Uc3mGBh2V7 OoFVEvCfXJVGyPaa+7sj2/T2AO62WVwauJmnJin6di4SI91kiT8SipbVVSZsvlwaS7IO snXmA+OXrNKt+Z2S0kgc67YLesma7zDqwfQpO1BXX+o85baZzRgTMfayyTO2ovGvrUy/ qrFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=KoTdSO8v+8Kn7/PsPDsjlkfKHOaF1xdbneP+WSVw6ho=; fh=P/aLfSNQ2MvR/uVQfIyi6A64w1T7szZd/5P9iSC163o=; b=XOvpPo8mx3flVrJvPkQ6ESzAH7C2hWthd4/akaln7lPo5jafLxVYEVrKHYVBAq+os6 EXD8YVVBNktuuW+EF5tpUvshZbiEo8ishYG0RhRpfPfZD8Qy84h19rYeJ3ezxQ9ZPhTe 6+LE2NRJ6+Wyq/ELEyIavKyZlKQmIpM7IGQFFOsg782v30svvWEk+LnPWBI9/sPTbU7n HXzEPyo4iYyvz0IavDLjlhSAXw1zt1ska/T7bP6/RKpQCtBxgbu+sf9hSfYG6cNtlQbx ke8jXvrhyPridGLWKThwNoPveyypfGGvG3PapaWcmNSQsEmjwnjMwDKUj7zrNWLRTkuP c+Ow==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772639119; x=1773243919; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KoTdSO8v+8Kn7/PsPDsjlkfKHOaF1xdbneP+WSVw6ho=; b=YG6Sd+fVZyYv+lmeaiujgYfBkD7LY4TeWeC0F5mag3QorKEHWObkxcKujUSkoErHOl VUT1A3T1REIKKEr3ihp0q4r3pBSVxBZli6YzjfYwaHFprtvEtuVZOxdjbEPYifh+gdfJ ATC5cd9kW8U5NdXmjgHZ5hpLRPHbtXSGwdnzjjkQFj5TN5oWHtHAaufar6xKIySdbnxi K37PzinY4I1y2ubLVJz64onH1GkOLlAIeCntaqx3Kqli0N8dv/AwZ9cnFkBfZWmr3S4b Off1Yw9MbBWhdBf85rmwCRwdyWp0/JpONwy/rLhBSvx7xU07tOf7Mhh/fx8Rsf8P3F0g GRrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772639119; x=1773243919; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KoTdSO8v+8Kn7/PsPDsjlkfKHOaF1xdbneP+WSVw6ho=; b=iExfv4FtcPDmFaGzMcm9lu0msltRKfPyucLiCeFKRC/HOoGbHGIXfej5iNqCt2YFX3 wsiF6tL9M16tdzK73y0plL9EhEMp028nJbmoFHpIE6Bpjbhl24qAOj+HHzoWMjdaPZB8 OocGGh9/e794u37ui1B9QkTonVV3oilDEIeAI5BhH7t21Tc6wzwwDdMQgyQ4FcXx1rae Ct5P7hpGurrvSU5Gu/KCwUMRT+9yaDdp+Unyi2mWASnSuB+nj1HALDMM1GufjLQXhgJE VnziLyygHD6aCzfpe7vRx/+6DiUDgj8boAjQkIbvInJD505NN91UIQRDl9x8VFEy+mAw U1Og== X-Forwarded-Encrypted: i=1; AJvYcCWDXw2B0NqAVCj5yiqWwGhNlDiReNA0HGF+w4/6RO2IXcLc56gDLLW5PL0U/LSi73kEcunrHR8S5cF0BE/i@lists.postgresql.org X-Gm-Message-State: AOJu0Yxg9KBttVhEbORy7C2yFtdobKnAa6kXTeNwOSWCC3umBHjY/M9z yadLGjwKBrueK2iVijEivkhDIHmrIn76cyGgNUL4jIqgcjhHeL3THO6yja3fHJ4G+/73VRZosLy Lp5H0Gf8xr4E0RgfXtie+yZDra2rzAPk= X-Gm-Gg: ATEYQzwGccAe6l+M3xC5BuCSdpiyv2wJDnb4J2VWYfUqozem2CNPfO+HXwxD5QxYMGO UjVxJH+Ed8Gfe0b8q+AEjehhx9a1fehQWzzadAwtiGNh5pO+8mmEyyUOga3hjGriZWkyTFwz7Au Ha7//1GqzPzGGIKza6g3XCwE/dxwDqqi6qFRukjohyUkXhAhkedDtx1C58WQD/yQUJbCwob93YX FbPM/mIJeBmwrbLBNGMOXHINOQcQZB2YBt/CEUqk3n+Y5v+H34dBLZwG5ORAPDOwHnmsAfk4Eyf ujKcD8lwQwn33sHMjg== X-Received: by 2002:a05:6808:c137:b0:462:d09a:cdca with SMTP id 5614622812f47-4651acaf397mr1196493b6e.32.1772639118771; Wed, 04 Mar 2026 07:45:18 -0800 (PST) MIME-Version: 1.0 References: <1136161.1769654478@sss.pgh.pa.us> In-Reply-To: From: "David G. Johnston" Date: Wed, 4 Mar 2026 08:44:42 -0700 X-Gm-Features: AaiRm52UuLRJDTIBuZQvfSXLCyFsIA6MfQlKldv3qVH9aDqMEUriDfwF4tg30qA Message-ID: Subject: Re: pg_plan_advice To: Robert Haas Cc: Alexandra Wang , Richard Guo , Lukas Fittl , Tom Lane , Jacob Champion , Dian Fay , Matheus Alcantara , Jakub Wartak , PostgreSQL Hackers Content-Type: multipart/alternative; boundary="000000000000fd49d7064c34b496" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000fd49d7064c34b496 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 4, 2026 at 8:17=E2=80=AFAM Robert Haas = wrote: > On Fri, Feb 27, 2026 at 8:16=E2=80=AFPM David G. Johnston > wrote: > > I have a mind to walk through the readmes and sgmls but its going to be > in chunks. Here's one for the readme for pg_plan_advice with a couple of > preliminary sgml changes. > > While I'm grateful for the feedback, I feel like you tend to suggest a > lot of edits that seem like they're just substituting your > idiosyncratic preferences for mine Yeah, some of these end up being mostly stylistic. Though I do try to limit them to ones where I see inconsistency or the style I'm reading just doesn't resonate with me. I usually point out the ones that are IMO material, versus just something that tripped me up while I was reading, but failed to do so here. I do need to work in a way to better annotate/comment on the why of these. Any suggestions for a better flow or feedback format? Inline comments wrapped in sgml comments? Or just copy the diff into the email body and inline comment there - leaving the original diff attachment as-is? > - advice" mini-language. It is intended to allow stabilization of plan > choices > + advice" domain specific language (DSL). It is intended to allow > stabilization of plan choices > > There's a debate to be had about whether it's better to say > mini-language or domain specific language here, but it's hard for me > to decide which is better if all you provide is a diff replacing A > with B. I definitely think it's worse to write (DSL) here. There is no > point in defining an acronym if we're never going to use it anywhere. > > This was truly just a "have you considered using this terminology instead" kind of prompt. The acronym would have been useful when going an replacing the other uses of mini-language that I left alone since I hadn't myself decided which one was better. I didn't do my usual email recap on this first patch which is my bad. I corrected that with the others. David J. --000000000000fd49d7064c34b496 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 4, 2026 at 8:17=E2=80=AFAM Robert Haas <robertmhaas@gmail.com> wrote:<= /span>
On Fri, Feb 27, 2026 at 8:16=E2= =80=AFPM David G. Johnston
<david.g= .johnston@gmail.com> wrote:
> I have a mind to walk through the readmes and sgmls but its going to b= e in chunks.=C2=A0 Here's one for the readme for pg_plan_advice with a = couple of preliminary sgml changes.

While I'm grateful for the feedback, I feel like you tend to suggest a<= br> lot of edits that seem like they're just substituting your
idiosyncratic preferences for mine

Yeah,= some of these end up being mostly stylistic.=C2=A0 Though I do try to limi= t them to ones where I see inconsistency or the style I'm reading just = doesn't resonate with me.=C2=A0 I usually point out the ones that are I= MO material, versus just something that tripped me up while I was reading, = but failed to do so here.

I do need to work in a way t= o better annotate/comment on the why of these.=C2=A0 Any suggestions for a = better flow or feedback format?=C2=A0 Inline comments wrapped in sgml comme= nts?=C2=A0 Or just copy the diff into the email body and inline comment the= re - leaving the original diff attachment as-is?


-=C2=A0 advice" mini-language. It is intended to allow stabilization o= f plan choices
+=C2=A0 advice" domain specific language (DSL). It is intended to allo= w
stabilization of plan choices

There's a debate to be had about whether it's better to say
mini-language or domain specific language here, but it's hard for me to decide which is better if all you provide is a diff replacing A
with B. I definitely think it's worse to write (DSL) here. There is no<= br> point in defining an acronym if we're never going to use it anywhere.

This was truly just a "have you c= onsidered using this terminology instead" kind of prompt.=C2=A0 The ac= ronym would have been useful when going an replacing the other uses of mini= -language that I left alone since I hadn't myself decided which one was= better.

I didn't do my usual email recap on this = first patch which is my bad.=C2=A0 I corrected that with the others.
<= div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif= ">
David J.

--000000000000fd49d7064c34b496--